From: "Jiri Slaby (SUSE)" <jirislaby@kernel.org>
To: jikos@kernel.org
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
"Jiri Slaby (SUSE)" <jirislaby@kernel.org>,
Ping Cheng <ping.cheng@wacom.com>,
Jason Gerecke <jason.gerecke@wacom.com>,
Benjamin Tissoires <benjamin.tissoires@redhat.com>
Subject: [PATCH 2/7] HID: wacom: remove unused hid_data::pressure
Date: Thu, 1 Feb 2024 12:53:15 +0100 [thread overview]
Message-ID: <20240201115320.684-3-jirislaby@kernel.org> (raw)
In-Reply-To: <20240201115320.684-1-jirislaby@kernel.org>
The pressure member in struct hid_data is unused. It was
added in commit 5ae6e89f7409 (HID: wacom: implement the finger part of
the HID generic handling), but never used.
As this is not a struct to communicate with the HW, remove that member.
Found by https://github.com/jirislaby/clang-struct.
Signed-off-by: Jiri Slaby (SUSE) <jirislaby@kernel.org>
Cc: Ping Cheng <ping.cheng@wacom.com>
Cc: Jason Gerecke <jason.gerecke@wacom.com>
Cc: Jiri Kosina <jikos@kernel.org>
Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>
---
drivers/hid/wacom_wac.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/hid/wacom_wac.h b/drivers/hid/wacom_wac.h
index e63b1e806e34..6ec499841f70 100644
--- a/drivers/hid/wacom_wac.h
+++ b/drivers/hid/wacom_wac.h
@@ -309,7 +309,6 @@ struct hid_data {
bool confidence;
int x;
int y;
- int pressure;
int width;
int height;
int id;
--
2.43.0
next prev parent reply other threads:[~2024-02-01 11:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-01 11:53 [PATCH 0/7] HID: unused struct members cleanup Jiri Slaby (SUSE)
2024-02-01 11:53 ` [PATCH 1/7] HID: apple: remove unused members from struct apple_sc_backlight Jiri Slaby (SUSE)
2024-02-14 12:54 ` Aditya Garg
2024-02-01 11:53 ` Jiri Slaby (SUSE) [this message]
2024-02-02 2:30 ` [PATCH 2/7] HID: wacom: remove unused hid_data::pressure Ping Cheng
2024-02-01 11:53 ` [PATCH 3/7] HID: protect hid_device::bpf by CONFIG_HID_BPF Jiri Slaby (SUSE)
2024-02-01 11:53 ` [PATCH 4/7] HID: hid-lg3ff: remove unused struct lg3ff_device Jiri Slaby (SUSE)
2024-02-01 11:53 ` [PATCH 5/7] HID: hid-multitouch: remove unused mt_application::dev_time Jiri Slaby (SUSE)
2024-02-01 11:53 ` [PATCH 6/7] HID: hid-prodikeys: remove unused struct pcmidi_snd members Jiri Slaby (SUSE)
2024-02-01 11:53 ` [PATCH 7/7] HID: hid-prodikeys: remove struct pk_device Jiri Slaby (SUSE)
2024-02-13 10:44 ` [PATCH 0/7] HID: unused struct members cleanup Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240201115320.684-3-jirislaby@kernel.org \
--to=jirislaby@kernel.org \
--cc=benjamin.tissoires@redhat.com \
--cc=jason.gerecke@wacom.com \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ping.cheng@wacom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.