All of lore.kernel.org
 help / color / mirror / Atom feed
From: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
To: intel-gfx@lists.freedesktop.org
Cc: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>,
	Mika Kahola <mika.kahola@intel.com>
Subject: [PATCH 1/1] drm/i915/display: On Xe2 always enable decompression with tile4
Date: Fri,  2 Feb 2024 17:06:02 +0200	[thread overview]
Message-ID: <20240202150602.430036-2-juhapekka.heikkila@gmail.com> (raw)
In-Reply-To: <20240202150602.430036-1-juhapekka.heikkila@gmail.com>

With Xe2 always treat tile4 as if it was using flat ccs.

Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
Reviewed-by: Mika Kahola <mika.kahola@intel.com>
---
 drivers/gpu/drm/i915/display/skl_universal_plane.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/gpu/drm/i915/display/skl_universal_plane.c b/drivers/gpu/drm/i915/display/skl_universal_plane.c
index 511dc1544854..43209909593f 100644
--- a/drivers/gpu/drm/i915/display/skl_universal_plane.c
+++ b/drivers/gpu/drm/i915/display/skl_universal_plane.c
@@ -948,6 +948,11 @@ static u32 skl_plane_ctl(const struct intel_crtc_state *crtc_state,
 	if (DISPLAY_VER(dev_priv) == 13)
 		plane_ctl |= adlp_plane_ctl_arb_slots(plane_state);
 
+	if (GRAPHICS_VER(dev_priv) >= 20 &&
+	    fb->modifier == I915_FORMAT_MOD_4_TILED) {
+		plane_ctl |= PLANE_CTL_RENDER_DECOMPRESSION_ENABLE;
+	}
+
 	return plane_ctl;
 }
 
-- 
2.25.1


  reply	other threads:[~2024-02-02 15:06 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-02 15:06 [PATCH 0/1] Enable ccs compressed framebuffers on Xe2 Juha-Pekka Heikkila
2024-02-02 15:06 ` Juha-Pekka Heikkila [this message]
2024-02-08  9:24   ` [PATCH 1/1] drm/i915/display: On Xe2 always enable decompression with tile4 Jani Nikula
2024-02-02 19:13 ` ✗ Fi.CI.BAT: failure for Enable ccs compressed framebuffers on Xe2 Patchwork
2024-02-02 23:41 ` ✓ Fi.CI.BAT: success for Enable ccs compressed framebuffers on Xe2 (rev2) Patchwork
2024-02-03 10:01 ` ✗ Fi.CI.IGT: failure " Patchwork
2024-02-05 10:42 ` ✗ Fi.CI.BAT: failure for Enable ccs compressed framebuffers on Xe2 (rev3) Patchwork
2024-02-05 14:21 ` ✓ Fi.CI.BAT: success for Enable ccs compressed framebuffers on Xe2 (rev4) Patchwork
2024-02-05 17:11 ` ✗ Fi.CI.IGT: failure " Patchwork
2024-02-05 20:58 ` ✓ Fi.CI.BAT: success for Enable ccs compressed framebuffers on Xe2 (rev5) Patchwork
2024-02-06  2:14 ` ✗ Fi.CI.IGT: failure " Patchwork
2024-02-08  9:10   ` Juha-Pekka Heikkila
2024-02-06  6:59 ` ✓ Fi.CI.BAT: success for Enable ccs compressed framebuffers on Xe2 (rev6) Patchwork
2024-02-06  9:12 ` ✗ Fi.CI.IGT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240202150602.430036-2-juhapekka.heikkila@gmail.com \
    --to=juhapekka.heikkila@gmail.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=mika.kahola@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.