All of lore.kernel.org
 help / color / mirror / Atom feed
From: Catherine Hoang <catherine.hoang@oracle.com>
To: stable@vger.kernel.org
Cc: linux-xfs@vger.kernel.org
Subject: [PATCH 6.6 21/21] xfs: respect the stable writes flag on the RT device
Date: Thu,  8 Feb 2024 15:20:54 -0800	[thread overview]
Message-ID: <20240208232054.15778-22-catherine.hoang@oracle.com> (raw)
In-Reply-To: <20240208232054.15778-1-catherine.hoang@oracle.com>

From: Christoph Hellwig <hch@lst.de>

commit 9c04138414c00ae61421f36ada002712c4bac94a upstream.

Update the per-folio stable writes flag dependening on which device an
inode resides on.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Link: https://lore.kernel.org/r/20231025141020.192413-5-hch@lst.de
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
Signed-off-by: Christian Brauner <brauner@kernel.org>
Signed-off-by: Catherine Hoang <catherine.hoang@oracle.com>
Acked-by: Chandan Babu R <chandanbabu@kernel.org>
---
 fs/xfs/xfs_inode.h | 8 ++++++++
 fs/xfs/xfs_ioctl.c | 8 ++++++++
 fs/xfs/xfs_iops.c  | 7 +++++++
 3 files changed, 23 insertions(+)

diff --git a/fs/xfs/xfs_inode.h b/fs/xfs/xfs_inode.h
index 3dc47937da5d..3beb470f1892 100644
--- a/fs/xfs/xfs_inode.h
+++ b/fs/xfs/xfs_inode.h
@@ -569,6 +569,14 @@ extern void xfs_setup_inode(struct xfs_inode *ip);
 extern void xfs_setup_iops(struct xfs_inode *ip);
 extern void xfs_diflags_to_iflags(struct xfs_inode *ip, bool init);
 
+static inline void xfs_update_stable_writes(struct xfs_inode *ip)
+{
+	if (bdev_stable_writes(xfs_inode_buftarg(ip)->bt_bdev))
+		mapping_set_stable_writes(VFS_I(ip)->i_mapping);
+	else
+		mapping_clear_stable_writes(VFS_I(ip)->i_mapping);
+}
+
 /*
  * When setting up a newly allocated inode, we need to call
  * xfs_finish_inode_setup() once the inode is fully instantiated at
diff --git a/fs/xfs/xfs_ioctl.c b/fs/xfs/xfs_ioctl.c
index be69e7be713e..535f6d38cdb5 100644
--- a/fs/xfs/xfs_ioctl.c
+++ b/fs/xfs/xfs_ioctl.c
@@ -1149,6 +1149,14 @@ xfs_ioctl_setattr_xflags(
 	ip->i_diflags2 = i_flags2;
 
 	xfs_diflags_to_iflags(ip, false);
+
+	/*
+	 * Make the stable writes flag match that of the device the inode
+	 * resides on when flipping the RT flag.
+	 */
+	if (rtflag != XFS_IS_REALTIME_INODE(ip) && S_ISREG(VFS_I(ip)->i_mode))
+		xfs_update_stable_writes(ip);
+
 	xfs_trans_ichgtime(tp, ip, XFS_ICHGTIME_CHG);
 	xfs_trans_log_inode(tp, ip, XFS_ILOG_CORE);
 	XFS_STATS_INC(mp, xs_ig_attrchg);
diff --git a/fs/xfs/xfs_iops.c b/fs/xfs/xfs_iops.c
index 2b3b05c28e9e..b8ec045708c3 100644
--- a/fs/xfs/xfs_iops.c
+++ b/fs/xfs/xfs_iops.c
@@ -1298,6 +1298,13 @@ xfs_setup_inode(
 	gfp_mask = mapping_gfp_mask(inode->i_mapping);
 	mapping_set_gfp_mask(inode->i_mapping, (gfp_mask & ~(__GFP_FS)));
 
+	/*
+	 * For real-time inodes update the stable write flags to that of the RT
+	 * device instead of the data device.
+	 */
+	if (S_ISREG(inode->i_mode) && XFS_IS_REALTIME_INODE(ip))
+		xfs_update_stable_writes(ip);
+
 	/*
 	 * If there is no attribute fork no ACL can exist on this inode,
 	 * and it can't have any file capabilities attached to it either.
-- 
2.39.3


  parent reply	other threads:[~2024-02-08 23:21 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-08 23:20 [PATCH 6.6 00/21] xfs backports for 6.6.y (from v6.7) Catherine Hoang
2024-02-08 23:20 ` [PATCH 6.6 01/21] MAINTAINERS: add Catherine as xfs maintainer for 6.6.y Catherine Hoang
2024-02-08 23:40   ` kernel test robot
2024-02-08 23:20 ` [PATCH 6.6 02/21] xfs: bump max fsgeom struct version Catherine Hoang
2024-02-08 23:20 ` [PATCH 6.6 03/21] xfs: hoist freeing of rt data fork extent mappings Catherine Hoang
2024-02-08 23:20 ` [PATCH 6.6 04/21] xfs: prevent rt growfs when quota is enabled Catherine Hoang
2024-02-08 23:20 ` [PATCH 6.6 05/21] xfs: rt stubs should return negative errnos when rt disabled Catherine Hoang
2024-02-08 23:20 ` [PATCH 6.6 06/21] xfs: fix units conversion error in xfs_bmap_del_extent_delay Catherine Hoang
2024-02-08 23:20 ` [PATCH 6.6 07/21] xfs: make sure maxlen is still congruent with prod when rounding down Catherine Hoang
2024-02-08 23:20 ` [PATCH 6.6 08/21] xfs: introduce protection for drop nlink Catherine Hoang
2024-02-08 23:20 ` [PATCH 6.6 09/21] xfs: handle nimaps=0 from xfs_bmapi_write in xfs_alloc_file_space Catherine Hoang
2024-02-08 23:20 ` [PATCH 6.6 10/21] xfs: allow read IO and FICLONE to run concurrently Catherine Hoang
2024-02-08 23:20 ` [PATCH 6.6 11/21] xfs: factor out xfs_defer_pending_abort Catherine Hoang
2024-02-08 23:20 ` [PATCH 6.6 12/21] xfs: abort intent items when recovery intents fail Catherine Hoang
2024-02-08 23:20 ` [PATCH 6.6 13/21] xfs: only remap the written blocks in xfs_reflink_end_cow_extent Catherine Hoang
2024-02-08 23:20 ` [PATCH 6.6 14/21] xfs: up(ic_sema) if flushing data device fails Catherine Hoang
2024-02-08 23:20 ` [PATCH 6.6 15/21] xfs: fix internal error from AGFL exhaustion Catherine Hoang
2024-02-08 23:20 ` [PATCH 6.6 16/21] xfs: fix again select in kconfig XFS_ONLINE_SCRUB_STATS Catherine Hoang
2024-02-08 23:20 ` [PATCH 6.6 17/21] xfs: inode recovery does not validate the recovered inode Catherine Hoang
2024-02-08 23:20 ` [PATCH 6.6 18/21] xfs: clean up dqblk extraction Catherine Hoang
2024-02-08 23:20 ` [PATCH 6.6 19/21] xfs: dquot recovery does not validate the recovered dquot Catherine Hoang
2024-02-08 23:20 ` [PATCH 6.6 20/21] xfs: clean up FS_XFLAG_REALTIME handling in xfs_ioctl_setattr_xflags Catherine Hoang
2024-02-08 23:20 ` Catherine Hoang [this message]
2024-02-09 18:44 ` [PATCH 6.6 00/21] xfs backports for 6.6.y (from v6.7) Sasha Levin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240208232054.15778-22-catherine.hoang@oracle.com \
    --to=catherine.hoang@oracle.com \
    --cc=linux-xfs@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.