All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ville Syrjala <ville.syrjala@linux.intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: [PATCH 1/5] drm/i915: Fix PLL state check for gmch platforms
Date: Fri,  9 Feb 2024 20:38:05 +0200	[thread overview]
Message-ID: <20240209183809.16887-2-ville.syrjala@linux.intel.com> (raw)
In-Reply-To: <20240209183809.16887-1-ville.syrjala@linux.intel.com>

From: Ville Syrjälä <ville.syrjala@linux.intel.com>

GMCH DPLL state check was mistakenly removed in
commit 87fc875a2b85 ("drm/i915/dg2: Skip shared DPLL handling").
Bring it back.

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 drivers/gpu/drm/i915/display/intel_display.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
index 7db0655d8c9e..f20728b7f67b 100644
--- a/drivers/gpu/drm/i915/display/intel_display.c
+++ b/drivers/gpu/drm/i915/display/intel_display.c
@@ -5215,9 +5215,11 @@ intel_pipe_config_compare(const struct intel_crtc_state *current_config,
 
 	PIPE_CONF_CHECK_BOOL(double_wide);
 
-	if (dev_priv->display.dpll.mgr) {
+	if (dev_priv->display.dpll.mgr)
 		PIPE_CONF_CHECK_P(shared_dpll);
 
+	/* FIXME convert everything over the dpll_mgr */
+	if (dev_priv->display.dpll.mgr || HAS_GMCH(dev_priv)) {
 		PIPE_CONF_CHECK_X(dpll_hw_state.dpll);
 		PIPE_CONF_CHECK_X(dpll_hw_state.dpll_md);
 		PIPE_CONF_CHECK_X(dpll_hw_state.fp0);
-- 
2.43.0


  reply	other threads:[~2024-02-09 18:38 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-09 18:38 [PATCH 0/5] drm/i915: PLL state check stuff Ville Syrjala
2024-02-09 18:38 ` Ville Syrjala [this message]
2024-02-12 14:11   ` [PATCH 1/5] drm/i915: Fix PLL state check for gmch platforms Kahola, Mika
2024-02-09 18:38 ` [PATCH 2/5] drm/i915: Include the CRTC name in the ELD buffer mismatch Ville Syrjala
2024-02-13 10:34   ` Kahola, Mika
2024-02-09 18:38 ` [PATCH 3/5] drm/i915: Reuse ibx_dump_hw_state() for gmch platforms Ville Syrjala
2024-02-13 12:59   ` Kahola, Mika
2024-02-09 18:38 ` [PATCH 4/5] drm/i915: Add PLL .compare_hw_state() vfunc Ville Syrjala
2024-02-13 16:15   ` Kahola, Mika
2024-02-14 23:53     ` Ville Syrjälä
2024-02-14 13:50   ` Jani Nikula
2024-02-14 16:25     ` Ville Syrjälä
2024-02-14 18:03       ` Jani Nikula
2024-02-09 18:38 ` [PATCH 5/5] drm/i915: Enable fastboot across the board Ville Syrjala
2024-02-14  8:58   ` Kahola, Mika
2024-02-09 19:57 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915: PLL state check stuff Patchwork
2024-02-09 19:57 ` ✗ Fi.CI.SPARSE: " Patchwork
2024-02-09 20:09 ` ✓ Fi.CI.BAT: success " Patchwork
2024-02-10  4:53 ` ✗ Fi.CI.IGT: failure " Patchwork
2024-02-10 13:32 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915: PLL state check stuff (rev2) Patchwork
2024-02-10 13:32 ` ✗ Fi.CI.SPARSE: " Patchwork
2024-02-10 13:37 ` ✓ Fi.CI.BAT: success " Patchwork
2024-02-10 15:02 ` ✗ Fi.CI.IGT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240209183809.16887-2-ville.syrjala@linux.intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.