All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ville Syrjala <ville.syrjala@linux.intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: [PATCH 5/5] drm/i915: Enable fastboot across the board
Date: Fri,  9 Feb 2024 20:38:09 +0200	[thread overview]
Message-ID: <20240209183809.16887-6-ville.syrjala@linux.intel.com> (raw)
In-Reply-To: <20240209183809.16887-1-ville.syrjala@linux.intel.com>

From: Ville Syrjälä <ville.syrjala@linux.intel.com>

There's nothing magical about vlv+ platforms vs. fastboot.
If it works somewhere it should work everywhere, assuming
we've not missed any crucial state checks. That seems unlikely
on older platforms with less state to check anyway.

Just enable fastboot across the board, and the remove the
remnants of the optional stuff (we already removed the
modparam for fastboot anyway).

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 drivers/gpu/drm/i915/display/intel_display.c | 22 --------------------
 1 file changed, 22 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
index 66ee6749fdae..00ac65a14029 100644
--- a/drivers/gpu/drm/i915/display/intel_display.c
+++ b/drivers/gpu/drm/i915/display/intel_display.c
@@ -4937,20 +4937,6 @@ pipe_config_pll_mismatch(bool fastset,
 	}
 }
 
-static bool fastboot_enabled(struct drm_i915_private *dev_priv)
-{
-	/* Enable fastboot by default on Skylake and newer */
-	if (DISPLAY_VER(dev_priv) >= 9)
-		return true;
-
-	/* Enable fastboot by default on VLV and CHV */
-	if (IS_VALLEYVIEW(dev_priv) || IS_CHERRYVIEW(dev_priv))
-		return true;
-
-	/* Disabled by default on all others */
-	return false;
-}
-
 bool
 intel_pipe_config_compare(const struct intel_crtc_state *current_config,
 			  const struct intel_crtc_state *pipe_config,
@@ -4959,14 +4945,6 @@ intel_pipe_config_compare(const struct intel_crtc_state *current_config,
 	struct drm_i915_private *dev_priv = to_i915(current_config->uapi.crtc->dev);
 	struct intel_crtc *crtc = to_intel_crtc(pipe_config->uapi.crtc);
 	bool ret = true;
-	bool fixup_inherited = fastset &&
-		current_config->inherited && !pipe_config->inherited;
-
-	if (fixup_inherited && !fastboot_enabled(dev_priv)) {
-		drm_dbg_kms(&dev_priv->drm,
-			    "initial modeset and fastboot not set\n");
-		ret = false;
-	}
 
 #define PIPE_CONF_CHECK_X(name) do { \
 	if (current_config->name != pipe_config->name) { \
-- 
2.43.0


  parent reply	other threads:[~2024-02-09 18:38 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-09 18:38 [PATCH 0/5] drm/i915: PLL state check stuff Ville Syrjala
2024-02-09 18:38 ` [PATCH 1/5] drm/i915: Fix PLL state check for gmch platforms Ville Syrjala
2024-02-12 14:11   ` Kahola, Mika
2024-02-09 18:38 ` [PATCH 2/5] drm/i915: Include the CRTC name in the ELD buffer mismatch Ville Syrjala
2024-02-13 10:34   ` Kahola, Mika
2024-02-09 18:38 ` [PATCH 3/5] drm/i915: Reuse ibx_dump_hw_state() for gmch platforms Ville Syrjala
2024-02-13 12:59   ` Kahola, Mika
2024-02-09 18:38 ` [PATCH 4/5] drm/i915: Add PLL .compare_hw_state() vfunc Ville Syrjala
2024-02-13 16:15   ` Kahola, Mika
2024-02-14 23:53     ` Ville Syrjälä
2024-02-14 13:50   ` Jani Nikula
2024-02-14 16:25     ` Ville Syrjälä
2024-02-14 18:03       ` Jani Nikula
2024-02-09 18:38 ` Ville Syrjala [this message]
2024-02-14  8:58   ` [PATCH 5/5] drm/i915: Enable fastboot across the board Kahola, Mika
2024-02-09 19:57 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915: PLL state check stuff Patchwork
2024-02-09 19:57 ` ✗ Fi.CI.SPARSE: " Patchwork
2024-02-09 20:09 ` ✓ Fi.CI.BAT: success " Patchwork
2024-02-10  4:53 ` ✗ Fi.CI.IGT: failure " Patchwork
2024-02-10 13:32 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915: PLL state check stuff (rev2) Patchwork
2024-02-10 13:32 ` ✗ Fi.CI.SPARSE: " Patchwork
2024-02-10 13:37 ` ✓ Fi.CI.BAT: success " Patchwork
2024-02-10 15:02 ` ✗ Fi.CI.IGT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240209183809.16887-6-ville.syrjala@linux.intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.