All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexey Romanov <avromanov@salutedevices.com>
To: <neil.armstrong@linaro.org>, <clabbe@baylibre.com>,
	<herbert@gondor.apana.org.au>, <davem@davemloft.net>,
	<robh+dt@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>,
	<conor+dt@kernel.org>, <khilman@baylibre.com>,
	<jbrunet@baylibre.com>, <martin.blumenstingl@googlemail.com>,
	<vadim.fedorenko@linux.dev>
Cc: <linux-crypto@vger.kernel.org>,
	<linux-amlogic@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<kernel@salutedevices.com>,
	Alexey Romanov <avromanov@salutedevices.com>
Subject: [PATCH v4 13/20] drivers: crypto: meson: use fallback for 192-bit keys
Date: Mon, 12 Feb 2024 16:51:01 +0300	[thread overview]
Message-ID: <20240212135108.549755-14-avromanov@salutedevices.com> (raw)
In-Reply-To: <20240212135108.549755-1-avromanov@salutedevices.com>

Unforunately, not all Amlogic SoC's have a 192-bit key
support for AES algo. In this case, use fallback.

Signed-off-by: Alexey Romanov <avromanov@salutedevices.com>
---
 drivers/crypto/amlogic/amlogic-gxl-cipher.c | 7 +++++++
 drivers/crypto/amlogic/amlogic-gxl-core.c   | 1 +
 drivers/crypto/amlogic/amlogic-gxl.h        | 2 ++
 3 files changed, 10 insertions(+)

diff --git a/drivers/crypto/amlogic/amlogic-gxl-cipher.c b/drivers/crypto/amlogic/amlogic-gxl-cipher.c
index 828109f4a1c3..da593130553e 100644
--- a/drivers/crypto/amlogic/amlogic-gxl-cipher.c
+++ b/drivers/crypto/amlogic/amlogic-gxl-cipher.c
@@ -41,6 +41,13 @@ static bool meson_cipher_need_fallback_sg(struct skcipher_request *areq,
 
 static bool meson_cipher_need_fallback(struct skcipher_request *areq)
 {
+	struct crypto_skcipher *tfm = crypto_skcipher_reqtfm(areq);
+	struct meson_cipher_tfm_ctx *op = crypto_skcipher_ctx(tfm);
+	struct meson_dev *mc = op->mc;
+
+	if (op->keymode == DESC_MODE_AES_192 && !mc->pdata->support_192bit_key)
+		return true;
+
 	if (areq->cryptlen == 0)
 		return true;
 
diff --git a/drivers/crypto/amlogic/amlogic-gxl-core.c b/drivers/crypto/amlogic/amlogic-gxl-core.c
index f3b5e004b3a5..429c3474028b 100644
--- a/drivers/crypto/amlogic/amlogic-gxl-core.c
+++ b/drivers/crypto/amlogic/amlogic-gxl-core.c
@@ -215,6 +215,7 @@ static const struct meson_pdata meson_gxl_pdata = {
 	.status_reg = 0x4,
 	.need_clk = true,
 	.setup_desc_cnt = 3,
+	.support_192bit_key = true,
 };
 
 static const struct of_device_id meson_crypto_of_match_table[] = {
diff --git a/drivers/crypto/amlogic/amlogic-gxl.h b/drivers/crypto/amlogic/amlogic-gxl.h
index 7f6d91e7b365..2d2777a25453 100644
--- a/drivers/crypto/amlogic/amlogic-gxl.h
+++ b/drivers/crypto/amlogic/amlogic-gxl.h
@@ -98,12 +98,14 @@ struct meson_flow {
  * @reg_status:	offset to status register
  * @need_clk:	clock input is needed
  * @setup_desc_cnt:	number of setup descriptor to configure.
+ * @support_192bit_key:	indicates whether platform support AES 192-bit key
  */
 struct meson_pdata {
 	u32 descs_reg;
 	u32 status_reg;
 	bool need_clk;
 	u32 setup_desc_cnt;
+	bool support_192bit_key;
 };
 
 /*
-- 
2.34.1


WARNING: multiple messages have this Message-ID (diff)
From: Alexey Romanov <avromanov@salutedevices.com>
To: <neil.armstrong@linaro.org>, <clabbe@baylibre.com>,
	<herbert@gondor.apana.org.au>, <davem@davemloft.net>,
	<robh+dt@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>,
	<conor+dt@kernel.org>, <khilman@baylibre.com>,
	<jbrunet@baylibre.com>, <martin.blumenstingl@googlemail.com>,
	<vadim.fedorenko@linux.dev>
Cc: <linux-crypto@vger.kernel.org>,
	<linux-amlogic@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<kernel@salutedevices.com>,
	Alexey Romanov <avromanov@salutedevices.com>
Subject: [PATCH v4 13/20] drivers: crypto: meson: use fallback for 192-bit keys
Date: Mon, 12 Feb 2024 16:51:01 +0300	[thread overview]
Message-ID: <20240212135108.549755-14-avromanov@salutedevices.com> (raw)
In-Reply-To: <20240212135108.549755-1-avromanov@salutedevices.com>

Unforunately, not all Amlogic SoC's have a 192-bit key
support for AES algo. In this case, use fallback.

Signed-off-by: Alexey Romanov <avromanov@salutedevices.com>
---
 drivers/crypto/amlogic/amlogic-gxl-cipher.c | 7 +++++++
 drivers/crypto/amlogic/amlogic-gxl-core.c   | 1 +
 drivers/crypto/amlogic/amlogic-gxl.h        | 2 ++
 3 files changed, 10 insertions(+)

diff --git a/drivers/crypto/amlogic/amlogic-gxl-cipher.c b/drivers/crypto/amlogic/amlogic-gxl-cipher.c
index 828109f4a1c3..da593130553e 100644
--- a/drivers/crypto/amlogic/amlogic-gxl-cipher.c
+++ b/drivers/crypto/amlogic/amlogic-gxl-cipher.c
@@ -41,6 +41,13 @@ static bool meson_cipher_need_fallback_sg(struct skcipher_request *areq,
 
 static bool meson_cipher_need_fallback(struct skcipher_request *areq)
 {
+	struct crypto_skcipher *tfm = crypto_skcipher_reqtfm(areq);
+	struct meson_cipher_tfm_ctx *op = crypto_skcipher_ctx(tfm);
+	struct meson_dev *mc = op->mc;
+
+	if (op->keymode == DESC_MODE_AES_192 && !mc->pdata->support_192bit_key)
+		return true;
+
 	if (areq->cryptlen == 0)
 		return true;
 
diff --git a/drivers/crypto/amlogic/amlogic-gxl-core.c b/drivers/crypto/amlogic/amlogic-gxl-core.c
index f3b5e004b3a5..429c3474028b 100644
--- a/drivers/crypto/amlogic/amlogic-gxl-core.c
+++ b/drivers/crypto/amlogic/amlogic-gxl-core.c
@@ -215,6 +215,7 @@ static const struct meson_pdata meson_gxl_pdata = {
 	.status_reg = 0x4,
 	.need_clk = true,
 	.setup_desc_cnt = 3,
+	.support_192bit_key = true,
 };
 
 static const struct of_device_id meson_crypto_of_match_table[] = {
diff --git a/drivers/crypto/amlogic/amlogic-gxl.h b/drivers/crypto/amlogic/amlogic-gxl.h
index 7f6d91e7b365..2d2777a25453 100644
--- a/drivers/crypto/amlogic/amlogic-gxl.h
+++ b/drivers/crypto/amlogic/amlogic-gxl.h
@@ -98,12 +98,14 @@ struct meson_flow {
  * @reg_status:	offset to status register
  * @need_clk:	clock input is needed
  * @setup_desc_cnt:	number of setup descriptor to configure.
+ * @support_192bit_key:	indicates whether platform support AES 192-bit key
  */
 struct meson_pdata {
 	u32 descs_reg;
 	u32 status_reg;
 	bool need_clk;
 	u32 setup_desc_cnt;
+	bool support_192bit_key;
 };
 
 /*
-- 
2.34.1


_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

WARNING: multiple messages have this Message-ID (diff)
From: Alexey Romanov <avromanov@salutedevices.com>
To: <neil.armstrong@linaro.org>, <clabbe@baylibre.com>,
	<herbert@gondor.apana.org.au>, <davem@davemloft.net>,
	<robh+dt@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>,
	<conor+dt@kernel.org>, <khilman@baylibre.com>,
	<jbrunet@baylibre.com>, <martin.blumenstingl@googlemail.com>,
	<vadim.fedorenko@linux.dev>
Cc: <linux-crypto@vger.kernel.org>,
	<linux-amlogic@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<kernel@salutedevices.com>,
	Alexey Romanov <avromanov@salutedevices.com>
Subject: [PATCH v4 13/20] drivers: crypto: meson: use fallback for 192-bit keys
Date: Mon, 12 Feb 2024 16:51:01 +0300	[thread overview]
Message-ID: <20240212135108.549755-14-avromanov@salutedevices.com> (raw)
In-Reply-To: <20240212135108.549755-1-avromanov@salutedevices.com>

Unforunately, not all Amlogic SoC's have a 192-bit key
support for AES algo. In this case, use fallback.

Signed-off-by: Alexey Romanov <avromanov@salutedevices.com>
---
 drivers/crypto/amlogic/amlogic-gxl-cipher.c | 7 +++++++
 drivers/crypto/amlogic/amlogic-gxl-core.c   | 1 +
 drivers/crypto/amlogic/amlogic-gxl.h        | 2 ++
 3 files changed, 10 insertions(+)

diff --git a/drivers/crypto/amlogic/amlogic-gxl-cipher.c b/drivers/crypto/amlogic/amlogic-gxl-cipher.c
index 828109f4a1c3..da593130553e 100644
--- a/drivers/crypto/amlogic/amlogic-gxl-cipher.c
+++ b/drivers/crypto/amlogic/amlogic-gxl-cipher.c
@@ -41,6 +41,13 @@ static bool meson_cipher_need_fallback_sg(struct skcipher_request *areq,
 
 static bool meson_cipher_need_fallback(struct skcipher_request *areq)
 {
+	struct crypto_skcipher *tfm = crypto_skcipher_reqtfm(areq);
+	struct meson_cipher_tfm_ctx *op = crypto_skcipher_ctx(tfm);
+	struct meson_dev *mc = op->mc;
+
+	if (op->keymode == DESC_MODE_AES_192 && !mc->pdata->support_192bit_key)
+		return true;
+
 	if (areq->cryptlen == 0)
 		return true;
 
diff --git a/drivers/crypto/amlogic/amlogic-gxl-core.c b/drivers/crypto/amlogic/amlogic-gxl-core.c
index f3b5e004b3a5..429c3474028b 100644
--- a/drivers/crypto/amlogic/amlogic-gxl-core.c
+++ b/drivers/crypto/amlogic/amlogic-gxl-core.c
@@ -215,6 +215,7 @@ static const struct meson_pdata meson_gxl_pdata = {
 	.status_reg = 0x4,
 	.need_clk = true,
 	.setup_desc_cnt = 3,
+	.support_192bit_key = true,
 };
 
 static const struct of_device_id meson_crypto_of_match_table[] = {
diff --git a/drivers/crypto/amlogic/amlogic-gxl.h b/drivers/crypto/amlogic/amlogic-gxl.h
index 7f6d91e7b365..2d2777a25453 100644
--- a/drivers/crypto/amlogic/amlogic-gxl.h
+++ b/drivers/crypto/amlogic/amlogic-gxl.h
@@ -98,12 +98,14 @@ struct meson_flow {
  * @reg_status:	offset to status register
  * @need_clk:	clock input is needed
  * @setup_desc_cnt:	number of setup descriptor to configure.
+ * @support_192bit_key:	indicates whether platform support AES 192-bit key
  */
 struct meson_pdata {
 	u32 descs_reg;
 	u32 status_reg;
 	bool need_clk;
 	u32 setup_desc_cnt;
+	bool support_192bit_key;
 };
 
 /*
-- 
2.34.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2024-02-12 13:51 UTC|newest]

Thread overview: 129+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-12 13:50 [PATCH v4 00/20] Support more Amlogic SoC families in crypto driver Alexey Romanov
2024-02-12 13:50 ` Alexey Romanov
2024-02-12 13:50 ` Alexey Romanov
2024-02-12 13:50 ` [PATCH v4 01/20] drivers: crypto: meson: don't hardcode IRQ count Alexey Romanov
2024-02-12 13:50   ` Alexey Romanov
2024-02-12 13:50   ` Alexey Romanov
2024-02-12 13:50 ` [PATCH v4 02/20] drviers: crypto: meson: add platform data Alexey Romanov
2024-02-12 13:50   ` Alexey Romanov
2024-02-12 13:50   ` Alexey Romanov
2024-02-12 17:08   ` neil.armstrong
2024-02-12 17:08     ` neil.armstrong
2024-02-12 17:08     ` neil.armstrong
2024-02-12 13:50 ` [PATCH v4 03/20] drivers: crypto: meson: make CLK controller optional Alexey Romanov
2024-02-12 13:50   ` Alexey Romanov
2024-02-12 13:50   ` Alexey Romanov
2024-02-12 17:10   ` neil.armstrong
2024-02-12 17:10     ` neil.armstrong
2024-02-12 17:10     ` neil.armstrong
2024-02-12 13:50 ` [PATCH v4 04/20] drivers: crypto: meson: add MMIO helpers Alexey Romanov
2024-02-12 13:50   ` Alexey Romanov
2024-02-12 13:50   ` Alexey Romanov
2024-02-12 17:11   ` neil.armstrong
2024-02-12 17:11     ` neil.armstrong
2024-02-12 17:11     ` neil.armstrong
2024-02-12 13:50 ` [PATCH v4 05/20] drivers: crypto: meson: move get_engine_number() Alexey Romanov
2024-02-12 13:50   ` Alexey Romanov
2024-02-12 13:50   ` Alexey Romanov
2024-02-12 17:11   ` neil.armstrong
2024-02-12 17:11     ` neil.armstrong
2024-02-12 17:11     ` neil.armstrong
2024-02-12 13:50 ` [PATCH v4 06/20] drivers: crypto: meson: drop status field from meson_flow Alexey Romanov
2024-02-12 13:50   ` Alexey Romanov
2024-02-12 13:50   ` Alexey Romanov
2024-02-12 17:12   ` neil.armstrong
2024-02-12 17:12     ` neil.armstrong
2024-02-12 17:12     ` neil.armstrong
2024-02-12 13:50 ` [PATCH v4 07/20] drivers: crypto: meson: move algs definition and cipher API to cipher.c Alexey Romanov
2024-02-12 13:50   ` Alexey Romanov
2024-02-12 13:50   ` Alexey Romanov
2024-02-12 17:12   ` neil.armstrong
2024-02-12 17:12     ` neil.armstrong
2024-02-12 17:12     ` neil.armstrong
2024-02-12 13:50 ` [PATCH v4 08/20] drivers: crypto: meson: cleanup defines Alexey Romanov
2024-02-12 13:50   ` Alexey Romanov
2024-02-12 13:50   ` Alexey Romanov
2024-02-12 17:14   ` neil.armstrong
2024-02-12 17:14     ` neil.armstrong
2024-02-12 17:14     ` neil.armstrong
2024-02-12 13:50 ` [PATCH v4 09/20] drivers: crypto: meson: process more than MAXDESCS descriptors Alexey Romanov
2024-02-12 13:50   ` Alexey Romanov
2024-02-12 13:50   ` Alexey Romanov
2024-02-12 13:50 ` [PATCH v4 10/20] drivers: crypto: meson: avoid kzalloc in engine thread Alexey Romanov
2024-02-12 13:50   ` Alexey Romanov
2024-02-12 13:50   ` Alexey Romanov
2024-02-12 17:15   ` neil.armstrong
2024-02-12 17:15     ` neil.armstrong
2024-02-12 17:15     ` neil.armstrong
2024-02-12 13:50 ` [PATCH v4 11/20] drivers: crypto: meson: introduce hasher Alexey Romanov
2024-02-12 13:50   ` Alexey Romanov
2024-02-12 13:50   ` Alexey Romanov
2024-02-12 13:51 ` [PATCH v4 12/20] drivers: crypto: meson: add support for AES-CTR Alexey Romanov
2024-02-12 13:51   ` Alexey Romanov
2024-02-12 13:51   ` Alexey Romanov
2024-02-12 13:51 ` Alexey Romanov [this message]
2024-02-12 13:51   ` [PATCH v4 13/20] drivers: crypto: meson: use fallback for 192-bit keys Alexey Romanov
2024-02-12 13:51   ` Alexey Romanov
2024-02-12 13:51 ` [PATCH v4 14/20] drivers: crypto: meson: add support for G12-series Alexey Romanov
2024-02-12 13:51   ` Alexey Romanov
2024-02-12 13:51   ` Alexey Romanov
2024-02-12 13:51 ` [PATCH v4 15/20] drivers: crypto: meson: add support for AXG-series Alexey Romanov
2024-02-12 13:51   ` Alexey Romanov
2024-02-12 13:51   ` Alexey Romanov
2024-02-12 13:51 ` [PATCH v4 16/20] dt-bindings: crypto: meson: support new SoC's Alexey Romanov
2024-02-12 13:51   ` Alexey Romanov
2024-02-12 13:51   ` Alexey Romanov
2024-02-15 14:28   ` Rob Herring
2024-02-15 14:28     ` Rob Herring
2024-02-15 14:28     ` Rob Herring
2024-02-12 13:51 ` [PATCH v4 17/20] arch: arm64: dts: meson: a1: add crypto node Alexey Romanov
2024-02-12 13:51   ` Alexey Romanov
2024-02-12 13:51   ` Alexey Romanov
2024-02-12 17:04   ` neil.armstrong
2024-02-12 17:04     ` neil.armstrong
2024-02-12 17:04     ` neil.armstrong
2024-02-12 13:51 ` [PATCH v4 18/20] arch: arm64: dts: meson: s4: " Alexey Romanov
2024-02-12 13:51   ` Alexey Romanov
2024-02-12 13:51   ` Alexey Romanov
2024-02-12 17:04   ` neil.armstrong
2024-02-12 17:04     ` neil.armstrong
2024-02-12 17:04     ` neil.armstrong
2024-02-12 13:51 ` [PATCH v4 19/20] arch: arm64: dts: meson: g12: " Alexey Romanov
2024-02-12 13:51   ` Alexey Romanov
2024-02-12 13:51   ` Alexey Romanov
2024-02-12 17:04   ` neil.armstrong
2024-02-12 17:04     ` neil.armstrong
2024-02-12 17:04     ` neil.armstrong
2024-02-12 13:51 ` [PATCH v4 20/20] arch: arm64: dts: meson: axg: " Alexey Romanov
2024-02-12 13:51   ` Alexey Romanov
2024-02-12 13:51   ` Alexey Romanov
2024-02-12 17:04   ` neil.armstrong
2024-02-12 17:04     ` neil.armstrong
2024-02-12 17:04     ` neil.armstrong
2024-02-12 17:04 ` [PATCH v4 00/20] Support more Amlogic SoC families in crypto driver neil.armstrong
2024-02-12 17:04   ` neil.armstrong
2024-02-12 17:04   ` neil.armstrong
2024-02-13  7:21 ` Corentin Labbe
2024-02-13  7:21   ` Corentin Labbe
2024-02-13  7:21   ` Corentin Labbe
2024-02-15 10:43   ` Alexey Romanov
2024-02-15 10:43     ` Alexey Romanov
2024-02-15 10:43     ` Alexey Romanov
2024-02-15 10:47   ` Alexey Romanov
2024-02-15 10:47     ` Alexey Romanov
2024-02-15 10:47     ` Alexey Romanov
2024-02-19  6:57     ` Corentin Labbe
2024-02-19  6:57       ` Corentin Labbe
2024-02-19  6:57       ` Corentin Labbe
2024-02-28 13:37       ` Alexey Romanov
2024-02-28 13:37         ` Alexey Romanov
2024-02-28 13:37         ` Alexey Romanov
2024-02-28 20:19         ` Corentin Labbe
2024-02-28 20:19           ` Corentin Labbe
2024-02-28 20:19           ` Corentin Labbe
2024-02-29 13:05           ` Alexey Romanov
2024-02-29 13:05             ` Alexey Romanov
2024-02-29 13:05             ` Alexey Romanov
2024-02-29 15:14             ` neil.armstrong
2024-02-29 15:14               ` neil.armstrong
2024-02-29 15:14               ` neil.armstrong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240212135108.549755-14-avromanov@salutedevices.com \
    --to=avromanov@salutedevices.com \
    --cc=clabbe@baylibre.com \
    --cc=conor+dt@kernel.org \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=herbert@gondor.apana.org.au \
    --cc=jbrunet@baylibre.com \
    --cc=kernel@salutedevices.com \
    --cc=khilman@baylibre.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=martin.blumenstingl@googlemail.com \
    --cc=neil.armstrong@linaro.org \
    --cc=robh+dt@kernel.org \
    --cc=vadim.fedorenko@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.