From: Tudor Ambarus <tudor.ambarus@linaro.org> To: broonie@kernel.org, robh@kernel.org, andi.shyti@kernel.org, krzysztof.kozlowski@linaro.org, semen.protsenko@linaro.org, conor+dt@kernel.org Cc: alim.akhtar@samsung.com, linux-spi@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, andre.draszik@linaro.org, peter.griffin@linaro.org, kernel-team@android.com, willmcvicker@google.com, devicetree@vger.kernel.org, arnd@arndb.de, Tudor Ambarus <tudor.ambarus@linaro.org> Subject: [PATCH v2 07/12] spi: s3c64xx: let the SPI core determine the bus number Date: Mon, 12 Feb 2024 14:03:26 +0000 [thread overview] Message-ID: <20240212140331.915498-8-tudor.ambarus@linaro.org> (raw) In-Reply-To: <20240212140331.915498-1-tudor.ambarus@linaro.org> Let the core determine the bus number, either by getting the alias ID (as the driver forces now), or by allocating a dynamic bus number when the alias is absent. Prepare the driver to allow dt aliases to be absent. Signed-off-by: Tudor Ambarus <tudor.ambarus@linaro.org> --- drivers/spi/spi-s3c64xx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c index 68f95c04d092..ac47755beb02 100644 --- a/drivers/spi/spi-s3c64xx.c +++ b/drivers/spi/spi-s3c64xx.c @@ -1279,7 +1279,7 @@ static int s3c64xx_spi_probe(struct platform_device *pdev) sdd->rx_dma.direction = DMA_DEV_TO_MEM; host->dev.of_node = pdev->dev.of_node; - host->bus_num = sdd->port_id; + host->bus_num = -1; host->setup = s3c64xx_spi_setup; host->cleanup = s3c64xx_spi_cleanup; host->prepare_transfer_hardware = s3c64xx_spi_prepare_transfer; @@ -1360,7 +1360,7 @@ static int s3c64xx_spi_probe(struct platform_device *pdev) } dev_dbg(&pdev->dev, "Samsung SoC SPI Driver loaded for Bus SPI-%d with %d Targets attached\n", - sdd->port_id, host->num_chipselect); + host->bus_num, host->num_chipselect); dev_dbg(&pdev->dev, "\tIOmem=[%pR]\tFIFO %dbytes\n", mem_res, sdd->fifo_depth); -- 2.43.0.687.g38aa6559b0-goog
WARNING: multiple messages have this Message-ID (diff)
From: Tudor Ambarus <tudor.ambarus@linaro.org> To: broonie@kernel.org, robh@kernel.org, andi.shyti@kernel.org, krzysztof.kozlowski@linaro.org, semen.protsenko@linaro.org, conor+dt@kernel.org Cc: alim.akhtar@samsung.com, linux-spi@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, andre.draszik@linaro.org, peter.griffin@linaro.org, kernel-team@android.com, willmcvicker@google.com, devicetree@vger.kernel.org, arnd@arndb.de, Tudor Ambarus <tudor.ambarus@linaro.org> Subject: [PATCH v2 07/12] spi: s3c64xx: let the SPI core determine the bus number Date: Mon, 12 Feb 2024 14:03:26 +0000 [thread overview] Message-ID: <20240212140331.915498-8-tudor.ambarus@linaro.org> (raw) In-Reply-To: <20240212140331.915498-1-tudor.ambarus@linaro.org> Let the core determine the bus number, either by getting the alias ID (as the driver forces now), or by allocating a dynamic bus number when the alias is absent. Prepare the driver to allow dt aliases to be absent. Signed-off-by: Tudor Ambarus <tudor.ambarus@linaro.org> --- drivers/spi/spi-s3c64xx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c index 68f95c04d092..ac47755beb02 100644 --- a/drivers/spi/spi-s3c64xx.c +++ b/drivers/spi/spi-s3c64xx.c @@ -1279,7 +1279,7 @@ static int s3c64xx_spi_probe(struct platform_device *pdev) sdd->rx_dma.direction = DMA_DEV_TO_MEM; host->dev.of_node = pdev->dev.of_node; - host->bus_num = sdd->port_id; + host->bus_num = -1; host->setup = s3c64xx_spi_setup; host->cleanup = s3c64xx_spi_cleanup; host->prepare_transfer_hardware = s3c64xx_spi_prepare_transfer; @@ -1360,7 +1360,7 @@ static int s3c64xx_spi_probe(struct platform_device *pdev) } dev_dbg(&pdev->dev, "Samsung SoC SPI Driver loaded for Bus SPI-%d with %d Targets attached\n", - sdd->port_id, host->num_chipselect); + host->bus_num, host->num_chipselect); dev_dbg(&pdev->dev, "\tIOmem=[%pR]\tFIFO %dbytes\n", mem_res, sdd->fifo_depth); -- 2.43.0.687.g38aa6559b0-goog _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-02-12 14:03 UTC|newest] Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top 2024-02-12 14:03 [PATCH v2 00/12] spi: s3c64xx: remove OF alias ID dependency Tudor Ambarus 2024-02-12 14:03 ` Tudor Ambarus 2024-02-12 14:03 ` [PATCH v2 01/12] spi: dt-bindings: introduce FIFO depth properties Tudor Ambarus 2024-02-12 14:03 ` Tudor Ambarus 2024-02-12 15:36 ` Rob Herring 2024-02-12 15:36 ` Rob Herring 2024-02-13 8:16 ` Tudor Ambarus 2024-02-13 8:16 ` Tudor Ambarus 2024-02-13 13:14 ` Rob Herring 2024-02-13 13:14 ` Rob Herring 2024-02-16 7:41 ` kernel test robot 2024-02-16 7:41 ` kernel test robot 2024-02-12 14:03 ` [PATCH v2 02/12] spi: s3c64xx: define a magic value Tudor Ambarus 2024-02-12 14:03 ` Tudor Ambarus 2024-02-12 14:03 ` [PATCH v2 03/12] spi: s3c64xx: allow full FIFO masks Tudor Ambarus 2024-02-12 14:03 ` Tudor Ambarus 2024-02-12 14:03 ` [PATCH v2 04/12] spi: s3c64xx: determine the fifo depth only once Tudor Ambarus 2024-02-12 14:03 ` Tudor Ambarus 2024-02-12 14:03 ` [PATCH v2 05/12] spi: s3c64xx: retrieve the FIFO depth from the device tree Tudor Ambarus 2024-02-12 14:03 ` Tudor Ambarus 2024-02-12 14:03 ` [PATCH v2 06/12] spi: s3c64xx: allow FIFO depth to be determined from the compatible Tudor Ambarus 2024-02-12 14:03 ` Tudor Ambarus 2024-02-12 14:03 ` Tudor Ambarus [this message] 2024-02-12 14:03 ` [PATCH v2 07/12] spi: s3c64xx: let the SPI core determine the bus number Tudor Ambarus 2024-02-12 14:03 ` [PATCH v2 08/12] spi: s3c64xx: introduce s3c64xx_spi_set_port_id() Tudor Ambarus 2024-02-12 14:03 ` Tudor Ambarus 2024-02-12 14:03 ` [PATCH v2 09/12] spi: s3c64xx: get rid of the OF alias ID dependency Tudor Ambarus 2024-02-12 14:03 ` Tudor Ambarus 2024-02-12 14:03 ` [PATCH v2 10/12] spi: s3c64xx: deprecate fifo_lvl_mask, rx_lvl_offset and port_id Tudor Ambarus 2024-02-12 14:03 ` Tudor Ambarus 2024-02-12 14:03 ` [PATCH v2 11/12] spi: s3c64xx: switch gs101 to new port config data Tudor Ambarus 2024-02-12 14:03 ` Tudor Ambarus 2024-02-12 14:03 ` [PATCH v2 12/12] spi: s3c64xx: switch exynos850 " Tudor Ambarus 2024-02-12 14:03 ` Tudor Ambarus
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20240212140331.915498-8-tudor.ambarus@linaro.org \ --to=tudor.ambarus@linaro.org \ --cc=alim.akhtar@samsung.com \ --cc=andi.shyti@kernel.org \ --cc=andre.draszik@linaro.org \ --cc=arnd@arndb.de \ --cc=broonie@kernel.org \ --cc=conor+dt@kernel.org \ --cc=devicetree@vger.kernel.org \ --cc=kernel-team@android.com \ --cc=krzysztof.kozlowski@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-samsung-soc@vger.kernel.org \ --cc=linux-spi@vger.kernel.org \ --cc=peter.griffin@linaro.org \ --cc=robh@kernel.org \ --cc=semen.protsenko@linaro.org \ --cc=willmcvicker@google.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.