All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alex Deucher <alexander.deucher@amd.com>
To: <amd-gfx@lists.freedesktop.org>,
	<dri-devel@lists.freedesktop.org>,
	<intel-gfx@lists.freedesktop.org>,
	<intel-xe@lists.freedesktop.org>,
	<tvrtko.ursulin@linux.intel.com>, <daniel@ffwll.ch>
Cc: Alex Deucher <alexander.deucher@amd.com>,
	Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Subject: [PATCH 2/6] drm: add drm_gem_object_is_shared_for_memory_stats() helper
Date: Mon, 12 Feb 2024 16:04:24 -0500	[thread overview]
Message-ID: <20240212210428.851952-3-alexander.deucher@amd.com> (raw)
In-Reply-To: <20240212210428.851952-1-alexander.deucher@amd.com>

Add a helper so that drm drivers can consistently report
shared status via the fdinfo shared memory stats interface.

In addition to handle count, show buffers as shared if they
are shared via dma-buf as well (e.g., shared with v4l or some
other subsystem).

v2: switch to inline function

Link: https://lore.kernel.org/all/20231207180225.439482-1-alexander.deucher@amd.com/
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com> (v1)
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
---
 include/drm/drm_gem.h | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/include/drm/drm_gem.h b/include/drm/drm_gem.h
index 369505447acd..2ebec3984cd4 100644
--- a/include/drm/drm_gem.h
+++ b/include/drm/drm_gem.h
@@ -553,6 +553,19 @@ unsigned long drm_gem_lru_scan(struct drm_gem_lru *lru,
 
 int drm_gem_evict(struct drm_gem_object *obj);
 
+/**
+ * drm_gem_object_is_shared_for_memory_stats - helper for shared memory stats
+ *
+ * This helper should only be used for fdinfo shared memory stats to determine
+ * if a GEM object is shared.
+ *
+ * @obj: obj in question
+ */
+static inline bool drm_gem_object_is_shared_for_memory_stats(struct drm_gem_object *obj)
+{
+	return (obj->handle_count > 1) || obj->dma_buf;
+}
+
 #ifdef CONFIG_LOCKDEP
 /**
  * drm_gem_gpuva_set_lock() - Set the lock protecting accesses to the gpuva list.
-- 
2.42.0


  parent reply	other threads:[~2024-02-12 21:05 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-12 21:04 [PATCH 0/6 V4] fdinfo shared stats Alex Deucher
2024-02-12 21:04 ` [PATCH 1/6] Documentation/gpu: Update documentation on drm-shared-* Alex Deucher
2024-02-12 21:04 ` Alex Deucher [this message]
2024-02-12 21:04 ` [PATCH 3/6] drm: update drm_show_memory_stats() for dma-bufs Alex Deucher
2024-02-12 21:04 ` [PATCH 4/6] drm/amdgpu: add shared fdinfo stats Alex Deucher
2024-02-12 21:04 ` [PATCH 5/6] drm/i915: Update shared stats to use the new gem helper Alex Deucher
2024-02-12 21:04 ` [PATCH 6/6] drm/xe: " Alex Deucher
2024-02-12 23:57 ` ✗ Fi.CI.CHECKPATCH: warning for fdinfo shared stats (rev3) Patchwork
2024-02-12 23:57 ` ✗ Fi.CI.SPARSE: " Patchwork
2024-02-13  0:15 ` ✓ Fi.CI.BAT: success " Patchwork
2024-02-13  3:52 ` ✗ Fi.CI.IGT: failure " Patchwork
2024-02-13  5:29 ` ✓ CI.Patch_applied: success " Patchwork
2024-02-13  5:29 ` ✗ CI.checkpatch: warning " Patchwork
2024-02-13  5:30 ` ✓ CI.KUnit: success " Patchwork
2024-02-13  5:40 ` ✓ CI.Build: " Patchwork
2024-02-13  5:41 ` ✓ CI.Hooks: " Patchwork
2024-02-13  5:42 ` ✗ CI.checksparse: warning " Patchwork
2024-02-13  6:18 ` ✓ CI.BAT: success " Patchwork
2024-02-15 14:12 ` [PATCH 0/6 V4] fdinfo shared stats Christian König
2024-02-15 14:20   ` Alex Deucher
2024-02-16 12:45     ` Christian König
  -- strict thread matches above, loose matches on Subject: below --
2024-01-30 16:12 [PATCH 0/6 V3] " Alex Deucher
2024-01-30 16:12 ` [PATCH 2/6] drm: add drm_gem_object_is_shared_for_memory_stats() helper Alex Deucher
2024-01-30 16:25   ` Tvrtko Ursulin
2024-01-30 17:11   ` Hamza Mahfooz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240212210428.851952-3-alexander.deucher@amd.com \
    --to=alexander.deucher@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=tvrtko.ursulin@intel.com \
    --cc=tvrtko.ursulin@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.