All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: linux-mm@kvack.org
Cc: Matthew Wilcox <willy@infradead.org>, Jan Kara <jack@suse.com>,
	David Howells <dhowells@redhat.com>,
	Brian Foster <bfoster@redhat.com>,
	Christian Brauner <brauner@kernel.org>,
	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
	Jan Kara <jack@suse.cz>, Dave Chinner <dchinner@redhat.com>
Subject: [PATCH 04/14] writeback: also update wbc->nr_to_write on writeback failure
Date: Thu, 15 Feb 2024 07:36:39 +0100	[thread overview]
Message-ID: <20240215063649.2164017-5-hch@lst.de> (raw)
In-Reply-To: <20240215063649.2164017-1-hch@lst.de>

When exiting write_cache_pages early due to a non-integrity write
failure, wbc->nr_to_write currently doesn't account for the folio
we just failed to write.  This doesn't matter because the callers
always ingore the value on a failure, but moving the update to
common code will allow to simplify the code, so do it.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Brian Foster <bfoster@redhat.com>
Reviewed-by: Jan Kara <jack@suse.cz>
Acked-by: Dave Chinner <dchinner@redhat.com>
---
 mm/page-writeback.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/page-writeback.c b/mm/page-writeback.c
index 2679176da316b3..abbee369405a83 100644
--- a/mm/page-writeback.c
+++ b/mm/page-writeback.c
@@ -2473,6 +2473,7 @@ int write_cache_pages(struct address_space *mapping,
 			trace_wbc_writepage(wbc, inode_to_bdi(mapping->host));
 			error = writepage(folio, wbc, data);
 			nr = folio_nr_pages(folio);
+			wbc->nr_to_write -= nr;
 			if (unlikely(error)) {
 				/*
 				 * Handle errors according to the type of
@@ -2506,7 +2507,6 @@ int write_cache_pages(struct address_space *mapping,
 			 * we tagged for writeback prior to entering this loop.
 			 */
 			done_index = folio->index + nr;
-			wbc->nr_to_write -= nr;
 			if (wbc->nr_to_write <= 0 &&
 			    wbc->sync_mode == WB_SYNC_NONE) {
 				done = 1;
-- 
2.39.2


  parent reply	other threads:[~2024-02-15  6:37 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-15  6:36 convert write_cache_pages() to an iterator v8 Christoph Hellwig
2024-02-15  6:36 ` [PATCH 01/14] writeback: don't call mapping_set_error on AOP_WRITEPAGE_ACTIVATE Christoph Hellwig
2024-02-15  9:31   ` Jan Kara
2024-02-15 11:44   ` Brian Foster
2024-02-15  6:36 ` [PATCH 02/14] writeback: remove a duplicate prototype for tag_pages_for_writeback Christoph Hellwig
2024-02-15  6:36 ` [PATCH 03/14] writeback: fix done_index when hitting the wbc->nr_to_write Christoph Hellwig
2024-02-15  6:36 ` Christoph Hellwig [this message]
2024-02-15  6:36 ` [PATCH 05/14] writeback: only update ->writeback_index for range_cyclic writeback Christoph Hellwig
2024-02-15  6:36 ` [PATCH 06/14] writeback: rework the loop termination condition in write_cache_pages Christoph Hellwig
2024-02-15  6:36 ` [PATCH 07/14] writeback: Factor folio_prepare_writeback() out of write_cache_pages() Christoph Hellwig
2024-02-15  6:36 ` [PATCH 08/14] writeback: Factor writeback_get_batch() " Christoph Hellwig
2024-02-15  6:36 ` [PATCH 09/14] writeback: Simplify the loops in write_cache_pages() Christoph Hellwig
2024-02-15  6:36 ` [PATCH 10/14] pagevec: Add ability to iterate a queue Christoph Hellwig
2024-02-15  6:36 ` [PATCH 11/14] writeback: Use the folio_batch queue iterator Christoph Hellwig
2024-02-15  6:36 ` [PATCH 12/14] writeback: Move the folio_prepare_writeback loop out of write_cache_pages() Christoph Hellwig
2024-02-15  6:36 ` [PATCH 13/14] writeback: add a writeback iterator Christoph Hellwig
2024-02-15  6:36 ` [PATCH 14/14] writeback: Remove a use of write_cache_pages() from do_writepages() Christoph Hellwig
2024-02-19  6:28 ` convert write_cache_pages() to an iterator v8 Christoph Hellwig
  -- strict thread matches above, loose matches on Subject: below --
2024-02-12  7:13 convert write_cache_pages() to an iterator v7 Christoph Hellwig
2024-02-12  7:13 ` [PATCH 04/14] writeback: also update wbc->nr_to_write on writeback failure Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240215063649.2164017-5-hch@lst.de \
    --to=hch@lst.de \
    --cc=bfoster@redhat.com \
    --cc=brauner@kernel.org \
    --cc=dchinner@redhat.com \
    --cc=dhowells@redhat.com \
    --cc=jack@suse.com \
    --cc=jack@suse.cz \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.