From: Serge Semin <fancer.lancer@gmail.com>
To: Serge Semin <fancer.lancer@gmail.com>,
Mark Brown <broonie@kernel.org>,
Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Alexey Malahov <Alexey.Malahov@baikalelectronics.ru>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Andy Shevchenko <andy@kernel.org>,
linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 3/3] spi: dw: Drop default number of CS setting
Date: Thu, 15 Feb 2024 21:00:48 +0300 [thread overview]
Message-ID: <20240215180102.13887-4-fancer.lancer@gmail.com> (raw)
In-Reply-To: <20240215180102.13887-1-fancer.lancer@gmail.com>
DW APB/AHB SSI core now supports the procedure which automatically
determines the number of native CS. Thus there is no longer point in
defaulting to four CS if platform doesn't specify the real number.
Signed-off-by: Serge Semin <fancer.lancer@gmail.com>
---
drivers/spi/spi-dw-mmio.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/spi/spi-dw-mmio.c b/drivers/spi/spi-dw-mmio.c
index cc74cbe03431..eb335fcc8720 100644
--- a/drivers/spi/spi-dw-mmio.c
+++ b/drivers/spi/spi-dw-mmio.c
@@ -364,11 +364,8 @@ static int dw_spi_mmio_probe(struct platform_device *pdev)
&dws->reg_io_width))
dws->reg_io_width = 4;
- num_cs = 4;
-
- device_property_read_u32(&pdev->dev, "num-cs", &num_cs);
-
- dws->num_cs = num_cs;
+ if (!device_property_read_u32(&pdev->dev, "num-cs", &num_cs))
+ dws->num_cs = num_cs;
init_func = device_get_match_data(&pdev->dev);
if (init_func) {
--
2.43.0
next prev parent reply other threads:[~2024-02-15 18:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-15 18:00 [PATCH 0/3] spi: dw: Auto-detect number of native CS Serge Semin
2024-02-15 18:00 ` [PATCH 1/3] spi: dw: Convert to using BITS_TO_BYTES() macro Serge Semin
2024-02-15 19:28 ` Andy Shevchenko
2024-02-15 18:00 ` [PATCH 2/3] spi: dw: Add a number of native CS auto-detection Serge Semin
2024-02-15 19:31 ` Andy Shevchenko
2024-02-15 18:00 ` Serge Semin [this message]
2024-02-15 19:32 ` [PATCH 3/3] spi: dw: Drop default number of CS setting Andy Shevchenko
2024-02-16 15:36 ` Serge Semin
2024-02-16 17:00 ` Andy Shevchenko
2024-02-16 18:03 ` Serge Semin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240215180102.13887-4-fancer.lancer@gmail.com \
--to=fancer.lancer@gmail.com \
--cc=Alexey.Malahov@baikalelectronics.ru \
--cc=andriy.shevchenko@linux.intel.com \
--cc=andy.shevchenko@gmail.com \
--cc=andy@kernel.org \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.