From: Johan Hovold <johan+linaro@kernel.org> To: Bjorn Andersson <andersson@kernel.org>, Andrzej Hajda <andrzej.hajda@intel.com>, Neil Armstrong <neil.armstrong@linaro.org>, Robert Foss <rfoss@kernel.org>, Maarten Lankhorst <maarten.lankhorst@linux.intel.com>, Maxime Ripard <mripard@kernel.org>, Thomas Zimmermann <tzimmermann@suse.de>, David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>, Vinod Koul <vkoul@kernel.org> Cc: Jonas Karlman <jonas@kwiboo.se>, Laurent Pinchart <Laurent.pinchart@ideasonboard.com>, Jernej Skrabec <jernej.skrabec@gmail.com>, Konrad Dybcio <konrad.dybcio@linaro.org>, Kishon Vijay Abraham I <kishon@kernel.org>, Dmitry Baryshkov <dmitry.baryshkov@linaro.org>, Rob Clark <robdclark@gmail.com>, Abhinav Kumar <quic_abhinavk@quicinc.com>, Kuogee Hsieh <quic_khsieh@quicinc.com>, freedreno@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, Johan Hovold <johan+linaro@kernel.org>, stable@vger.kernel.org, Bjorn Andersson <quic_bjorande@quicinc.com> Subject: [PATCH 6/6] phy: qcom-qmp-combo: fix type-c switch registration Date: Sat, 17 Feb 2024 16:02:28 +0100 [thread overview] Message-ID: <20240217150228.5788-7-johan+linaro@kernel.org> (raw) In-Reply-To: <20240217150228.5788-1-johan+linaro@kernel.org> Due to a long-standing issue in driver core, drivers may not probe defer after having registered child devices to avoid triggering a probe deferral loop (see fbc35b45f9f6 ("Add documentation on meaning of -EPROBE_DEFER")). Move registration of the typec switch to after looking up clocks and other resources. Note that PHY creation can in theory also trigger a probe deferral when a 'phy' supply is used. This does not seem to affect the QMP PHY driver but the PHY subsystem should be reworked to address this (i.e. by separating initialisation and registration of the PHY). Fixes: 2851117f8f42 ("phy: qcom-qmp-combo: Introduce orientation switching") Cc: stable@vger.kernel.org # 6.5 Cc: Bjorn Andersson <quic_bjorande@quicinc.com> Signed-off-by: Johan Hovold <johan+linaro@kernel.org> --- drivers/phy/qualcomm/phy-qcom-qmp-combo.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-combo.c b/drivers/phy/qualcomm/phy-qcom-qmp-combo.c index e19d6a084f10..17c4ad7553a5 100644 --- a/drivers/phy/qualcomm/phy-qcom-qmp-combo.c +++ b/drivers/phy/qualcomm/phy-qcom-qmp-combo.c @@ -3562,10 +3562,6 @@ static int qmp_combo_probe(struct platform_device *pdev) if (ret) return ret; - ret = qmp_combo_typec_switch_register(qmp); - if (ret) - return ret; - /* Check for legacy binding with child nodes. */ usb_np = of_get_child_by_name(dev->of_node, "usb3-phy"); if (usb_np) { @@ -3585,6 +3581,10 @@ static int qmp_combo_probe(struct platform_device *pdev) if (ret) goto err_node_put; + ret = qmp_combo_typec_switch_register(qmp); + if (ret) + goto err_node_put; + ret = drm_aux_bridge_register(dev); if (ret) goto err_node_put; -- 2.43.0
WARNING: multiple messages have this Message-ID (diff)
From: Johan Hovold <johan+linaro@kernel.org> To: Bjorn Andersson <andersson@kernel.org>, Andrzej Hajda <andrzej.hajda@intel.com>, Neil Armstrong <neil.armstrong@linaro.org>, Robert Foss <rfoss@kernel.org>, Maarten Lankhorst <maarten.lankhorst@linux.intel.com>, Maxime Ripard <mripard@kernel.org>, Thomas Zimmermann <tzimmermann@suse.de>, David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>, Vinod Koul <vkoul@kernel.org> Cc: Jonas Karlman <jonas@kwiboo.se>, Laurent Pinchart <Laurent.pinchart@ideasonboard.com>, Jernej Skrabec <jernej.skrabec@gmail.com>, Konrad Dybcio <konrad.dybcio@linaro.org>, Kishon Vijay Abraham I <kishon@kernel.org>, Dmitry Baryshkov <dmitry.baryshkov@linaro.org>, Rob Clark <robdclark@gmail.com>, Abhinav Kumar <quic_abhinavk@quicinc.com>, Kuogee Hsieh <quic_khsieh@quicinc.com>, freedreno@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, Johan Hovold <johan+linaro@kernel.org>, stable@vger.kernel.org, Bjorn Andersson <quic_bjorande@quicinc.com> Subject: [PATCH 6/6] phy: qcom-qmp-combo: fix type-c switch registration Date: Sat, 17 Feb 2024 16:02:28 +0100 [thread overview] Message-ID: <20240217150228.5788-7-johan+linaro@kernel.org> (raw) In-Reply-To: <20240217150228.5788-1-johan+linaro@kernel.org> Due to a long-standing issue in driver core, drivers may not probe defer after having registered child devices to avoid triggering a probe deferral loop (see fbc35b45f9f6 ("Add documentation on meaning of -EPROBE_DEFER")). Move registration of the typec switch to after looking up clocks and other resources. Note that PHY creation can in theory also trigger a probe deferral when a 'phy' supply is used. This does not seem to affect the QMP PHY driver but the PHY subsystem should be reworked to address this (i.e. by separating initialisation and registration of the PHY). Fixes: 2851117f8f42 ("phy: qcom-qmp-combo: Introduce orientation switching") Cc: stable@vger.kernel.org # 6.5 Cc: Bjorn Andersson <quic_bjorande@quicinc.com> Signed-off-by: Johan Hovold <johan+linaro@kernel.org> --- drivers/phy/qualcomm/phy-qcom-qmp-combo.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-combo.c b/drivers/phy/qualcomm/phy-qcom-qmp-combo.c index e19d6a084f10..17c4ad7553a5 100644 --- a/drivers/phy/qualcomm/phy-qcom-qmp-combo.c +++ b/drivers/phy/qualcomm/phy-qcom-qmp-combo.c @@ -3562,10 +3562,6 @@ static int qmp_combo_probe(struct platform_device *pdev) if (ret) return ret; - ret = qmp_combo_typec_switch_register(qmp); - if (ret) - return ret; - /* Check for legacy binding with child nodes. */ usb_np = of_get_child_by_name(dev->of_node, "usb3-phy"); if (usb_np) { @@ -3585,6 +3581,10 @@ static int qmp_combo_probe(struct platform_device *pdev) if (ret) goto err_node_put; + ret = qmp_combo_typec_switch_register(qmp); + if (ret) + goto err_node_put; + ret = drm_aux_bridge_register(dev); if (ret) goto err_node_put; -- 2.43.0 -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy
next prev parent reply other threads:[~2024-02-17 15:03 UTC|newest] Thread overview: 102+ messages / expand[flat|nested] mbox.gz Atom feed top 2024-02-17 15:02 [PATCH 0/6] soc: qcom: pmic_glink_altmode: fix drm bridge use-after-free Johan Hovold 2024-02-17 15:02 ` Johan Hovold 2024-02-17 15:02 ` [PATCH 1/6] drm/bridge: aux-hpd: fix OF node leaks Johan Hovold 2024-02-17 15:02 ` Johan Hovold 2024-02-19 17:48 ` Markus Elfring 2024-02-19 17:48 ` Markus Elfring 2024-02-20 7:24 ` Johan Hovold 2024-02-20 7:24 ` Johan Hovold 2024-02-20 11:52 ` Julia Lawall 2024-02-20 11:52 ` Julia Lawall 2024-02-20 11:55 ` Dmitry Baryshkov 2024-02-20 11:55 ` Dmitry Baryshkov 2024-02-20 12:56 ` Julia Lawall 2024-02-20 12:56 ` Julia Lawall 2024-02-20 13:35 ` Dmitry Baryshkov 2024-02-20 13:35 ` Dmitry Baryshkov 2024-02-22 1:22 ` Bjorn Andersson 2024-02-22 1:22 ` Bjorn Andersson 2024-02-22 21:00 ` Dmitry Baryshkov 2024-02-22 21:00 ` Dmitry Baryshkov 2024-02-23 10:56 ` Neil Armstrong 2024-02-23 10:56 ` Neil Armstrong 2024-02-23 10:56 ` Neil Armstrong 2024-02-23 10:56 ` Neil Armstrong 2024-02-17 15:02 ` [PATCH 2/6] drm/bridge: aux-hpd: separate allocation and registration Johan Hovold 2024-02-17 15:02 ` Johan Hovold 2024-02-22 2:06 ` Bjorn Andersson 2024-02-22 2:06 ` Bjorn Andersson 2024-02-22 16:06 ` Johan Hovold 2024-02-22 16:06 ` Johan Hovold 2024-02-22 20:57 ` Dmitry Baryshkov 2024-02-22 20:57 ` Dmitry Baryshkov 2024-02-23 12:46 ` Johan Hovold 2024-02-23 12:46 ` Johan Hovold 2024-02-17 15:02 ` [PATCH 3/6] soc: qcom: pmic_glink_altmode: fix drm bridge use-after-free Johan Hovold 2024-02-17 15:02 ` Johan Hovold 2024-02-20 8:25 ` Markus Elfring 2024-02-20 8:25 ` Markus Elfring 2024-02-20 10:55 ` Markus Elfring 2024-02-20 10:55 ` Markus Elfring 2024-02-20 11:26 ` Johan Hovold 2024-02-20 11:26 ` Johan Hovold 2024-02-20 12:40 ` [3/6] " Markus Elfring 2024-02-20 12:40 ` Markus Elfring 2024-02-22 2:11 ` [PATCH 3/6] " Bjorn Andersson 2024-02-22 2:11 ` Bjorn Andersson 2024-02-22 21:10 ` Dmitry Baryshkov 2024-02-22 21:10 ` Dmitry Baryshkov 2024-02-17 15:02 ` [PATCH 4/6] soc: qcom: pmic_glink: Fix boot when QRTR=m Johan Hovold 2024-02-17 15:02 ` Johan Hovold 2024-02-22 2:18 ` Bjorn Andersson 2024-02-22 2:18 ` Bjorn Andersson 2024-02-22 21:10 ` Dmitry Baryshkov 2024-02-22 21:10 ` Dmitry Baryshkov 2024-02-23 11:04 ` Neil Armstrong 2024-02-23 11:04 ` Neil Armstrong 2024-02-17 15:02 ` [PATCH 5/6] phy: qcom-qmp-combo: fix drm bridge registration Johan Hovold 2024-02-17 15:02 ` Johan Hovold 2024-02-19 9:03 ` Neil Armstrong 2024-02-19 9:03 ` Neil Armstrong 2024-02-22 2:21 ` Bjorn Andersson 2024-02-22 2:21 ` Bjorn Andersson 2024-02-22 21:11 ` Dmitry Baryshkov 2024-02-22 21:11 ` Dmitry Baryshkov 2024-02-23 12:09 ` Vinod Koul 2024-02-23 12:09 ` Vinod Koul 2024-02-17 15:02 ` Johan Hovold [this message] 2024-02-17 15:02 ` [PATCH 6/6] phy: qcom-qmp-combo: fix type-c switch registration Johan Hovold 2024-02-22 2:23 ` Bjorn Andersson 2024-02-22 2:23 ` Bjorn Andersson 2024-02-22 21:12 ` Dmitry Baryshkov 2024-02-22 21:12 ` Dmitry Baryshkov 2024-02-23 12:10 ` Vinod Koul 2024-02-23 12:10 ` Vinod Koul 2024-02-23 11:02 ` [PATCH 0/6] soc: qcom: pmic_glink_altmode: fix drm bridge use-after-free Neil Armstrong 2024-02-23 11:02 ` Neil Armstrong 2024-02-23 11:03 ` Neil Armstrong 2024-02-23 11:03 ` Neil Armstrong 2024-02-23 12:51 ` Johan Hovold 2024-02-23 12:51 ` Johan Hovold 2024-02-23 13:52 ` Neil Armstrong 2024-02-23 13:52 ` Neil Armstrong 2024-02-23 14:18 ` Dmitry Baryshkov 2024-02-23 14:18 ` Dmitry Baryshkov 2024-02-23 14:28 ` Johan Hovold 2024-02-23 14:28 ` Johan Hovold 2024-02-23 14:21 ` Johan Hovold 2024-02-23 14:21 ` Johan Hovold 2024-02-23 14:38 ` Neil Armstrong 2024-02-23 14:38 ` Neil Armstrong 2024-02-23 14:52 ` Johan Hovold 2024-02-23 14:52 ` Johan Hovold 2024-02-23 14:55 ` Neil Armstrong 2024-02-23 14:55 ` Neil Armstrong 2024-02-23 15:07 ` Dmitry Baryshkov 2024-02-23 15:07 ` Dmitry Baryshkov 2024-02-23 14:54 ` Neil Armstrong 2024-02-23 14:54 ` Neil Armstrong 2024-02-23 15:06 ` (subset) " Dmitry Baryshkov 2024-02-23 15:06 ` Dmitry Baryshkov 2024-03-06 17:47 ` Vinod Koul 2024-03-06 17:47 ` Vinod Koul
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20240217150228.5788-7-johan+linaro@kernel.org \ --to=johan+linaro@kernel.org \ --cc=Laurent.pinchart@ideasonboard.com \ --cc=airlied@gmail.com \ --cc=andersson@kernel.org \ --cc=andrzej.hajda@intel.com \ --cc=daniel@ffwll.ch \ --cc=dmitry.baryshkov@linaro.org \ --cc=dri-devel@lists.freedesktop.org \ --cc=freedreno@lists.freedesktop.org \ --cc=jernej.skrabec@gmail.com \ --cc=jonas@kwiboo.se \ --cc=kishon@kernel.org \ --cc=konrad.dybcio@linaro.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-phy@lists.infradead.org \ --cc=maarten.lankhorst@linux.intel.com \ --cc=mripard@kernel.org \ --cc=neil.armstrong@linaro.org \ --cc=quic_abhinavk@quicinc.com \ --cc=quic_bjorande@quicinc.com \ --cc=quic_khsieh@quicinc.com \ --cc=rfoss@kernel.org \ --cc=robdclark@gmail.com \ --cc=stable@vger.kernel.org \ --cc=tzimmermann@suse.de \ --cc=vkoul@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.