All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: linux-iio@vger.kernel.org,
	"Rafael J . Wysocki" <rafael@kernel.org>,
	Len Brown <lenb@kernel.org>,
	linux-acpi@vger.kernel.org,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Daniel Scally <djrscally@gmail.com>,
	Heikki Krogerus <heikki.krogerus@linux.intel.com>,
	Sakari Ailus <sakari.ailus@linux.intel.com>,
	Julia Lawall <Julia.Lawall@inria.fr>
Cc: "Nuno Sá" <nuno.sa@analog.com>,
	"Cosmin Tanislav" <cosmin.tanislav@analog.com>,
	"Mihail Chindris" <mihail.chindris@analog.com>,
	"Rasmus Villemoes" <linux@rasmusvillemoes.dk>,
	"Tomislav Denis" <tomislav.denis@avl.com>,
	"Marek Vasut" <marex@denx.de>,
	"Olivier Moysan" <olivier.moysan@foss.st.com>,
	"Fabrice Gasnier" <fabrice.gasnier@foss.st.com>,
	"Lad Prabhakar" <prabhakar.mahadev-lad.rj@bp.renesas.com>,
	"Dmitry Baryshkov" <dmitry.baryshkov@linaro.org>,
	"Marijn Suijten" <marijn.suijten@somainline.org>,
	"Marius Cristea" <marius.cristea@microchip.com>,
	"Ibrahim Tilki" <Ibrahim.Tilki@analog.com>,
	"Peter Zijlstra" <peterz@infradead.org>,
	"Jonathan Cameron" <Jonathan.Cameron@huawei.com>
Subject: [PATCH v4 01/15] device property: Move fwnode_handle_put() into property.h
Date: Sat, 17 Feb 2024 16:42:35 +0000	[thread overview]
Message-ID: <20240217164249.921878-2-jic23@kernel.org> (raw)
In-Reply-To: <20240217164249.921878-1-jic23@kernel.org>

From: Jonathan Cameron <Jonathan.Cameron@huawei.com>

By having this function as static inline in the header, the compiler
is able to see if can optmize the call out if (IS_ERR_OR_NULL(fwnode))
This will allow a simpler DEFINE_FREE() call in the following patch.

Suggested-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
---
 drivers/base/property.c  | 14 --------------
 include/linux/property.h | 14 +++++++++++++-
 2 files changed, 13 insertions(+), 15 deletions(-)

diff --git a/drivers/base/property.c b/drivers/base/property.c
index a1b01ab42052..53e42031c646 100644
--- a/drivers/base/property.c
+++ b/drivers/base/property.c
@@ -923,20 +923,6 @@ struct fwnode_handle *fwnode_handle_get(struct fwnode_handle *fwnode)
 }
 EXPORT_SYMBOL_GPL(fwnode_handle_get);
 
-/**
- * fwnode_handle_put - Drop reference to a device node
- * @fwnode: Pointer to the device node to drop the reference to.
- *
- * This has to be used when terminating device_for_each_child_node() iteration
- * with break or return to prevent stale device node references from being left
- * behind.
- */
-void fwnode_handle_put(struct fwnode_handle *fwnode)
-{
-	fwnode_call_void_op(fwnode, put);
-}
-EXPORT_SYMBOL_GPL(fwnode_handle_put);
-
 /**
  * fwnode_device_is_available - check if a device is available for use
  * @fwnode: Pointer to the fwnode of the device.
diff --git a/include/linux/property.h b/include/linux/property.h
index e6516d0b7d52..151bcab4f92a 100644
--- a/include/linux/property.h
+++ b/include/linux/property.h
@@ -187,7 +187,19 @@ struct fwnode_handle *device_get_named_child_node(const struct device *dev,
 						  const char *childname);
 
 struct fwnode_handle *fwnode_handle_get(struct fwnode_handle *fwnode);
-void fwnode_handle_put(struct fwnode_handle *fwnode);
+
+/**
+ * fwnode_handle_put - Drop reference to a device node
+ * @fwnode: Pointer to the device node to drop the reference to.
+ *
+ * This has to be used when terminating device_for_each_child_node() iteration
+ * with break or return to prevent stale device node references from being left
+ * behind.
+ */
+static inline void fwnode_handle_put(struct fwnode_handle *fwnode)
+{
+	fwnode_call_void_op(fwnode, put);
+}
 
 int fwnode_irq_get(const struct fwnode_handle *fwnode, unsigned int index);
 int fwnode_irq_get_byname(const struct fwnode_handle *fwnode, const char *name);
-- 
2.43.2


  reply	other threads:[~2024-02-17 16:43 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-17 16:42 [PATCH v4 00/15] device property / IIO: Use cleanup.h magic for fwnode_handle_put() handling Jonathan Cameron
2024-02-17 16:42 ` Jonathan Cameron [this message]
2024-02-19  8:55   ` [PATCH v4 01/15] device property: Move fwnode_handle_put() into property.h Greg Kroah-Hartman
2024-02-20  6:55   ` Sakari Ailus
2024-02-17 16:42 ` [PATCH v4 02/15] device property: Add cleanup.h based fwnode_handle_put() scope based cleanup Jonathan Cameron
2024-02-19  8:55   ` Greg Kroah-Hartman
2024-02-20  6:55   ` Sakari Ailus
2024-02-17 16:42 ` [PATCH v4 03/15] iio: temp: ltc2983: Use __free(fwnode_handle) to replace fwnode_handle_put() calls Jonathan Cameron
2024-02-19 13:52   ` Nuno Sá
2024-02-24 11:37     ` Jonathan Cameron
2024-02-17 16:42 ` [PATCH v4 04/15] device property: Introduce device_for_each_child_node_scoped() Jonathan Cameron
2024-02-19  8:56   ` Greg Kroah-Hartman
2024-02-20  6:59   ` Sakari Ailus
2024-02-17 16:42 ` [PATCH v4 05/15] iio: adc: max11410: Use device_for_each_child_node_scoped() Jonathan Cameron
2024-02-19 13:54   ` Nuno Sá
2024-02-17 16:42 ` [PATCH v4 06/15] iio: adc: mcp3564: " Jonathan Cameron
2024-02-17 16:42 ` [PATCH v4 07/15] iio: adc: qcom-spmi-adc5: " Jonathan Cameron
2024-02-17 16:42 ` [PATCH v4 08/15] iio: adc: rzg2l_adc: " Jonathan Cameron
2024-02-17 16:42 ` [PATCH v4 09/15] iio: adc: stm32: " Jonathan Cameron
2024-02-19 11:45   ` Andy Shevchenko
2024-02-24 12:16     ` Jonathan Cameron
2024-02-17 16:42 ` [PATCH v4 10/15] iio: adc: ti-ads1015: " Jonathan Cameron
2024-02-17 16:42 ` [PATCH v4 11/15] iio: adc: ti-ads131e08: " Jonathan Cameron
2024-02-17 16:42 ` [PATCH v4 12/15] iio: addac: ad74413r: " Jonathan Cameron
2024-02-19 13:55   ` Nuno Sá
2024-02-17 16:42 ` [PATCH v4 13/15] iio: dac: ad3552r: " Jonathan Cameron
2024-02-19 11:46   ` Andy Shevchenko
2024-02-17 16:42 ` [PATCH v4 14/15] iio: dac: ad5770r: " Jonathan Cameron
2024-02-17 16:42 ` [PATCH v4 15/15] iio: dac: ltc2688: " Jonathan Cameron
2024-02-19 11:48   ` Andy Shevchenko
2024-02-19 15:48     ` Jonathan Cameron
2024-02-19 13:49   ` Nuno Sá
2024-02-19 11:49 ` [PATCH v4 00/15] device property / IIO: Use cleanup.h magic for fwnode_handle_put() handling Andy Shevchenko
2024-02-19 15:49   ` Jonathan Cameron
2024-02-24 11:49     ` Jonathan Cameron
2024-02-28 14:15       ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240217164249.921878-2-jic23@kernel.org \
    --to=jic23@kernel.org \
    --cc=Ibrahim.Tilki@analog.com \
    --cc=Jonathan.Cameron@huawei.com \
    --cc=Julia.Lawall@inria.fr \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=cosmin.tanislav@analog.com \
    --cc=djrscally@gmail.com \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=fabrice.gasnier@foss.st.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=heikki.krogerus@linux.intel.com \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux@rasmusvillemoes.dk \
    --cc=marex@denx.de \
    --cc=marijn.suijten@somainline.org \
    --cc=marius.cristea@microchip.com \
    --cc=mihail.chindris@analog.com \
    --cc=nuno.sa@analog.com \
    --cc=olivier.moysan@foss.st.com \
    --cc=peterz@infradead.org \
    --cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
    --cc=rafael@kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    --cc=tomislav.denis@avl.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.