From: Linus Walleij <linus.walleij@linaro.org>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
Geert Uytterhoeven <geert@linux-m68k.org>,
Linus Walleij <linus.walleij@linaro.org>
Subject: [PATCH] mmc: sh_mmcif: sg_miter does not need to be atomic
Date: Tue, 20 Feb 2024 23:58:45 +0100 [thread overview]
Message-ID: <20240220-fix-sh-mmcif-v1-1-b9d08a787c1f@linaro.org> (raw)
All the sglist iterations happen in the *threaded* interrupt handler
and that context is not atomic, so don't request an atomic
sglist miter. Using an atomic miter results in "BUG: scheduling while
atomic" splats.
Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
Fixes: 27b57277d9ba ("mmc: sh_mmcif: Use sg_miter for PIO")
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
Hi Geert, it'd be great if you could test this!
---
drivers/mmc/host/sh_mmcif.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/mmc/host/sh_mmcif.c b/drivers/mmc/host/sh_mmcif.c
index 1ef6e153e5a3..669555b5e8fa 100644
--- a/drivers/mmc/host/sh_mmcif.c
+++ b/drivers/mmc/host/sh_mmcif.c
@@ -607,7 +607,7 @@ static void sh_mmcif_single_read(struct sh_mmcif_host *host,
BLOCK_SIZE_MASK) + 3;
sg_miter_start(&host->sg_miter, data->sg, data->sg_len,
- SG_MITER_ATOMIC | SG_MITER_TO_SG);
+ SG_MITER_TO_SG);
host->wait_for = MMCIF_WAIT_FOR_READ;
@@ -662,7 +662,7 @@ static void sh_mmcif_multi_read(struct sh_mmcif_host *host,
BLOCK_SIZE_MASK;
sg_miter_start(&host->sg_miter, data->sg, data->sg_len,
- SG_MITER_ATOMIC | SG_MITER_TO_SG);
+ SG_MITER_TO_SG);
host->wait_for = MMCIF_WAIT_FOR_MREAD;
@@ -710,7 +710,7 @@ static void sh_mmcif_single_write(struct sh_mmcif_host *host,
BLOCK_SIZE_MASK) + 3;
sg_miter_start(&host->sg_miter, data->sg, data->sg_len,
- SG_MITER_ATOMIC | SG_MITER_FROM_SG);
+ SG_MITER_FROM_SG);
host->wait_for = MMCIF_WAIT_FOR_WRITE;
@@ -765,7 +765,7 @@ static void sh_mmcif_multi_write(struct sh_mmcif_host *host,
BLOCK_SIZE_MASK;
sg_miter_start(&host->sg_miter, data->sg, data->sg_len,
- SG_MITER_ATOMIC | SG_MITER_FROM_SG);
+ SG_MITER_FROM_SG);
host->wait_for = MMCIF_WAIT_FOR_MWRITE;
---
base-commit: 2d5c7b7eb345249cb34d42cbc2b97b4c57ea944e
change-id: 20240220-fix-sh-mmcif-49c1de70c5b7
Best regards,
--
Linus Walleij <linus.walleij@linaro.org>
next reply other threads:[~2024-02-20 22:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-20 22:58 Linus Walleij [this message]
2024-02-21 9:43 ` [PATCH] mmc: sh_mmcif: sg_miter does not need to be atomic Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240220-fix-sh-mmcif-v1-1-b9d08a787c1f@linaro.org \
--to=linus.walleij@linaro.org \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.