From: Barry Song <21cnbao@gmail.com>
To: akpm@linux-foundation.org, davem@davemloft.net,
hannes@cmpxchg.org, herbert@gondor.apana.org.au,
linux-crypto@vger.kernel.org, linux-mm@kvack.org,
nphamcs@gmail.com, yosryahmed@google.com,
zhouchengming@bytedance.com
Cc: chriscli@google.com, chrisl@kernel.org, ddstreet@ieee.org,
linux-kernel@vger.kernel.org, sjenning@redhat.com,
vitaly.wool@konsulko.com, Barry Song <v-songbaohua@oppo.com>
Subject: [PATCH v5 1/3] crypto: introduce: acomp_is_async to expose if comp drivers might sleep
Date: Tue, 20 Feb 2024 19:44:12 +1300 [thread overview]
Message-ID: <20240220064414.262582-2-21cnbao@gmail.com> (raw)
In-Reply-To: <20240220064414.262582-1-21cnbao@gmail.com>
From: Barry Song <v-songbaohua@oppo.com>
acomp's users might want to know if acomp is really async to
optimize themselves. One typical user which can benefit from
exposed async stat is zswap.
In zswap, zsmalloc is the most commonly used allocator for
(and perhaps the only one). For zsmalloc, we cannot sleep
while we map the compressed memory, so we copy it to a
temporary buffer. By knowing the alg won't sleep can help
zswap to avoid the need for a buffer. This shows noticeable
improvement in load/store latency of zswap.
Signed-off-by: Barry Song <v-songbaohua@oppo.com>
---
include/crypto/acompress.h | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/include/crypto/acompress.h b/include/crypto/acompress.h
index 574cffc90730..80e243611fe2 100644
--- a/include/crypto/acompress.h
+++ b/include/crypto/acompress.h
@@ -160,6 +160,12 @@ static inline void acomp_request_set_tfm(struct acomp_req *req,
req->base.tfm = crypto_acomp_tfm(tfm);
}
+static inline bool acomp_is_async(struct crypto_acomp *tfm)
+{
+ return crypto_comp_alg_common(tfm)->base.cra_flags &
+ CRYPTO_ALG_ASYNC;
+}
+
static inline struct crypto_acomp *crypto_acomp_reqtfm(struct acomp_req *req)
{
return __crypto_acomp_tfm(req->base.tfm);
--
2.34.1
next prev parent reply other threads:[~2024-02-20 6:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-20 6:44 [PATCH v5 0/3] mm/zswap & crypto/compress: remove a couple of memcpy Barry Song
2024-02-20 6:44 ` Barry Song [this message]
2024-02-21 5:31 ` [PATCH v5 1/3] crypto: introduce: acomp_is_async to expose if comp drivers might sleep Herbert Xu
2024-02-20 6:44 ` [PATCH v5 2/3] mm/zswap: remove the memcpy if acomp is not sleepable Barry Song
2024-02-20 6:44 ` [PATCH v5 3/3] crypto: scompress: remove memcpy if sg_nents is 1 Barry Song
2024-02-21 5:35 ` Herbert Xu
2024-02-21 5:55 ` Barry Song
2024-02-21 6:10 ` Barry Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240220064414.262582-2-21cnbao@gmail.com \
--to=21cnbao@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=chriscli@google.com \
--cc=chrisl@kernel.org \
--cc=davem@davemloft.net \
--cc=ddstreet@ieee.org \
--cc=hannes@cmpxchg.org \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nphamcs@gmail.com \
--cc=sjenning@redhat.com \
--cc=v-songbaohua@oppo.com \
--cc=vitaly.wool@konsulko.com \
--cc=yosryahmed@google.com \
--cc=zhouchengming@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.