All of lore.kernel.org
 help / color / mirror / Atom feed
From: Costa Shulyupin <costa.shul@redhat.com>
To: Thomas Gleixner <tglx@linutronix.de>, linux-kernel@vger.kernel.org
Cc: Costa Shulyupin <costa.shul@redhat.com>,
	Waiman Long <longman@redhat.com>
Subject: [PATCH v4] hrtimer: select housekeeping CPU during migration
Date: Thu, 22 Feb 2024 22:08:56 +0200	[thread overview]
Message-ID: <20240222200856.569036-1-costa.shul@redhat.com> (raw)
In-Reply-To: <20240219143301.4174966-1-costa.shul@redhat.com>

During CPU-down hotplug, hrtimers may migrate to isolated CPUs,
compromising CPU isolation.

Address this issue by masking valid CPUs for hrtimers using
housekeeping_cpumask(HK_TYPE_TIMER).

Suggested-by: Waiman Long <longman@redhat.com>
Signed-off-by: Costa Shulyupin <costa.shul@redhat.com>
Reviewed-by: Waiman Long <longman@redhat.com>
---

Changes in v4:
- fixed description
Changes in v3:
- fixed compilation errors
Changes in v2:
- [v1] https://lore.kernel.org/all/20240211135213.2518068-1-costa.shul@redhat.com/
- reworded and rebased on next

---
 kernel/time/hrtimer.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/kernel/time/hrtimer.c b/kernel/time/hrtimer.c
index 5a98b35b0576..1fd106af747d 100644
--- a/kernel/time/hrtimer.c
+++ b/kernel/time/hrtimer.c
@@ -38,6 +38,7 @@
 #include <linux/sched/deadline.h>
 #include <linux/sched/nohz.h>
 #include <linux/sched/debug.h>
+#include <linux/sched/isolation.h>
 #include <linux/timer.h>
 #include <linux/freezer.h>
 #include <linux/compat.h>
@@ -2225,8 +2226,8 @@ static void migrate_hrtimer_list(struct hrtimer_clock_base *old_base,
 
 int hrtimers_cpu_dying(unsigned int dying_cpu)
 {
+	int i, ncpu = cpumask_any_and(cpu_active_mask, housekeeping_cpumask(HK_TYPE_TIMER));
 	struct hrtimer_cpu_base *old_base, *new_base;
-	int i, ncpu = cpumask_first(cpu_active_mask);
 
 	tick_cancel_sched_timer(dying_cpu);
 
-- 
2.43.0


  parent reply	other threads:[~2024-02-22 20:09 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-11 13:52 [PATCH] hrtimer: select housekeeping CPU during migration Costa Shulyupin
2024-02-11 16:37 ` Waiman Long
2024-02-12 15:23 ` Frederic Weisbecker
2024-02-13 12:36 ` Thomas Gleixner
2024-02-13 16:46 ` [PATCH v2] " Costa Shulyupin
2024-02-13 19:41   ` Thomas Gleixner
2024-02-13 19:49   ` [tip: timers/core] hrtimer: Select " tip-bot2 for Costa Shulyupin
2024-02-14  9:01   ` [PATCH v2] hrtimer: select " Borislav Petkov
2024-02-14  9:10   ` Thomas Gleixner
2024-02-19 14:33   ` [PATCH v3] " Costa Shulyupin
2024-02-19 16:27     ` Thomas Gleixner
2024-02-22 20:08     ` Costa Shulyupin [this message]
2024-02-22 21:24       ` [tip: timers/core] hrtimer: Select " tip-bot2 for Costa Shulyupin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240222200856.569036-1-costa.shul@redhat.com \
    --to=costa.shul@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=longman@redhat.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.