All of lore.kernel.org
 help / color / mirror / Atom feed
From: William Zhang <william.zhang@broadcom.com>
To: Linux MTD List <linux-mtd@lists.infradead.org>,
	Linux ARM List <linux-arm-kernel@lists.infradead.org>,
	Broadcom Kernel List <bcm-kernel-feedback-list@broadcom.com>
Cc: f.fainelli@gmail.com, kursad.oney@broadcom.com,
	joel.peshkin@broadcom.com, anand.gore@broadcom.com,
	dregan@mail.com, kamal.dasu@broadcom.com,
	tomer.yacoby@broadcom.com, dan.beygelman@broadcom.com,
	William Zhang <william.zhang@broadcom.com>,
	Florian Fainelli <florian.fainelli@broadcom.com>,
	David Regan <dregan@broadcom.com>,
	Miquel Raynal <miquel.raynal@bootlin.com>,
	linux-kernel@vger.kernel.org,
	Vignesh Raghavendra <vigneshr@ti.com>,
	Brian Norris <computersforpeace@gmail.com>,
	Richard Weinberger <richard@nod.at>
Subject: [PATCH v6 13/13] mtd: rawnand: brcmnand: Support write protection setting from dts
Date: Thu, 22 Feb 2024 19:47:58 -0800	[thread overview]
Message-ID: <20240223034758.13753-14-william.zhang@broadcom.com> (raw)
In-Reply-To: <20240223034758.13753-1-william.zhang@broadcom.com>

The write protection feature is controlled by the module parameter wp_on
with default set to enabled. But not all the board use this feature
especially in BCMBCA broadband board. And module parameter is not
sufficient as different board can have different option.  Add a device
tree property and allow this feature to be configured through the board
dts on per board basis.

Signed-off-by: William Zhang <william.zhang@broadcom.com>
Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
Reviewed-by: Kamal Dasu <kamal.dasu@broadcom.com>
Reviewed-by: David Regan <dregan@broadcom.com>

---

Changes in v6: None
Changes in v5: None
Changes in v4:
- Use the new brcm,wp-not-connected property based on the dts binding
change

Changes in v3: None
Changes in v2: None

 drivers/mtd/nand/raw/brcmnand/brcmnand.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/mtd/nand/raw/brcmnand/brcmnand.c b/drivers/mtd/nand/raw/brcmnand/brcmnand.c
index e8ffc283b365..4810345d0d8a 100644
--- a/drivers/mtd/nand/raw/brcmnand/brcmnand.c
+++ b/drivers/mtd/nand/raw/brcmnand/brcmnand.c
@@ -3223,6 +3223,10 @@ int brcmnand_probe(struct platform_device *pdev, struct brcmnand_soc *soc)
 	/* Disable XOR addressing */
 	brcmnand_rmw_reg(ctrl, BRCMNAND_CS_XOR, 0xff, 0, 0);
 
+	/* Check if the board connects the WP pin */
+	if (of_property_read_bool(dn, "brcm,wp-not-connected"))
+		wp_on = 0;
+
 	if (ctrl->features & BRCMNAND_HAS_WP) {
 		/* Permanently disable write protection */
 		if (wp_on == 2)
-- 
2.37.3


WARNING: multiple messages have this Message-ID (diff)
From: William Zhang <william.zhang@broadcom.com>
To: Linux MTD List <linux-mtd@lists.infradead.org>,
	Linux ARM List <linux-arm-kernel@lists.infradead.org>,
	Broadcom Kernel List <bcm-kernel-feedback-list@broadcom.com>
Cc: f.fainelli@gmail.com, kursad.oney@broadcom.com,
	joel.peshkin@broadcom.com, anand.gore@broadcom.com,
	dregan@mail.com, kamal.dasu@broadcom.com,
	tomer.yacoby@broadcom.com, dan.beygelman@broadcom.com,
	William Zhang <william.zhang@broadcom.com>,
	Florian Fainelli <florian.fainelli@broadcom.com>,
	David Regan <dregan@broadcom.com>,
	Miquel Raynal <miquel.raynal@bootlin.com>,
	linux-kernel@vger.kernel.org,
	Vignesh Raghavendra <vigneshr@ti.com>,
	Brian Norris <computersforpeace@gmail.com>,
	Richard Weinberger <richard@nod.at>
Subject: [PATCH v6 13/13] mtd: rawnand: brcmnand: Support write protection setting from dts
Date: Thu, 22 Feb 2024 19:47:58 -0800	[thread overview]
Message-ID: <20240223034758.13753-14-william.zhang@broadcom.com> (raw)
In-Reply-To: <20240223034758.13753-1-william.zhang@broadcom.com>

The write protection feature is controlled by the module parameter wp_on
with default set to enabled. But not all the board use this feature
especially in BCMBCA broadband board. And module parameter is not
sufficient as different board can have different option.  Add a device
tree property and allow this feature to be configured through the board
dts on per board basis.

Signed-off-by: William Zhang <william.zhang@broadcom.com>
Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
Reviewed-by: Kamal Dasu <kamal.dasu@broadcom.com>
Reviewed-by: David Regan <dregan@broadcom.com>

---

Changes in v6: None
Changes in v5: None
Changes in v4:
- Use the new brcm,wp-not-connected property based on the dts binding
change

Changes in v3: None
Changes in v2: None

 drivers/mtd/nand/raw/brcmnand/brcmnand.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/mtd/nand/raw/brcmnand/brcmnand.c b/drivers/mtd/nand/raw/brcmnand/brcmnand.c
index e8ffc283b365..4810345d0d8a 100644
--- a/drivers/mtd/nand/raw/brcmnand/brcmnand.c
+++ b/drivers/mtd/nand/raw/brcmnand/brcmnand.c
@@ -3223,6 +3223,10 @@ int brcmnand_probe(struct platform_device *pdev, struct brcmnand_soc *soc)
 	/* Disable XOR addressing */
 	brcmnand_rmw_reg(ctrl, BRCMNAND_CS_XOR, 0xff, 0, 0);
 
+	/* Check if the board connects the WP pin */
+	if (of_property_read_bool(dn, "brcm,wp-not-connected"))
+		wp_on = 0;
+
 	if (ctrl->features & BRCMNAND_HAS_WP) {
 		/* Permanently disable write protection */
 		if (wp_on == 2)
-- 
2.37.3


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: William Zhang <william.zhang@broadcom.com>
To: Linux MTD List <linux-mtd@lists.infradead.org>,
	Linux ARM List <linux-arm-kernel@lists.infradead.org>,
	Broadcom Kernel List <bcm-kernel-feedback-list@broadcom.com>
Cc: f.fainelli@gmail.com, kursad.oney@broadcom.com,
	joel.peshkin@broadcom.com, anand.gore@broadcom.com,
	dregan@mail.com, kamal.dasu@broadcom.com,
	tomer.yacoby@broadcom.com, dan.beygelman@broadcom.com,
	William Zhang <william.zhang@broadcom.com>,
	Florian Fainelli <florian.fainelli@broadcom.com>,
	David Regan <dregan@broadcom.com>,
	Miquel Raynal <miquel.raynal@bootlin.com>,
	linux-kernel@vger.kernel.org,
	Vignesh Raghavendra <vigneshr@ti.com>,
	Brian Norris <computersforpeace@gmail.com>,
	Richard Weinberger <richard@nod.at>
Subject: [PATCH v6 13/13] mtd: rawnand: brcmnand: Support write protection setting from dts
Date: Thu, 22 Feb 2024 19:47:58 -0800	[thread overview]
Message-ID: <20240223034758.13753-14-william.zhang@broadcom.com> (raw)
In-Reply-To: <20240223034758.13753-1-william.zhang@broadcom.com>

The write protection feature is controlled by the module parameter wp_on
with default set to enabled. But not all the board use this feature
especially in BCMBCA broadband board. And module parameter is not
sufficient as different board can have different option.  Add a device
tree property and allow this feature to be configured through the board
dts on per board basis.

Signed-off-by: William Zhang <william.zhang@broadcom.com>
Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
Reviewed-by: Kamal Dasu <kamal.dasu@broadcom.com>
Reviewed-by: David Regan <dregan@broadcom.com>

---

Changes in v6: None
Changes in v5: None
Changes in v4:
- Use the new brcm,wp-not-connected property based on the dts binding
change

Changes in v3: None
Changes in v2: None

 drivers/mtd/nand/raw/brcmnand/brcmnand.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/mtd/nand/raw/brcmnand/brcmnand.c b/drivers/mtd/nand/raw/brcmnand/brcmnand.c
index e8ffc283b365..4810345d0d8a 100644
--- a/drivers/mtd/nand/raw/brcmnand/brcmnand.c
+++ b/drivers/mtd/nand/raw/brcmnand/brcmnand.c
@@ -3223,6 +3223,10 @@ int brcmnand_probe(struct platform_device *pdev, struct brcmnand_soc *soc)
 	/* Disable XOR addressing */
 	brcmnand_rmw_reg(ctrl, BRCMNAND_CS_XOR, 0xff, 0, 0);
 
+	/* Check if the board connects the WP pin */
+	if (of_property_read_bool(dn, "brcm,wp-not-connected"))
+		wp_on = 0;
+
 	if (ctrl->features & BRCMNAND_HAS_WP) {
 		/* Permanently disable write protection */
 		if (wp_on == 2)
-- 
2.37.3


______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

  parent reply	other threads:[~2024-02-23  3:48 UTC|newest]

Thread overview: 120+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-23  3:47 [PATCH v6 00/13] mtd: rawnand: brcmnand: driver and doc updates William Zhang
2024-02-23  3:47 ` William Zhang
2024-02-23  3:47 ` William Zhang
2024-02-23  3:47 ` [PATCH v6 01/13] mtd: rawnand: brcmnand: exec_op helper functions return type fixes William Zhang
2024-02-23  3:47   ` William Zhang
2024-02-23  3:47   ` William Zhang
2024-02-23  4:20   ` Florian Fainelli
2024-02-23  4:20     ` Florian Fainelli
2024-02-23  4:20     ` Florian Fainelli
2024-02-26 10:44   ` Miquel Raynal
2024-02-26 10:44     ` Miquel Raynal
2024-02-26 10:44     ` Miquel Raynal
2024-02-23  3:47 ` [PATCH v6 02/13] mtd: rawnand: brcmnand: fix style issues William Zhang
2024-02-23  3:47   ` William Zhang
2024-02-23  3:47   ` William Zhang
2024-02-26 10:44   ` Miquel Raynal
2024-02-26 10:44     ` Miquel Raynal
2024-02-26 10:44     ` Miquel Raynal
2024-02-23  3:47 ` [PATCH v6 03/13] mtd: rawnand: brcmnand: update log level messages William Zhang
2024-02-23  3:47   ` William Zhang
2024-02-23  3:47   ` William Zhang
2024-02-26 10:44   ` Miquel Raynal
2024-02-26 10:44     ` Miquel Raynal
2024-02-26 10:44     ` Miquel Raynal
2024-02-23  3:47 ` [PATCH v6 04/13] dt-bindings: mtd: brcmnand: Updates for bcmbca SoCs William Zhang
2024-02-23  3:47   ` William Zhang
2024-02-23  3:47   ` William Zhang
2024-02-26 10:44   ` Miquel Raynal
2024-02-26 10:44     ` Miquel Raynal
2024-02-26 10:44     ` Miquel Raynal
2024-02-23  3:47 ` [PATCH v6 05/13] dt-bindings: mtd: brcmnand: Add WP pin connection property William Zhang
2024-02-23  3:47   ` William Zhang
2024-02-23  3:47   ` William Zhang
2024-02-26 10:44   ` Miquel Raynal
2024-02-26 10:44     ` Miquel Raynal
2024-02-26 10:44     ` Miquel Raynal
2024-02-23  3:47 ` [PATCH v6 06/13] dt-bindings: mtd: brcmnand: Add ecc strap property William Zhang
2024-02-23  3:47   ` William Zhang
2024-02-23  3:47   ` William Zhang
2024-02-23 18:47   ` Conor Dooley
2024-02-23 18:47     ` Conor Dooley
2024-02-23 18:47     ` Conor Dooley
2024-02-26 10:44   ` Miquel Raynal
2024-02-26 10:44     ` Miquel Raynal
2024-02-26 10:44     ` Miquel Raynal
2024-02-23  3:47 ` [PATCH v6 07/13] ARM: dts: broadcom: bcmbca: Add NAND controller node William Zhang
2024-02-23  3:47   ` William Zhang
2024-02-23  3:47   ` William Zhang
2024-02-26 10:44   ` Miquel Raynal
2024-02-26 10:44     ` Miquel Raynal
2024-02-26 10:44     ` Miquel Raynal
2024-02-23  3:47 ` [PATCH v6 08/13] arm64: " William Zhang
2024-02-23  3:47   ` William Zhang
2024-02-23  3:47   ` William Zhang
2024-02-26 10:44   ` Miquel Raynal
2024-02-26 10:44     ` Miquel Raynal
2024-02-26 10:44     ` Miquel Raynal
2024-02-23  3:47 ` [PATCH v6 09/13] arm64: dts: broadcom: bcmbca: Update router boards William Zhang
2024-02-23  3:47   ` William Zhang
2024-02-23  3:47   ` William Zhang
2024-02-26 10:44   ` Miquel Raynal
2024-02-26 10:44     ` Miquel Raynal
2024-02-26 10:44     ` Miquel Raynal
2024-02-23  3:47 ` [PATCH v6 10/13] mtd: rawnand: brcmnand: Rename bcm63138 nand driver William Zhang
2024-02-23  3:47   ` William Zhang
2024-02-23  3:47   ` William Zhang
2024-02-26 10:43   ` Miquel Raynal
2024-02-26 10:43     ` Miquel Raynal
2024-02-26 10:43     ` Miquel Raynal
2024-02-23  3:47 ` [PATCH v6 11/13] mtd: rawnand: brcmnand: Add BCMBCA read data bus interface William Zhang
2024-02-23  3:47   ` William Zhang
2024-02-23  3:47   ` William Zhang
2024-02-26 10:43   ` Miquel Raynal
2024-02-26 10:43     ` Miquel Raynal
2024-02-26 10:43     ` Miquel Raynal
2024-02-23  3:47 ` [PATCH v6 12/13] mtd: rawnand: brcmnand: Add support for getting ecc setting from strap William Zhang
2024-02-23  3:47   ` William Zhang
2024-02-23  3:47   ` William Zhang
2024-02-23  9:18   ` Miquel Raynal
2024-02-23  9:18     ` Miquel Raynal
2024-02-23  9:18     ` Miquel Raynal
2024-02-23 17:25     ` William Zhang
2024-02-23 17:25       ` William Zhang
2024-02-23 17:25       ` William Zhang
2024-02-26  8:36       ` Miquel Raynal
2024-02-26  8:36         ` Miquel Raynal
2024-02-26  8:36         ` Miquel Raynal
2024-02-26 20:05         ` William Zhang
2024-02-26 20:05           ` William Zhang
2024-02-26 20:05           ` William Zhang
2024-02-29 10:31           ` Miquel Raynal
2024-02-29 10:31             ` Miquel Raynal
2024-02-29 10:31             ` Miquel Raynal
2024-02-29 23:34             ` William Zhang
2024-02-29 23:34               ` William Zhang
2024-02-29 23:34               ` William Zhang
2024-02-23  3:47 ` William Zhang [this message]
2024-02-23  3:47   ` [PATCH v6 13/13] mtd: rawnand: brcmnand: Support write protection setting from dts William Zhang
2024-02-23  3:47   ` William Zhang
2024-02-26 10:43   ` Miquel Raynal
2024-02-26 10:43     ` Miquel Raynal
2024-02-26 10:43     ` Miquel Raynal
2024-02-26 17:36 ` [PATCH v6 00/13] mtd: rawnand: brcmnand: driver and doc updates Florian Fainelli
2024-02-26 17:36   ` Florian Fainelli
2024-02-26 17:36   ` Florian Fainelli
2024-02-29  9:11   ` Miquel Raynal
2024-02-29  9:11     ` Miquel Raynal
2024-02-29  9:11     ` Miquel Raynal
2024-02-29 17:32     ` Florian Fainelli
2024-02-29 17:32       ` Florian Fainelli
2024-02-29 17:32       ` Florian Fainelli
2024-03-14 22:04     ` Miquel Raynal
2024-03-14 22:04       ` Miquel Raynal
2024-03-14 22:04       ` Miquel Raynal
2024-03-14 23:02       ` Florian Fainelli
2024-03-14 23:02         ` Florian Fainelli
2024-03-14 23:02         ` Florian Fainelli
2024-03-14 23:03         ` Miquel Raynal
2024-03-14 23:03           ` Miquel Raynal
2024-03-14 23:03           ` Miquel Raynal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240223034758.13753-14-william.zhang@broadcom.com \
    --to=william.zhang@broadcom.com \
    --cc=anand.gore@broadcom.com \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=computersforpeace@gmail.com \
    --cc=dan.beygelman@broadcom.com \
    --cc=dregan@broadcom.com \
    --cc=dregan@mail.com \
    --cc=f.fainelli@gmail.com \
    --cc=florian.fainelli@broadcom.com \
    --cc=joel.peshkin@broadcom.com \
    --cc=kamal.dasu@broadcom.com \
    --cc=kursad.oney@broadcom.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=miquel.raynal@bootlin.com \
    --cc=richard@nod.at \
    --cc=tomer.yacoby@broadcom.com \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.