From: "Peng Fan (OSS)" <peng.fan@oss.nxp.com> To: sudeep.holla@arm.com, cristian.marussi@arm.com, linus.walleij@linaro.org Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, aisheng.dong@nxp.com, nitin.garg_3@nxp.com, ranjani.vaidyanathan@nxp.com, ye.li@nxp.com, Peng Fan <peng.fan@nxp.com> Subject: [PATCH] pinctrl: scmi: support i.MX OEM pin configuration type Date: Fri, 23 Feb 2024 15:15:57 +0800 [thread overview] Message-ID: <20240223071557.2681316-1-peng.fan@oss.nxp.com> (raw) From: Peng Fan <peng.fan@nxp.com> i.MX95 System Manager FW supports SCMI PINCTRL protocol, but uses OEM Pin Configuration type, so extend the driver to support custom params. Signed-off-by: Peng Fan <peng.fan@nxp.com> --- V1: Based on https://lore.kernel.org/all/20240223-pinctrl-scmi-v4-0-10eb5a379274@nxp.com/ This is an reimplementation for supporting i.MX95 OEM settings. With this patch, the dts will be like: +#define IMX95_PAD_SD1_CLK__USDHC1_CLK(val) \ + sd1clk { \ + pins = "sd1clk"; \ + imx,func-id = <0>; \ + imx,pin-conf = <val>; \ + } .... + + pinctrl_usdhc1: usdhc1grp { + IMX95_PAD_SD1_CLK__USDHC1_CLK(0x158e); + IMX95_PAD_SD1_CMD__USDHC1_CMD(0x138e); .... + }; drivers/pinctrl/pinctrl-scmi.c | 10 ++++++++++ drivers/pinctrl/pinctrl-scmi.h | 15 +++++++++++++++ 2 files changed, 25 insertions(+) create mode 100644 drivers/pinctrl/pinctrl-scmi.h diff --git a/drivers/pinctrl/pinctrl-scmi.c b/drivers/pinctrl/pinctrl-scmi.c index f2fef3fb85ae..e58f1aaf9963 100644 --- a/drivers/pinctrl/pinctrl-scmi.c +++ b/drivers/pinctrl/pinctrl-scmi.c @@ -19,6 +19,7 @@ #include <linux/pinctrl/pinctrl.h> #include <linux/pinctrl/pinmux.h> +#include "pinctrl-scmi.h" #include "pinctrl-utils.h" #include "core.h" #include "pinconf.h" @@ -472,6 +473,13 @@ static const struct pinconf_ops pinctrl_scmi_pinconf_ops = { .pin_config_config_dbg_show = pinconf_generic_dump_config, }; +static const struct pinconf_generic_params pinctrl_scmi_oem_dt_params[] = { + {"imx,func-id", IMX_SCMI_PIN_MUX, -1}, + {"imx,daisy-id", IMX_SCMI_PIN_DAISY_ID, -1}, + {"imx,daisy-conf", IMX_SCMI_PIN_DAISY_CFG, -1}, + {"imx,pin-conf", IMX_SCMI_PIN_CONF, -1}, +}; + static int pinctrl_scmi_get_pins(struct scmi_pinctrl *pmx, unsigned int *nr_pins, const struct pinctrl_pin_desc **pins) @@ -548,6 +556,8 @@ static int scmi_pinctrl_probe(struct scmi_device *sdev) pmx->pctl_desc.pctlops = &pinctrl_scmi_pinctrl_ops; pmx->pctl_desc.pmxops = &pinctrl_scmi_pinmux_ops; pmx->pctl_desc.confops = &pinctrl_scmi_pinconf_ops; + pmx->pctl_desc.custom_params = pinctrl_scmi_oem_dt_params; + pmx->pctl_desc.num_custom_params = ARRAY_SIZE(pinctrl_scmi_oem_dt_params); ret = pinctrl_scmi_get_pins(pmx, &pmx->pctl_desc.npins, &pmx->pctl_desc.pins); diff --git a/drivers/pinctrl/pinctrl-scmi.h b/drivers/pinctrl/pinctrl-scmi.h new file mode 100644 index 000000000000..fcc61bc19c98 --- /dev/null +++ b/drivers/pinctrl/pinctrl-scmi.h @@ -0,0 +1,15 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +/* + * Copyright 2024 NXP + */ + +#ifndef __DRIVERS_PINCTRL_SCMI_H +#define __DRIVERS_PINCTRL_SCMI_H + +/* OEM VENDOR Pin Configuration Type */ +#define IMX_SCMI_PIN_MUX 192 +#define IMX_SCMI_PIN_CONF 193 +#define IMX_SCMI_PIN_DAISY_ID 194 +#define IMX_SCMI_PIN_DAISY_CFG 195 + +#endif /* __DRIVERS_PINCTRL_SCMI_H */ -- 2.37.1
WARNING: multiple messages have this Message-ID (diff)
From: "Peng Fan (OSS)" <peng.fan@oss.nxp.com> To: sudeep.holla@arm.com, cristian.marussi@arm.com, linus.walleij@linaro.org Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, aisheng.dong@nxp.com, nitin.garg_3@nxp.com, ranjani.vaidyanathan@nxp.com, ye.li@nxp.com, Peng Fan <peng.fan@nxp.com> Subject: [PATCH] pinctrl: scmi: support i.MX OEM pin configuration type Date: Fri, 23 Feb 2024 15:15:57 +0800 [thread overview] Message-ID: <20240223071557.2681316-1-peng.fan@oss.nxp.com> (raw) From: Peng Fan <peng.fan@nxp.com> i.MX95 System Manager FW supports SCMI PINCTRL protocol, but uses OEM Pin Configuration type, so extend the driver to support custom params. Signed-off-by: Peng Fan <peng.fan@nxp.com> --- V1: Based on https://lore.kernel.org/all/20240223-pinctrl-scmi-v4-0-10eb5a379274@nxp.com/ This is an reimplementation for supporting i.MX95 OEM settings. With this patch, the dts will be like: +#define IMX95_PAD_SD1_CLK__USDHC1_CLK(val) \ + sd1clk { \ + pins = "sd1clk"; \ + imx,func-id = <0>; \ + imx,pin-conf = <val>; \ + } .... + + pinctrl_usdhc1: usdhc1grp { + IMX95_PAD_SD1_CLK__USDHC1_CLK(0x158e); + IMX95_PAD_SD1_CMD__USDHC1_CMD(0x138e); .... + }; drivers/pinctrl/pinctrl-scmi.c | 10 ++++++++++ drivers/pinctrl/pinctrl-scmi.h | 15 +++++++++++++++ 2 files changed, 25 insertions(+) create mode 100644 drivers/pinctrl/pinctrl-scmi.h diff --git a/drivers/pinctrl/pinctrl-scmi.c b/drivers/pinctrl/pinctrl-scmi.c index f2fef3fb85ae..e58f1aaf9963 100644 --- a/drivers/pinctrl/pinctrl-scmi.c +++ b/drivers/pinctrl/pinctrl-scmi.c @@ -19,6 +19,7 @@ #include <linux/pinctrl/pinctrl.h> #include <linux/pinctrl/pinmux.h> +#include "pinctrl-scmi.h" #include "pinctrl-utils.h" #include "core.h" #include "pinconf.h" @@ -472,6 +473,13 @@ static const struct pinconf_ops pinctrl_scmi_pinconf_ops = { .pin_config_config_dbg_show = pinconf_generic_dump_config, }; +static const struct pinconf_generic_params pinctrl_scmi_oem_dt_params[] = { + {"imx,func-id", IMX_SCMI_PIN_MUX, -1}, + {"imx,daisy-id", IMX_SCMI_PIN_DAISY_ID, -1}, + {"imx,daisy-conf", IMX_SCMI_PIN_DAISY_CFG, -1}, + {"imx,pin-conf", IMX_SCMI_PIN_CONF, -1}, +}; + static int pinctrl_scmi_get_pins(struct scmi_pinctrl *pmx, unsigned int *nr_pins, const struct pinctrl_pin_desc **pins) @@ -548,6 +556,8 @@ static int scmi_pinctrl_probe(struct scmi_device *sdev) pmx->pctl_desc.pctlops = &pinctrl_scmi_pinctrl_ops; pmx->pctl_desc.pmxops = &pinctrl_scmi_pinmux_ops; pmx->pctl_desc.confops = &pinctrl_scmi_pinconf_ops; + pmx->pctl_desc.custom_params = pinctrl_scmi_oem_dt_params; + pmx->pctl_desc.num_custom_params = ARRAY_SIZE(pinctrl_scmi_oem_dt_params); ret = pinctrl_scmi_get_pins(pmx, &pmx->pctl_desc.npins, &pmx->pctl_desc.pins); diff --git a/drivers/pinctrl/pinctrl-scmi.h b/drivers/pinctrl/pinctrl-scmi.h new file mode 100644 index 000000000000..fcc61bc19c98 --- /dev/null +++ b/drivers/pinctrl/pinctrl-scmi.h @@ -0,0 +1,15 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +/* + * Copyright 2024 NXP + */ + +#ifndef __DRIVERS_PINCTRL_SCMI_H +#define __DRIVERS_PINCTRL_SCMI_H + +/* OEM VENDOR Pin Configuration Type */ +#define IMX_SCMI_PIN_MUX 192 +#define IMX_SCMI_PIN_CONF 193 +#define IMX_SCMI_PIN_DAISY_ID 194 +#define IMX_SCMI_PIN_DAISY_CFG 195 + +#endif /* __DRIVERS_PINCTRL_SCMI_H */ -- 2.37.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next reply other threads:[~2024-02-23 7:07 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2024-02-23 7:15 Peng Fan (OSS) [this message] 2024-02-23 7:15 ` [PATCH] pinctrl: scmi: support i.MX OEM pin configuration type Peng Fan (OSS) 2024-02-26 13:16 ` Peng Fan 2024-02-26 13:16 ` Peng Fan 2024-02-26 15:17 ` Cristian Marussi 2024-02-26 15:17 ` Cristian Marussi 2024-02-27 0:51 ` Peng Fan 2024-02-27 0:51 ` Peng Fan 2024-02-29 13:51 ` Linus Walleij 2024-02-29 13:51 ` Linus Walleij 2024-03-14 2:01 ` Peng Fan 2024-03-14 2:01 ` Peng Fan
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20240223071557.2681316-1-peng.fan@oss.nxp.com \ --to=peng.fan@oss.nxp.com \ --cc=aisheng.dong@nxp.com \ --cc=cristian.marussi@arm.com \ --cc=linus.walleij@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-gpio@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=nitin.garg_3@nxp.com \ --cc=peng.fan@nxp.com \ --cc=ranjani.vaidyanathan@nxp.com \ --cc=sudeep.holla@arm.com \ --cc=ye.li@nxp.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.