From: Andre Przywara <andre.przywara@arm.com> To: Ulf Hansson <ulf.hansson@linaro.org>, Jernej Skrabec <jernej.skrabec@gmail.com>, Chen-Yu Tsai <wens@csie.org>, Samuel Holland <samuel@sholland.org>, Michael Turquette <mturquette@baylibre.com>, Stephen Boyd <sboyd@kernel.org> Cc: linux-clk@vger.kernel.org, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev Subject: [RFC PATCH 1/1] clk: sunxi-ng: h6-r: add GPU power domain Date: Sun, 25 Feb 2024 16:06:16 +0000 [thread overview] Message-ID: <20240225160616.15001-2-andre.przywara@arm.com> (raw) In-Reply-To: <20240225160616.15001-1-andre.przywara@arm.com> The Allwinner H616 features register 0x7010254 in the PRCM MMIO frame, where bit 0 needs to be cleared to enable operation of the Mali GPU. With this bit set (the reset default), any access to the Mali registers hangs the bus and thus the whole system. The BSP code clears this bit in U-Boot and their kernel never touches it again. Register a power-domain device to control this bit. Since we claim this MMIO region in the H6 R-CCU driver, add the code here, so that we don't need to artificially split the MMIO range in the DT. Since there seems to be at least one other register with similar behaviour nearby (0x7010260), make the power domain take one cell, even though we only support domain #0 for now. Signed-off-by: Andre Przywara <andre.przywara@arm.com> --- drivers/clk/sunxi-ng/ccu-sun50i-h6-r.c | 84 ++++++++++++++++++++++++++ 1 file changed, 84 insertions(+) diff --git a/drivers/clk/sunxi-ng/ccu-sun50i-h6-r.c b/drivers/clk/sunxi-ng/ccu-sun50i-h6-r.c index 02b28cfc5525e..363fb7a71e9f5 100644 --- a/drivers/clk/sunxi-ng/ccu-sun50i-h6-r.c +++ b/drivers/clk/sunxi-ng/ccu-sun50i-h6-r.c @@ -4,9 +4,11 @@ */ #include <linux/clk-provider.h> +#include <linux/io.h> #include <linux/module.h> #include <linux/of.h> #include <linux/platform_device.h> +#include <linux/pm_domain.h> #include "ccu_common.h" #include "ccu_reset.h" @@ -217,6 +219,86 @@ static const struct sunxi_ccu_desc sun50i_h616_r_ccu_desc = { .num_resets = ARRAY_SIZE(sun50i_h616_r_ccu_resets), }; +#define PD_H616_GPU_REG 0x254 + +struct sun50i_h616_ppu_pd { + struct generic_pm_domain genpd; + void __iomem *base; +}; + +#define to_sun50i_h616_ppu_pd(_genpd) \ + container_of(_genpd, struct sun50i_h616_ppu_pd, genpd) + +static bool sun50i_h616_ppu_power_status(const struct sun50i_h616_ppu_pd *pd) +{ + return !readl(pd->base + PD_H616_GPU_REG); +} + +static int sun50i_h616_ppu_pd_set_power(const struct sun50i_h616_ppu_pd *pd, + bool power_on) +{ + if (power_on) + writel(0, pd->base + PD_H616_GPU_REG); + else + writel(1, pd->base + PD_H616_GPU_REG); + + return 0; +} + +static int sun50i_h616_ppu_pd_power_on(struct generic_pm_domain *genpd) +{ + const struct sun50i_h616_ppu_pd *pd = to_sun50i_h616_ppu_pd(genpd); + + return sun50i_h616_ppu_pd_set_power(pd, true); +} + +static int sun50i_h616_ppu_pd_power_off(struct generic_pm_domain *genpd) +{ + const struct sun50i_h616_ppu_pd *pd = to_sun50i_h616_ppu_pd(genpd); + + return sun50i_h616_ppu_pd_set_power(pd, false); +} + +static int sun50i_h616_register_ppu(struct platform_device *pdev, + void __iomem *base) +{ + struct device *dev = &pdev->dev; + struct genpd_onecell_data *ppu; + struct sun50i_h616_ppu_pd *pd; + int ret; + + pd = devm_kzalloc(dev, sizeof(*pd), GFP_KERNEL); + if (!pd) + return -ENOMEM; + + ppu = devm_kzalloc(dev, sizeof(*ppu), GFP_KERNEL); + if (!ppu) + return -ENOMEM; + + ppu->domains = devm_kzalloc(dev, sizeof(*ppu->domains), GFP_KERNEL); + if (!ppu->domains) + return -ENOMEM; + + ppu->num_domains = 1; + pd->genpd.name = "GPU"; + pd->genpd.power_off = sun50i_h616_ppu_pd_power_off; + pd->genpd.power_on = sun50i_h616_ppu_pd_power_on; + pd->base = base; + + ret = pm_genpd_init(&pd->genpd, NULL, !sun50i_h616_ppu_power_status(pd)); + if (ret) { + dev_warn(dev, "Failed to add GPU power domain: %d\n", ret); + return ret; + } + + ppu->domains[0] = &pd->genpd; + ret = of_genpd_add_provider_onecell(dev->of_node, ppu); + if (ret) + dev_warn(dev, "Failed to add provider: %d\n", ret); + + return 0; +} + static int sun50i_h6_r_ccu_probe(struct platform_device *pdev) { const struct sunxi_ccu_desc *desc; @@ -230,6 +312,8 @@ static int sun50i_h6_r_ccu_probe(struct platform_device *pdev) if (IS_ERR(reg)) return PTR_ERR(reg); + sun50i_h616_register_ppu(pdev, reg); + return devm_sunxi_ccu_probe(&pdev->dev, reg, desc); } -- 2.35.8
WARNING: multiple messages have this Message-ID (diff)
From: Andre Przywara <andre.przywara@arm.com> To: Ulf Hansson <ulf.hansson@linaro.org>, Jernej Skrabec <jernej.skrabec@gmail.com>, Chen-Yu Tsai <wens@csie.org>, Samuel Holland <samuel@sholland.org>, Michael Turquette <mturquette@baylibre.com>, Stephen Boyd <sboyd@kernel.org> Cc: linux-clk@vger.kernel.org, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev Subject: [RFC PATCH 1/1] clk: sunxi-ng: h6-r: add GPU power domain Date: Sun, 25 Feb 2024 16:06:16 +0000 [thread overview] Message-ID: <20240225160616.15001-2-andre.przywara@arm.com> (raw) In-Reply-To: <20240225160616.15001-1-andre.przywara@arm.com> The Allwinner H616 features register 0x7010254 in the PRCM MMIO frame, where bit 0 needs to be cleared to enable operation of the Mali GPU. With this bit set (the reset default), any access to the Mali registers hangs the bus and thus the whole system. The BSP code clears this bit in U-Boot and their kernel never touches it again. Register a power-domain device to control this bit. Since we claim this MMIO region in the H6 R-CCU driver, add the code here, so that we don't need to artificially split the MMIO range in the DT. Since there seems to be at least one other register with similar behaviour nearby (0x7010260), make the power domain take one cell, even though we only support domain #0 for now. Signed-off-by: Andre Przywara <andre.przywara@arm.com> --- drivers/clk/sunxi-ng/ccu-sun50i-h6-r.c | 84 ++++++++++++++++++++++++++ 1 file changed, 84 insertions(+) diff --git a/drivers/clk/sunxi-ng/ccu-sun50i-h6-r.c b/drivers/clk/sunxi-ng/ccu-sun50i-h6-r.c index 02b28cfc5525e..363fb7a71e9f5 100644 --- a/drivers/clk/sunxi-ng/ccu-sun50i-h6-r.c +++ b/drivers/clk/sunxi-ng/ccu-sun50i-h6-r.c @@ -4,9 +4,11 @@ */ #include <linux/clk-provider.h> +#include <linux/io.h> #include <linux/module.h> #include <linux/of.h> #include <linux/platform_device.h> +#include <linux/pm_domain.h> #include "ccu_common.h" #include "ccu_reset.h" @@ -217,6 +219,86 @@ static const struct sunxi_ccu_desc sun50i_h616_r_ccu_desc = { .num_resets = ARRAY_SIZE(sun50i_h616_r_ccu_resets), }; +#define PD_H616_GPU_REG 0x254 + +struct sun50i_h616_ppu_pd { + struct generic_pm_domain genpd; + void __iomem *base; +}; + +#define to_sun50i_h616_ppu_pd(_genpd) \ + container_of(_genpd, struct sun50i_h616_ppu_pd, genpd) + +static bool sun50i_h616_ppu_power_status(const struct sun50i_h616_ppu_pd *pd) +{ + return !readl(pd->base + PD_H616_GPU_REG); +} + +static int sun50i_h616_ppu_pd_set_power(const struct sun50i_h616_ppu_pd *pd, + bool power_on) +{ + if (power_on) + writel(0, pd->base + PD_H616_GPU_REG); + else + writel(1, pd->base + PD_H616_GPU_REG); + + return 0; +} + +static int sun50i_h616_ppu_pd_power_on(struct generic_pm_domain *genpd) +{ + const struct sun50i_h616_ppu_pd *pd = to_sun50i_h616_ppu_pd(genpd); + + return sun50i_h616_ppu_pd_set_power(pd, true); +} + +static int sun50i_h616_ppu_pd_power_off(struct generic_pm_domain *genpd) +{ + const struct sun50i_h616_ppu_pd *pd = to_sun50i_h616_ppu_pd(genpd); + + return sun50i_h616_ppu_pd_set_power(pd, false); +} + +static int sun50i_h616_register_ppu(struct platform_device *pdev, + void __iomem *base) +{ + struct device *dev = &pdev->dev; + struct genpd_onecell_data *ppu; + struct sun50i_h616_ppu_pd *pd; + int ret; + + pd = devm_kzalloc(dev, sizeof(*pd), GFP_KERNEL); + if (!pd) + return -ENOMEM; + + ppu = devm_kzalloc(dev, sizeof(*ppu), GFP_KERNEL); + if (!ppu) + return -ENOMEM; + + ppu->domains = devm_kzalloc(dev, sizeof(*ppu->domains), GFP_KERNEL); + if (!ppu->domains) + return -ENOMEM; + + ppu->num_domains = 1; + pd->genpd.name = "GPU"; + pd->genpd.power_off = sun50i_h616_ppu_pd_power_off; + pd->genpd.power_on = sun50i_h616_ppu_pd_power_on; + pd->base = base; + + ret = pm_genpd_init(&pd->genpd, NULL, !sun50i_h616_ppu_power_status(pd)); + if (ret) { + dev_warn(dev, "Failed to add GPU power domain: %d\n", ret); + return ret; + } + + ppu->domains[0] = &pd->genpd; + ret = of_genpd_add_provider_onecell(dev->of_node, ppu); + if (ret) + dev_warn(dev, "Failed to add provider: %d\n", ret); + + return 0; +} + static int sun50i_h6_r_ccu_probe(struct platform_device *pdev) { const struct sunxi_ccu_desc *desc; @@ -230,6 +312,8 @@ static int sun50i_h6_r_ccu_probe(struct platform_device *pdev) if (IS_ERR(reg)) return PTR_ERR(reg); + sun50i_h616_register_ppu(pdev, reg); + return devm_sunxi_ccu_probe(&pdev->dev, reg, desc); } -- 2.35.8 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-02-25 16:07 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2024-02-25 16:06 [RFC PATCH 0/1] sunxi: H616: add GPU power domain driver Andre Przywara 2024-02-25 16:06 ` Andre Przywara 2024-02-25 16:06 ` Andre Przywara [this message] 2024-02-25 16:06 ` [RFC PATCH 1/1] clk: sunxi-ng: h6-r: add GPU power domain Andre Przywara 2024-04-08 3:33 ` Stephen Boyd 2024-04-08 3:33 ` Stephen Boyd 2024-04-08 12:55 ` Ulf Hansson 2024-04-08 12:55 ` Ulf Hansson 2024-04-15 23:00 ` Andre Przywara 2024-04-15 23:00 ` Andre Przywara 2024-04-16 11:09 ` Ulf Hansson 2024-04-16 11:09 ` Ulf Hansson
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20240225160616.15001-2-andre.przywara@arm.com \ --to=andre.przywara@arm.com \ --cc=jernej.skrabec@gmail.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-clk@vger.kernel.org \ --cc=linux-pm@vger.kernel.org \ --cc=linux-sunxi@lists.linux.dev \ --cc=mturquette@baylibre.com \ --cc=samuel@sholland.org \ --cc=sboyd@kernel.org \ --cc=ulf.hansson@linaro.org \ --cc=wens@csie.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.