From: Andy Shevchenko <andriy.shevchenko@linux.intel.com> To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Andy Shevchenko <andriy.shevchenko@linux.intel.com>, Thomas Gleixner <tglx@linutronix.de>, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-rpi-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-tegra@vger.kernel.org Cc: "Jiri Slaby" <jirislaby@kernel.org>, "Joel Stanley" <joel@jms.id.au>, "Andrew Jeffery" <andrew@codeconstruct.com.au>, "Florian Fainelli" <florian.fainelli@broadcom.com>, "Broadcom internal kernel review list" <bcm-kernel-feedback-list@broadcom.com>, "Ray Jui" <rjui@broadcom.com>, "Scott Branden" <sbranden@broadcom.com>, "Al Cooper" <alcooperx@gmail.com>, "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>, "Paul Cercueil" <paul@crapouillou.net>, "Vladimir Zapolskiy" <vz@mleia.com>, "Thierry Reding" <thierry.reding@gmail.com>, "Jonathan Hunter" <jonathanh@nvidia.com>, "Kunihiko Hayashi" <hayashi.kunihiko@socionext.com>, "Masami Hiramatsu" <mhiramat@kernel.org>, "Andi Shyti" <andi.shyti@linux.intel.com> Subject: [PATCH v2 01/14] serial: core: Move struct uart_port::quirks closer to possible values Date: Mon, 26 Feb 2024 16:19:17 +0200 [thread overview] Message-ID: <20240226142514.1485246-2-andriy.shevchenko@linux.intel.com> (raw) In-Reply-To: <20240226142514.1485246-1-andriy.shevchenko@linux.intel.com> Currently it's not crystal clear what UPIO_* and UPQ_* definitions belong to. Reindent the code, so it will be easy to read and understand. No functional changes intended. Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- include/linux/serial_core.h | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/include/linux/serial_core.h b/include/linux/serial_core.h index 55b1f3ba48ac..2d2ec99eca93 100644 --- a/include/linux/serial_core.h +++ b/include/linux/serial_core.h @@ -467,8 +467,8 @@ struct uart_port { unsigned int fifosize; /* tx fifo size */ unsigned char x_char; /* xon/xoff char */ unsigned char regshift; /* reg offset shift */ + unsigned char iotype; /* io access style */ - unsigned char quirks; /* internal quirks */ #define UPIO_PORT (SERIAL_IO_PORT) /* 8b I/O port access */ #define UPIO_HUB6 (SERIAL_IO_HUB6) /* Hub6 ISA card */ @@ -479,7 +479,9 @@ struct uart_port { #define UPIO_MEM32BE (SERIAL_IO_MEM32BE) /* 32b big endian */ #define UPIO_MEM16 (SERIAL_IO_MEM16) /* 16b little endian */ - /* quirks must be updated while holding port mutex */ + unsigned char quirks; /* internal quirks */ + + /* internal quirks must be updated while holding port mutex */ #define UPQ_NO_TXEN_TEST BIT(0) unsigned int read_status_mask; /* driver specific */ -- 2.43.0.rc1.1.gbec44491f096
WARNING: multiple messages have this Message-ID (diff)
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com> To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Andy Shevchenko <andriy.shevchenko@linux.intel.com>, Thomas Gleixner <tglx@linutronix.de>, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-rpi-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-tegra@vger.kernel.org Cc: "Jiri Slaby" <jirislaby@kernel.org>, "Joel Stanley" <joel@jms.id.au>, "Andrew Jeffery" <andrew@codeconstruct.com.au>, "Florian Fainelli" <florian.fainelli@broadcom.com>, "Broadcom internal kernel review list" <bcm-kernel-feedback-list@broadcom.com>, "Ray Jui" <rjui@broadcom.com>, "Scott Branden" <sbranden@broadcom.com>, "Al Cooper" <alcooperx@gmail.com>, "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>, "Paul Cercueil" <paul@crapouillou.net>, "Vladimir Zapolskiy" <vz@mleia.com>, "Thierry Reding" <thierry.reding@gmail.com>, "Jonathan Hunter" <jonathanh@nvidia.com>, "Kunihiko Hayashi" <hayashi.kunihiko@socionext.com>, "Masami Hiramatsu" <mhiramat@kernel.org>, "Andi Shyti" <andi.shyti@linux.intel.com> Subject: [PATCH v2 01/14] serial: core: Move struct uart_port::quirks closer to possible values Date: Mon, 26 Feb 2024 16:19:17 +0200 [thread overview] Message-ID: <20240226142514.1485246-2-andriy.shevchenko@linux.intel.com> (raw) In-Reply-To: <20240226142514.1485246-1-andriy.shevchenko@linux.intel.com> Currently it's not crystal clear what UPIO_* and UPQ_* definitions belong to. Reindent the code, so it will be easy to read and understand. No functional changes intended. Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- include/linux/serial_core.h | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/include/linux/serial_core.h b/include/linux/serial_core.h index 55b1f3ba48ac..2d2ec99eca93 100644 --- a/include/linux/serial_core.h +++ b/include/linux/serial_core.h @@ -467,8 +467,8 @@ struct uart_port { unsigned int fifosize; /* tx fifo size */ unsigned char x_char; /* xon/xoff char */ unsigned char regshift; /* reg offset shift */ + unsigned char iotype; /* io access style */ - unsigned char quirks; /* internal quirks */ #define UPIO_PORT (SERIAL_IO_PORT) /* 8b I/O port access */ #define UPIO_HUB6 (SERIAL_IO_HUB6) /* Hub6 ISA card */ @@ -479,7 +479,9 @@ struct uart_port { #define UPIO_MEM32BE (SERIAL_IO_MEM32BE) /* 32b big endian */ #define UPIO_MEM16 (SERIAL_IO_MEM16) /* 16b little endian */ - /* quirks must be updated while holding port mutex */ + unsigned char quirks; /* internal quirks */ + + /* internal quirks must be updated while holding port mutex */ #define UPQ_NO_TXEN_TEST BIT(0) unsigned int read_status_mask; /* driver specific */ -- 2.43.0.rc1.1.gbec44491f096 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-02-26 14:25 UTC|newest] Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top 2024-02-26 14:19 [PATCH v2 00/14] serial: Add a helper to parse device properties and more Andy Shevchenko 2024-02-26 14:19 ` Andy Shevchenko 2024-02-26 14:19 ` Andy Shevchenko [this message] 2024-02-26 14:19 ` [PATCH v2 01/14] serial: core: Move struct uart_port::quirks closer to possible values Andy Shevchenko 2024-02-26 14:19 ` [PATCH v2 02/14] serial: core: Add UPIO_UNKNOWN constant for unknown port type Andy Shevchenko 2024-02-26 14:19 ` Andy Shevchenko 2024-02-26 14:19 ` [PATCH v2 03/14] serial: port: Introduce a common helper to read properties Andy Shevchenko 2024-02-26 14:19 ` Andy Shevchenko 2024-03-02 20:58 ` Greg Kroah-Hartman 2024-03-02 20:58 ` Greg Kroah-Hartman 2024-03-04 11:09 ` Andy Shevchenko 2024-03-04 11:09 ` Andy Shevchenko 2024-02-26 14:19 ` [PATCH v2 04/14] serial: 8250_aspeed_vuart: Switch to use uart_read_port_properties() Andy Shevchenko 2024-02-26 14:19 ` Andy Shevchenko 2024-02-26 14:19 ` [PATCH v2 05/14] serial: 8250_bcm2835aux: " Andy Shevchenko 2024-02-26 14:19 ` Andy Shevchenko 2024-02-26 18:23 ` Florian Fainelli 2024-02-26 18:23 ` Florian Fainelli 2024-02-26 14:19 ` [PATCH v2 06/14] serial: 8250_bcm7271: " Andy Shevchenko 2024-02-26 14:19 ` Andy Shevchenko 2024-02-26 18:23 ` Florian Fainelli 2024-02-26 18:23 ` Florian Fainelli 2024-02-26 14:19 ` [PATCH v2 07/14] serial: 8250_dw: " Andy Shevchenko 2024-02-26 14:19 ` Andy Shevchenko 2024-02-26 14:19 ` [PATCH v2 08/14] serial: 8250_ingenic: " Andy Shevchenko 2024-02-26 14:19 ` Andy Shevchenko 2024-02-26 14:19 ` [PATCH v2 09/14] serial: 8250_lpc18xx: " Andy Shevchenko 2024-02-26 14:19 ` Andy Shevchenko 2024-02-26 14:19 ` [PATCH v2 10/14] serial: 8250_of: " Andy Shevchenko 2024-02-26 14:19 ` Andy Shevchenko 2024-02-26 18:24 ` Florian Fainelli 2024-02-26 18:24 ` Florian Fainelli 2024-02-27 14:55 ` Andy Shevchenko 2024-02-27 14:55 ` Andy Shevchenko 2024-02-26 14:19 ` [PATCH v2 11/14] serial: 8250_omap: " Andy Shevchenko 2024-02-26 14:19 ` Andy Shevchenko 2024-02-26 14:19 ` [PATCH v2 12/14] serial: 8250_pxa: " Andy Shevchenko 2024-02-26 14:19 ` Andy Shevchenko 2024-02-26 14:19 ` [PATCH v2 13/14] serial: 8250_tegra: " Andy Shevchenko 2024-02-26 14:19 ` Andy Shevchenko 2024-02-26 14:19 ` [PATCH v2 14/14] serial: 8250_uniphier: " Andy Shevchenko 2024-02-26 14:19 ` Andy Shevchenko 2024-02-27 9:43 ` Kunihiko Hayashi 2024-02-27 9:43 ` Kunihiko Hayashi 2024-02-27 14:55 ` Andy Shevchenko 2024-02-27 14:55 ` Andy Shevchenko
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20240226142514.1485246-2-andriy.shevchenko@linux.intel.com \ --to=andriy.shevchenko@linux.intel.com \ --cc=alcooperx@gmail.com \ --cc=andi.shyti@linux.intel.com \ --cc=andrew@codeconstruct.com.au \ --cc=bcm-kernel-feedback-list@broadcom.com \ --cc=florian.fainelli@broadcom.com \ --cc=gregkh@linuxfoundation.org \ --cc=hayashi.kunihiko@socionext.com \ --cc=ilpo.jarvinen@linux.intel.com \ --cc=jirislaby@kernel.org \ --cc=joel@jms.id.au \ --cc=jonathanh@nvidia.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-aspeed@lists.ozlabs.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mips@vger.kernel.org \ --cc=linux-rpi-kernel@lists.infradead.org \ --cc=linux-serial@vger.kernel.org \ --cc=linux-tegra@vger.kernel.org \ --cc=mhiramat@kernel.org \ --cc=paul@crapouillou.net \ --cc=rjui@broadcom.com \ --cc=sbranden@broadcom.com \ --cc=tglx@linutronix.de \ --cc=thierry.reding@gmail.com \ --cc=vz@mleia.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.