All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sibi Sankar <quic_sibis@quicinc.com>
To: <sudeep.holla@arm.com>, <cristian.marussi@arm.com>,
	<rafael@kernel.org>, <viresh.kumar@linaro.org>,
	<morten.rasmussen@arm.com>, <dietmar.eggemann@arm.com>,
	<lukasz.luba@arm.com>, <pierre.gondois@arm.com>
Cc: <linux-arm-kernel@lists.infradead.org>,
	<linux-pm@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<quic_mdtipton@quicinc.com>, <linux-arm-msm@vger.kernel.org>,
	Sibi Sankar <quic_sibis@quicinc.com>
Subject: [PATCH V3 2/2] cpufreq: scmi: Register for limit change notifications
Date: Tue, 27 Feb 2024 23:46:32 +0530	[thread overview]
Message-ID: <20240227181632.659133-3-quic_sibis@quicinc.com> (raw)
In-Reply-To: <20240227181632.659133-1-quic_sibis@quicinc.com>

Register for limit change notifications if supported and use the throttled
frequency from the notification to apply HW pressure.

Signed-off-by: Sibi Sankar <quic_sibis@quicinc.com>
---

v3:
* Sanitize range_max received from the notifier. [Pierre]
* Update commit message.

 drivers/cpufreq/scmi-cpufreq.c | 29 ++++++++++++++++++++++++++++-
 1 file changed, 28 insertions(+), 1 deletion(-)

diff --git a/drivers/cpufreq/scmi-cpufreq.c b/drivers/cpufreq/scmi-cpufreq.c
index 76a0ddbd9d24..78b87b72962d 100644
--- a/drivers/cpufreq/scmi-cpufreq.c
+++ b/drivers/cpufreq/scmi-cpufreq.c
@@ -25,9 +25,13 @@ struct scmi_data {
 	int domain_id;
 	int nr_opp;
 	struct device *cpu_dev;
+	struct cpufreq_policy *policy;
 	cpumask_var_t opp_shared_cpus;
+	struct notifier_block limit_notify_nb;
 };
 
+const struct scmi_handle *handle;
+static struct scmi_device *scmi_dev;
 static struct scmi_protocol_handle *ph;
 static const struct scmi_perf_proto_ops *perf_ops;
 static struct cpufreq_driver scmi_cpufreq_driver;
@@ -151,6 +155,20 @@ static struct freq_attr *scmi_cpufreq_hw_attr[] = {
 	NULL,
 };
 
+static int scmi_limit_notify_cb(struct notifier_block *nb, unsigned long event, void *data)
+{
+	struct scmi_data *priv = container_of(nb, struct scmi_data, limit_notify_nb);
+	struct scmi_perf_limits_report *limit_notify = data;
+	struct cpufreq_policy *policy = priv->policy;
+
+	policy->max = clamp(limit_notify->range_max_freq/HZ_PER_KHZ, policy->cpuinfo.min_freq,
+			    policy->cpuinfo.max_freq);
+
+	cpufreq_update_pressure(policy);
+
+	return NOTIFY_OK;
+}
+
 static int scmi_cpufreq_init(struct cpufreq_policy *policy)
 {
 	int ret, nr_opp, domain;
@@ -269,6 +287,15 @@ static int scmi_cpufreq_init(struct cpufreq_policy *policy)
 		}
 	}
 
+	priv->limit_notify_nb.notifier_call = scmi_limit_notify_cb;
+	ret = handle->notify_ops->devm_event_notifier_register(scmi_dev, SCMI_PROTOCOL_PERF,
+							SCMI_EVENT_PERFORMANCE_LIMITS_CHANGED,
+							&domain,
+							&priv->limit_notify_nb);
+	if (ret)
+		dev_warn(cpu_dev,
+			 "failed to register for limits change notifier for domain %d\n", domain);
+
 	priv->policy = policy;
 
 	return 0;
@@ -342,8 +369,8 @@ static int scmi_cpufreq_probe(struct scmi_device *sdev)
 {
 	int ret;
 	struct device *dev = &sdev->dev;
-	const struct scmi_handle *handle;
 
+	scmi_dev = sdev;
 	handle = sdev->handle;
 
 	if (!handle)
-- 
2.34.1


WARNING: multiple messages have this Message-ID (diff)
From: Sibi Sankar <quic_sibis@quicinc.com>
To: <sudeep.holla@arm.com>, <cristian.marussi@arm.com>,
	<rafael@kernel.org>, <viresh.kumar@linaro.org>,
	<morten.rasmussen@arm.com>, <dietmar.eggemann@arm.com>,
	<lukasz.luba@arm.com>, <pierre.gondois@arm.com>
Cc: <linux-arm-kernel@lists.infradead.org>,
	<linux-pm@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<quic_mdtipton@quicinc.com>, <linux-arm-msm@vger.kernel.org>,
	Sibi Sankar <quic_sibis@quicinc.com>
Subject: [PATCH V3 2/2] cpufreq: scmi: Register for limit change notifications
Date: Tue, 27 Feb 2024 23:46:32 +0530	[thread overview]
Message-ID: <20240227181632.659133-3-quic_sibis@quicinc.com> (raw)
In-Reply-To: <20240227181632.659133-1-quic_sibis@quicinc.com>

Register for limit change notifications if supported and use the throttled
frequency from the notification to apply HW pressure.

Signed-off-by: Sibi Sankar <quic_sibis@quicinc.com>
---

v3:
* Sanitize range_max received from the notifier. [Pierre]
* Update commit message.

 drivers/cpufreq/scmi-cpufreq.c | 29 ++++++++++++++++++++++++++++-
 1 file changed, 28 insertions(+), 1 deletion(-)

diff --git a/drivers/cpufreq/scmi-cpufreq.c b/drivers/cpufreq/scmi-cpufreq.c
index 76a0ddbd9d24..78b87b72962d 100644
--- a/drivers/cpufreq/scmi-cpufreq.c
+++ b/drivers/cpufreq/scmi-cpufreq.c
@@ -25,9 +25,13 @@ struct scmi_data {
 	int domain_id;
 	int nr_opp;
 	struct device *cpu_dev;
+	struct cpufreq_policy *policy;
 	cpumask_var_t opp_shared_cpus;
+	struct notifier_block limit_notify_nb;
 };
 
+const struct scmi_handle *handle;
+static struct scmi_device *scmi_dev;
 static struct scmi_protocol_handle *ph;
 static const struct scmi_perf_proto_ops *perf_ops;
 static struct cpufreq_driver scmi_cpufreq_driver;
@@ -151,6 +155,20 @@ static struct freq_attr *scmi_cpufreq_hw_attr[] = {
 	NULL,
 };
 
+static int scmi_limit_notify_cb(struct notifier_block *nb, unsigned long event, void *data)
+{
+	struct scmi_data *priv = container_of(nb, struct scmi_data, limit_notify_nb);
+	struct scmi_perf_limits_report *limit_notify = data;
+	struct cpufreq_policy *policy = priv->policy;
+
+	policy->max = clamp(limit_notify->range_max_freq/HZ_PER_KHZ, policy->cpuinfo.min_freq,
+			    policy->cpuinfo.max_freq);
+
+	cpufreq_update_pressure(policy);
+
+	return NOTIFY_OK;
+}
+
 static int scmi_cpufreq_init(struct cpufreq_policy *policy)
 {
 	int ret, nr_opp, domain;
@@ -269,6 +287,15 @@ static int scmi_cpufreq_init(struct cpufreq_policy *policy)
 		}
 	}
 
+	priv->limit_notify_nb.notifier_call = scmi_limit_notify_cb;
+	ret = handle->notify_ops->devm_event_notifier_register(scmi_dev, SCMI_PROTOCOL_PERF,
+							SCMI_EVENT_PERFORMANCE_LIMITS_CHANGED,
+							&domain,
+							&priv->limit_notify_nb);
+	if (ret)
+		dev_warn(cpu_dev,
+			 "failed to register for limits change notifier for domain %d\n", domain);
+
 	priv->policy = policy;
 
 	return 0;
@@ -342,8 +369,8 @@ static int scmi_cpufreq_probe(struct scmi_device *sdev)
 {
 	int ret;
 	struct device *dev = &sdev->dev;
-	const struct scmi_handle *handle;
 
+	scmi_dev = sdev;
 	handle = sdev->handle;
 
 	if (!handle)
-- 
2.34.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2024-02-27 18:17 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-27 18:16 [PATCH V3 0/2] firmware: arm_scmi: Register and handle limits change notification Sibi Sankar
2024-02-27 18:16 ` Sibi Sankar
2024-02-27 18:16 ` [PATCH V3 1/2] cpufreq: Export cpufreq_update_pressure Sibi Sankar
2024-02-27 18:16   ` Sibi Sankar
2024-02-27 19:32   ` Trilok Soni
2024-02-27 19:32     ` Trilok Soni
2024-02-28  5:16     ` Sibi Sankar
2024-02-28  5:16       ` Sibi Sankar
2024-02-27 18:16 ` Sibi Sankar [this message]
2024-02-27 18:16   ` [PATCH V3 2/2] cpufreq: scmi: Register for limit change notifications Sibi Sankar
2024-02-28 13:24   ` Lukasz Luba
2024-02-28 13:24     ` Lukasz Luba
2024-02-28 17:00     ` Sibi Sankar
2024-02-28 17:00       ` Sibi Sankar
2024-02-29  9:59       ` Lukasz Luba
2024-02-29  9:59         ` Lukasz Luba
2024-02-29 10:22         ` Lukasz Luba
2024-02-29 10:22           ` Lukasz Luba
2024-02-29 11:28           ` Cristian Marussi
2024-02-29 11:28             ` Cristian Marussi
2024-02-29 11:45             ` Lukasz Luba
2024-02-29 11:45               ` Lukasz Luba
2024-02-29 12:11               ` Cristian Marussi
2024-02-29 12:11                 ` Cristian Marussi
2024-02-29 14:15                 ` Lukasz Luba
2024-02-29 14:15                   ` Lukasz Luba
2024-03-01  5:31                   ` Sibi Sankar
2024-03-01  5:31                     ` Sibi Sankar
2024-03-22 10:45                     ` Lukasz Luba
2024-03-22 10:45                       ` Lukasz Luba
2024-03-26  5:25                       ` Sibi Sankar
2024-03-26  5:25                         ` Sibi Sankar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240227181632.659133-3-quic_sibis@quicinc.com \
    --to=quic_sibis@quicinc.com \
    --cc=cristian.marussi@arm.com \
    --cc=dietmar.eggemann@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=lukasz.luba@arm.com \
    --cc=morten.rasmussen@arm.com \
    --cc=pierre.gondois@arm.com \
    --cc=quic_mdtipton@quicinc.com \
    --cc=rafael@kernel.org \
    --cc=sudeep.holla@arm.com \
    --cc=viresh.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.