All of lore.kernel.org
 help / color / mirror / Atom feed
From: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
To: intel-xe@lists.freedesktop.org, intel-gfx@lists.freedesktop.org
Cc: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>,
	"Souza, Jose" <jose.souza@intel.com>,
	Jani Nikula <jani.nikula@linux.intel.com>
Subject: [PATCH] drm/i915/display: Disable AuxCCS framebuffers if built for Xe
Date: Wed, 28 Feb 2024 16:02:25 +0200	[thread overview]
Message-ID: <20240228140225.858145-1-juhapekka.heikkila@gmail.com> (raw)

AuxCCS framebuffers don't work on Xe driver hence disable them
from plane capabilities until they are fixed. FlatCCS framebuffers
work and they are left enabled. CCS is left untouched for i915
driver.

Closes: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/933
Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
---
 drivers/gpu/drm/i915/display/skl_universal_plane.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/gpu/drm/i915/display/skl_universal_plane.c b/drivers/gpu/drm/i915/display/skl_universal_plane.c
index e941e2e4fd14..860574d04f88 100644
--- a/drivers/gpu/drm/i915/display/skl_universal_plane.c
+++ b/drivers/gpu/drm/i915/display/skl_universal_plane.c
@@ -2295,6 +2295,9 @@ static u8 skl_get_plane_caps(struct drm_i915_private *i915,
 	if (HAS_4TILE(i915))
 		caps |= INTEL_PLANE_CAP_TILING_4;
 
+	if (!IS_ENABLED(I915) && !HAS_FLAT_CCS(i915))
+		return caps;
+
 	if (skl_plane_has_rc_ccs(i915, pipe, plane_id)) {
 		caps |= INTEL_PLANE_CAP_CCS_RC;
 		if (DISPLAY_VER(i915) >= 12)
-- 
2.25.1


             reply	other threads:[~2024-02-28 14:02 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-28 14:02 Juha-Pekka Heikkila [this message]
2024-02-28 14:04 ` [PATCH] drm/i915/display: Disable AuxCCS framebuffers if built for Xe Souza, Jose
2024-02-29 16:44   ` Souza, Jose
2024-02-29 17:36     ` Souza, Jose
2024-02-28 14:07 ` ✓ CI.Patch_applied: success for drm/i915/display: Disable AuxCCS framebuffers if built for Xe (rev2) Patchwork
2024-02-28 14:07 ` ✗ CI.checkpatch: warning " Patchwork
2024-02-28 14:08 ` ✓ CI.KUnit: success " Patchwork
2024-02-28 14:26 ` ✓ CI.Build: " Patchwork
2024-02-28 14:27 ` ✓ CI.Hooks: " Patchwork
2024-02-28 14:28 ` ✗ CI.checksparse: warning " Patchwork
2024-02-28 15:03 ` ✓ CI.BAT: success " Patchwork
2024-02-28 19:14 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915/display: Disable AuxCCS framebuffers if built for Xe (rev3) Patchwork
2024-02-28 19:33 ` ✓ Fi.CI.BAT: success " Patchwork
2024-02-29 13:36 ` ✓ Fi.CI.IGT: " Patchwork
2024-03-05 16:44 ` [PATCH] drm/i915/display: Disable AuxCCS framebuffers if built for Xe Jani Nikula
2024-03-06 13:57 ` Souza, Jose
  -- strict thread matches above, loose matches on Subject: below --
2024-02-26 20:36 Juha-Pekka Heikkila
2024-02-27  8:57 ` Jani Nikula
2024-01-25 15:25 Juha-Pekka Heikkila
2024-01-25 15:28 ` Souza, Jose
2024-01-25 15:56   ` Juha-Pekka Heikkila
2024-01-25 16:07     ` Souza, Jose
2024-02-02 20:51       ` Souza, Jose
2024-02-05 10:00         ` Juha-Pekka Heikkila

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240228140225.858145-1-juhapekka.heikkila@gmail.com \
    --to=juhapekka.heikkila@gmail.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=jani.nikula@linux.intel.com \
    --cc=jose.souza@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.