All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Tokarev <mjt@tls.msk.ru>
To: qemu-devel@nongnu.org
Cc: qemu-stable@nongnu.org,
	"Marc-André Lureau" <marcandre.lureau@redhat.com>,
	"Daniel P . Berrangé" <berrange@redhat.com>,
	"Michael Tokarev" <mjt@tls.msk.ru>
Subject: [Stable-7.2.10 33/47] meson: ensure dbus-display generated code is built before other units
Date: Wed, 28 Feb 2024 23:35:02 +0300	[thread overview]
Message-ID: <20240228203521.267565-1-mjt@tls.msk.ru> (raw)
In-Reply-To: <qemu-stable-7.2.10-20240228233111@cover.tls.msk.ru>

From: Marc-André Lureau <marcandre.lureau@redhat.com>

It's simply by luck that dbus-display header is built first before the
other units using it.

With sourceset, I can't find an easier way out than declaring an extra
dependency for dbus-display1 generate code.

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
(cherry picked from commit 1222070e772833c6875e0ca63565db12c22df39e)
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>

diff --git a/ui/meson.build b/ui/meson.build
index c1b137bf33..76c6644b3f 100644
--- a/ui/meson.build
+++ b/ui/meson.build
@@ -81,7 +81,9 @@ if dbus_display
                                           '--interface-prefix', 'org.qemu.',
                                           '--c-namespace', 'QemuDBus',
                                           '--generate-c-code', '@BASENAME@'])
-  dbus_ss.add(when: [gio, pixman, opengl, gbm],
+  dbus_display1_lib = static_library('dbus-display1', dbus_display1, dependencies: gio)
+  dbus_display1_dep = declare_dependency(link_with: dbus_display1_lib, include_directories: include_directories('.'))
+  dbus_ss.add(when: [gio, pixman, opengl, gbm, dbus_display1_dep],
               if_true: [files(
                 'dbus-chardev.c',
                 'dbus-clipboard.c',
@@ -89,7 +91,7 @@ if dbus_display
                 'dbus-error.c',
                 'dbus-listener.c',
                 'dbus.c',
-              ), dbus_display1])
+              )])
   ui_modules += {'dbus' : dbus_ss}
 endif
 
-- 
2.39.2



  reply	other threads:[~2024-02-28 20:37 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-28 20:35 [Stable-7.2.10 v1 00/47] Patch Round-up for stable 7.2.10, freeze on 2024-03-02 Michael Tokarev
2024-02-28 20:35 ` Michael Tokarev [this message]
2024-02-28 20:35 ` [Stable-7.2.10 35/47] docs/system: Update description for input grab key Michael Tokarev
2024-02-28 20:35 ` [Stable-7.2.10 36/47] system/vl: " Michael Tokarev
2024-02-28 20:35 ` [Stable-7.2.10 37/47] .gitlab-ci.d/windows.yml: Drop msys2-32bit job Michael Tokarev
2024-02-28 20:35 ` [Stable-7.2.10 38/47] target/ppc: Fix lxv/stxv MSR facility check Michael Tokarev
2024-02-28 20:35 ` [Stable-7.2.10 39/47] hw/nvme: fix invalid endian conversion Michael Tokarev
2024-02-28 20:35 ` [Stable-7.2.10 40/47] pl031: Update last RTCLR value on write in case it's read back Michael Tokarev
2024-02-28 20:35 ` [Stable-7.2.10 41/47] target/i386: mask high bits of CR3 in 32-bit mode Michael Tokarev
2024-02-28 20:35 ` [Stable-7.2.10 42/47] target/i386: check validity of VMCB addresses Michael Tokarev
2024-02-28 20:35 ` [Stable-7.2.10 43/47] target/i386: Fix physical address truncation Michael Tokarev
2024-02-28 20:35 ` [Stable-7.2.10 44/47] target/i386: remove unnecessary/wrong application of the A20 mask Michael Tokarev
2024-02-28 20:35 ` [Stable-7.2.10 45/47] target/i386: leave the A20 bit set in the final NPT walk Michael Tokarev
2024-02-28 20:35 ` [Stable-7.2.10 46/47] tests/vm: update openbsd image to 7.4 Michael Tokarev
2024-02-28 20:35 ` [Stable-7.2.10 47/47] tests/vm: avoid re-building the VM images all the time Michael Tokarev
2024-03-01 19:04 ` [Stable-7.2.10 v1 00/47] Patch Round-up for stable 7.2.10, freeze on 2024-03-02 Cole Robinson
2024-03-01 19:19   ` Michael Tokarev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240228203521.267565-1-mjt@tls.msk.ru \
    --to=mjt@tls.msk.ru \
    --cc=berrange@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-stable@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.