All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Tokarev <mjt@tls.msk.ru>
To: qemu-devel@nongnu.org
Cc: qemu-stable@nongnu.org, "Klaus Jensen" <k.jensen@samsung.com>,
	"Kevin Wolf" <kwolf@redhat.com>,
	"Minwoo Im" <minwoo.im@samsung.com>,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>,
	"Michael Tokarev" <mjt@tls.msk.ru>
Subject: [Stable-7.2.10 39/47] hw/nvme: fix invalid endian conversion
Date: Wed, 28 Feb 2024 23:35:07 +0300	[thread overview]
Message-ID: <20240228203521.267565-6-mjt@tls.msk.ru> (raw)
In-Reply-To: <qemu-stable-7.2.10-20240228233111@cover.tls.msk.ru>

From: Klaus Jensen <k.jensen@samsung.com>

numcntl is one byte and so is max_vfs. Using cpu_to_le16 on big endian
hosts results in numcntl being set to 0.

Fix by dropping the endian conversion.

Fixes: 99f48ae7ae ("hw/nvme: Add support for Secondary Controller List")
Reported-by: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Klaus Jensen <k.jensen@samsung.com>
Reviewed-by: Minwoo Im <minwoo.im@samsung.com>
Message-ID: <20240222-fix-sriov-numcntl-v1-1-d60bea5e72d0@samsung.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
(cherry picked from commit d2b5bb860e6c17442ad95cc275feb07c1665be5c)
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>

diff --git a/hw/nvme/ctrl.c b/hw/nvme/ctrl.c
index 4d29033556..a87f79296c 100644
--- a/hw/nvme/ctrl.c
+++ b/hw/nvme/ctrl.c
@@ -7140,7 +7140,7 @@ static void nvme_init_state(NvmeCtrl *n)
     n->aer_reqs = g_new0(NvmeRequest *, n->params.aerl + 1);
     QTAILQ_INIT(&n->aer_queue);
 
-    list->numcntl = cpu_to_le16(max_vfs);
+    list->numcntl = max_vfs;
     for (i = 0; i < max_vfs; i++) {
         sctrl = &list->sec[i];
         sctrl->pcid = cpu_to_le16(n->cntlid);
-- 
2.39.2



  parent reply	other threads:[~2024-02-28 20:37 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-28 20:35 [Stable-7.2.10 v1 00/47] Patch Round-up for stable 7.2.10, freeze on 2024-03-02 Michael Tokarev
2024-02-28 20:35 ` [Stable-7.2.10 33/47] meson: ensure dbus-display generated code is built before other units Michael Tokarev
2024-02-28 20:35 ` [Stable-7.2.10 35/47] docs/system: Update description for input grab key Michael Tokarev
2024-02-28 20:35 ` [Stable-7.2.10 36/47] system/vl: " Michael Tokarev
2024-02-28 20:35 ` [Stable-7.2.10 37/47] .gitlab-ci.d/windows.yml: Drop msys2-32bit job Michael Tokarev
2024-02-28 20:35 ` [Stable-7.2.10 38/47] target/ppc: Fix lxv/stxv MSR facility check Michael Tokarev
2024-02-28 20:35 ` Michael Tokarev [this message]
2024-02-28 20:35 ` [Stable-7.2.10 40/47] pl031: Update last RTCLR value on write in case it's read back Michael Tokarev
2024-02-28 20:35 ` [Stable-7.2.10 41/47] target/i386: mask high bits of CR3 in 32-bit mode Michael Tokarev
2024-02-28 20:35 ` [Stable-7.2.10 42/47] target/i386: check validity of VMCB addresses Michael Tokarev
2024-02-28 20:35 ` [Stable-7.2.10 43/47] target/i386: Fix physical address truncation Michael Tokarev
2024-02-28 20:35 ` [Stable-7.2.10 44/47] target/i386: remove unnecessary/wrong application of the A20 mask Michael Tokarev
2024-02-28 20:35 ` [Stable-7.2.10 45/47] target/i386: leave the A20 bit set in the final NPT walk Michael Tokarev
2024-02-28 20:35 ` [Stable-7.2.10 46/47] tests/vm: update openbsd image to 7.4 Michael Tokarev
2024-02-28 20:35 ` [Stable-7.2.10 47/47] tests/vm: avoid re-building the VM images all the time Michael Tokarev
2024-03-01 19:04 ` [Stable-7.2.10 v1 00/47] Patch Round-up for stable 7.2.10, freeze on 2024-03-02 Cole Robinson
2024-03-01 19:19   ` Michael Tokarev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240228203521.267565-6-mjt@tls.msk.ru \
    --to=mjt@tls.msk.ru \
    --cc=k.jensen@samsung.com \
    --cc=kwolf@redhat.com \
    --cc=minwoo.im@samsung.com \
    --cc=philmd@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-stable@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.