All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Tokarev <mjt@tls.msk.ru>
To: qemu-devel@nongnu.org
Cc: qemu-stable@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>,
	Richard Henderson <richard.henderson@linaro.org>,
	Michael Tokarev <mjt@tls.msk.ru>
Subject: [Stable-8.2.2 71/78] target/i386: mask high bits of CR3 in 32-bit mode
Date: Thu, 29 Feb 2024 01:54:47 +0300	[thread overview]
Message-ID: <20240228225455.274062-11-mjt@tls.msk.ru> (raw)
In-Reply-To: <qemu-stable-8.2.2-20240229000326@cover.tls.msk.ru>

From: Paolo Bonzini <pbonzini@redhat.com>

CR3 bits 63:32 are ignored in 32-bit mode (either legacy 2-level
paging or PAE paging).  Do this in mmu_translate() to remove
the last where get_physical_address() meaningfully drops the high
bits of the address.

Cc: qemu-stable@nongnu.org
Suggested-by: Richard Henderson <richard.henderson@linaro.org>
Fixes: 4a1e9d4d11c ("target/i386: Use atomic operations for pte updates", 2022-10-18)
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
(cherry picked from commit 68fb78d7d5723066ec2cacee7d25d67a4143b42f)
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>

diff --git a/target/i386/tcg/sysemu/excp_helper.c b/target/i386/tcg/sysemu/excp_helper.c
index 5b86f439ad..11126c860d 100644
--- a/target/i386/tcg/sysemu/excp_helper.c
+++ b/target/i386/tcg/sysemu/excp_helper.c
@@ -238,7 +238,7 @@ static bool mmu_translate(CPUX86State *env, const TranslateParams *in,
             /*
              * Page table level 3
              */
-            pte_addr = ((in->cr3 & ~0x1f) + ((addr >> 27) & 0x18)) & a20_mask;
+            pte_addr = ((in->cr3 & 0xffffffe0ULL) + ((addr >> 27) & 0x18)) & a20_mask;
             if (!ptw_translate(&pte_trans, pte_addr)) {
                 return false;
             }
@@ -306,7 +306,7 @@ static bool mmu_translate(CPUX86State *env, const TranslateParams *in,
         /*
          * Page table level 2
          */
-        pte_addr = ((in->cr3 & ~0xfff) + ((addr >> 20) & 0xffc)) & a20_mask;
+        pte_addr = ((in->cr3 & 0xfffff000ULL) + ((addr >> 20) & 0xffc)) & a20_mask;
         if (!ptw_translate(&pte_trans, pte_addr)) {
             return false;
         }
-- 
2.39.2



  parent reply	other threads:[~2024-02-28 22:58 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-28 22:54 [Stable-8.2.2 v2 00/78] Patch Round-up for stable 8.2.2, freeze on 2024-03-02 Michael Tokarev
2024-02-28 22:54 ` [Stable-8.2.2 61/78] hw/hppa/Kconfig: Fix building with "configure --without-default-devices" Michael Tokarev
2024-02-28 22:54 ` [Stable-8.2.2 62/78] docs/system: Update description for input grab key Michael Tokarev
2024-02-28 22:54 ` [Stable-8.2.2 63/78] system/vl: " Michael Tokarev
2024-02-28 22:54 ` [Stable-8.2.2 64/78] .gitlab-ci.d/windows.yml: Drop msys2-32bit job Michael Tokarev
2024-02-28 22:54 ` [Stable-8.2.2 65/78] target/ppc: Fix lxv/stxv MSR facility check Michael Tokarev
2024-02-28 22:54 ` [Stable-8.2.2 66/78] target/ppc: Fix crash on machine check caused by ifetch Michael Tokarev
2024-02-28 22:54 ` [Stable-8.2.2 67/78] update edk2 submodule to edk2-stable202402 Michael Tokarev
2024-02-28 22:54 ` [Stable-8.2.2 68/78] update edk2 binaries " Michael Tokarev
2024-02-28 22:54 ` [Stable-8.2.2 69/78] hw/nvme: fix invalid endian conversion Michael Tokarev
2024-02-28 22:54 ` [Stable-8.2.2 70/78] pl031: Update last RTCLR value on write in case it's read back Michael Tokarev
2024-02-28 22:54 ` Michael Tokarev [this message]
2024-02-28 22:54 ` [Stable-8.2.2 72/78] target/i386: check validity of VMCB addresses Michael Tokarev
2024-02-28 22:54 ` [Stable-8.2.2 73/78] target/i386: Fix physical address truncation Michael Tokarev
2024-02-28 22:54 ` [Stable-8.2.2 74/78] target/i386: remove unnecessary/wrong application of the A20 mask Michael Tokarev
2024-02-28 22:54 ` [Stable-8.2.2 75/78] target/i386: leave the A20 bit set in the final NPT walk Michael Tokarev
2024-02-28 22:54 ` [Stable-8.2.2 76/78] tests/vm: update openbsd image to 7.4 Michael Tokarev
2024-02-28 22:54 ` [Stable-8.2.2 77/78] tests/vm: avoid re-building the VM images all the time Michael Tokarev
2024-02-28 22:54 ` [Stable-8.2.2 78/78] gitlab: force allow use of pip in Cirrus jobs Michael Tokarev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240228225455.274062-11-mjt@tls.msk.ru \
    --to=mjt@tls.msk.ru \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-stable@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.