All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jinjie Ruan via <qemu-devel@nongnu.org>
To: <peter.maydell@linaro.org>, <eduardo@habkost.net>,
	<marcel.apfelbaum@gmail.com>, <philmd@linaro.org>,
	<wangyanan55@huawei.com>, <qemu-devel@nongnu.org>,
	<qemu-arm@nongnu.org>
Cc: <ruanjinjie@huawei.com>
Subject: [RFC PATCH v5 22/22] hw/arm/virt: Add FEAT_GICv3_NMI feature support in virt GIC
Date: Thu, 29 Feb 2024 13:10:39 +0000	[thread overview]
Message-ID: <20240229131039.1868904-23-ruanjinjie@huawei.com> (raw)
In-Reply-To: <20240229131039.1868904-1-ruanjinjie@huawei.com>

A PE that implements FEAT_NMI and FEAT_GICv3 also implements
FEAT_GICv3_NMI. A PE that does not implement FEAT_NMI, does not implement
FEAT_GICv3_NMI

So included support FEAT_GICv3_NMI feature as part of virt platform
GIC initialization if FEAT_NMI and FEAT_GICv3 supported.

Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
---
v4:
- Add Reviewed-by.
v3:
- Adjust to be the last after add FEAT_NMI to max.
- Check whether support FEAT_NMI and FEAT_GICv3 for FEAT_GICv3_NMI.
---
 hw/arm/virt.c | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

diff --git a/hw/arm/virt.c b/hw/arm/virt.c
index 2d4a187fd5..c12307ccd9 100644
--- a/hw/arm/virt.c
+++ b/hw/arm/virt.c
@@ -712,6 +712,19 @@ static void create_v2m(VirtMachineState *vms)
     vms->msi_controller = VIRT_MSI_CTRL_GICV2M;
 }
 
+/*
+ * A PE that implements FEAT_NMI and FEAT_GICv3 also implements
+ * FEAT_GICv3_NMI. A PE that does not implement FEAT_NMI, does not implement
+ * FEAT_GICv3_NMI.
+ */
+static bool gicv3_nmi_present(VirtMachineState *vms)
+{
+    ARMCPU *cpu = ARM_CPU(qemu_get_cpu(0));
+
+    return cpu_isar_feature(aa64_nmi, cpu) &&
+           (vms->gic_version != VIRT_GIC_VERSION_2);
+}
+
 static void create_gic(VirtMachineState *vms, MemoryRegion *mem)
 {
     MachineState *ms = MACHINE(vms);
@@ -785,6 +798,11 @@ static void create_gic(VirtMachineState *vms, MemoryRegion *mem)
                               vms->virt);
         }
     }
+
+    if (gicv3_nmi_present(vms)) {
+        qdev_prop_set_bit(vms->gic, "has-nmi", true);
+    }
+
     gicbusdev = SYS_BUS_DEVICE(vms->gic);
     sysbus_realize_and_unref(gicbusdev, &error_fatal);
     sysbus_mmio_map(gicbusdev, 0, vms->memmap[VIRT_GIC_DIST].base);
-- 
2.34.1



      parent reply	other threads:[~2024-02-29 13:13 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-29 13:10 [RFC PATCH v5 00/22] target/arm: Implement FEAT_NMI and FEAT_GICv3_NMI Jinjie Ruan via
2024-02-29 13:10 ` [RFC PATCH v5 01/22] target/arm: Handle HCR_EL2 accesses for bits introduced with FEAT_NMI Jinjie Ruan via
2024-02-29 13:10 ` [RFC PATCH v5 02/22] target/arm: Add PSTATE.ALLINT Jinjie Ruan via
2024-02-29 13:10 ` [RFC PATCH v5 03/22] target/arm: Add support for FEAT_NMI, Non-maskable Interrupt Jinjie Ruan via
2024-02-29 13:10 ` [RFC PATCH v5 04/22] target/arm: Implement ALLINT MSR (immediate) Jinjie Ruan via
2024-02-29 21:48   ` Richard Henderson
2024-02-29 13:10 ` [RFC PATCH v5 05/22] target/arm: Support MSR access to ALLINT Jinjie Ruan via
2024-02-29 13:10 ` [RFC PATCH v5 06/22] target/arm: Add support for Non-maskable Interrupt Jinjie Ruan via
2024-02-29 22:42   ` Richard Henderson
2024-02-29 23:02   ` Richard Henderson
2024-03-19 17:03     ` Peter Maydell
2024-03-19 18:40       ` Richard Henderson
2024-02-29 13:10 ` [RFC PATCH v5 07/22] target/arm: Add support for NMI in arm_phys_excp_target_el() Jinjie Ruan via
2024-02-29 13:10 ` [RFC PATCH v5 08/22] target/arm: Handle IS/FS in ISR_EL1 for NMI Jinjie Ruan via
2024-02-29 23:05   ` Richard Henderson
2024-02-29 13:10 ` [RFC PATCH v5 09/22] target/arm: Handle PSTATE.ALLINT on taking an exception Jinjie Ruan via
2024-02-29 13:10 ` [RFC PATCH v5 10/22] hw/arm/virt: Wire NMI and VNMI irq lines from GIC to CPU Jinjie Ruan via
2024-02-29 13:10 ` [RFC PATCH v5 11/22] hw/intc/arm_gicv3: Add external IRQ lines for NMI Jinjie Ruan via
2024-02-29 13:10 ` [RFC PATCH v5 12/22] target/arm: Handle NMI in arm_cpu_do_interrupt_aarch64() Jinjie Ruan via
2024-02-29 23:09   ` Richard Henderson
2024-03-01  3:42     ` Jinjie Ruan via
2024-03-01 17:44       ` Richard Henderson
2024-02-29 13:10 ` [RFC PATCH v5 13/22] hw/intc/arm_gicv3: Add irq superpriority information Jinjie Ruan via
2024-02-29 13:10 ` [RFC PATCH v5 14/22] hw/intc/arm_gicv3_redist: Implement GICR_INMIR0 Jinjie Ruan via
2024-02-29 23:10   ` Richard Henderson
2024-02-29 13:10 ` [RFC PATCH v5 15/22] hw/intc/arm_gicv3: Implement GICD_INMIR Jinjie Ruan via
2024-02-29 13:10 ` [RFC PATCH v5 16/22] hw/intc: Enable FEAT_GICv3_NMI Feature Jinjie Ruan via
2024-02-29 13:10 ` [RFC PATCH v5 17/22] hw/intc/arm_gicv3: Add NMI handling CPU interface registers Jinjie Ruan via
2024-02-29 23:32   ` Richard Henderson
2024-02-29 13:10 ` [RFC PATCH v5 18/22] hw/intc/arm_gicv3: Implement NMI interrupt prioirty Jinjie Ruan via
2024-02-29 23:50   ` Richard Henderson
2024-03-04 12:18     ` Jinjie Ruan via
2024-03-05  3:58       ` Jinjie Ruan via
2024-03-04 12:59     ` Jinjie Ruan via
2024-02-29 13:10 ` [RFC PATCH v5 19/22] hw/intc/arm_gicv3: Report the NMI interrupt in gicv3_cpuif_update() Jinjie Ruan via
2024-03-01  0:22   ` Richard Henderson
2024-02-29 13:10 ` [RFC PATCH v5 20/22] hw/intc/arm_gicv3: Report the VNMI interrupt Jinjie Ruan via
2024-02-29 23:20   ` Richard Henderson
2024-02-29 13:10 ` [RFC PATCH v5 21/22] target/arm: Add FEAT_NMI to max Jinjie Ruan via
2024-02-29 13:10 ` Jinjie Ruan via [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240229131039.1868904-23-ruanjinjie@huawei.com \
    --to=qemu-devel@nongnu.org \
    --cc=eduardo@habkost.net \
    --cc=marcel.apfelbaum@gmail.com \
    --cc=peter.maydell@linaro.org \
    --cc=philmd@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=ruanjinjie@huawei.com \
    --cc=wangyanan55@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.