All of lore.kernel.org
 help / color / mirror / Atom feed
From: Song Gao <gaosong@loongson.cn>
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, richard.henderson@linaro.org,
	philmd@linaro.org, maobibo@loongson.cn, zhaotianrui@loongson.cn,
	lixianglai@loongson.cn, imammedo@redhat.com, anisinha@redhat.com,
	mst@redhat.com
Subject: [PATCH v5 17/17] hw/loongarch: Add cells missing from rtc node
Date: Fri,  1 Mar 2024 17:38:38 +0800	[thread overview]
Message-ID: <20240301093839.663947-18-gaosong@loongson.cn> (raw)
In-Reply-To: <20240301093839.663947-1-gaosong@loongson.cn>

rtc node need interrupts and interrupt-parent cells.

Signed-off-by: Song Gao <gaosong@loongson.cn>
---
 hw/loongarch/virt.c | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)

diff --git a/hw/loongarch/virt.c b/hw/loongarch/virt.c
index 5d92b2f1aa..6810f78ebd 100644
--- a/hw/loongarch/virt.c
+++ b/hw/loongarch/virt.c
@@ -195,7 +195,8 @@ static void fdt_add_flash_node(LoongArchMachineState *lams)
     g_free(nodename);
 }
 
-static void fdt_add_rtc_node(LoongArchMachineState *lams)
+static void fdt_add_rtc_node(LoongArchMachineState *lams,
+                             uint32_t *pch_pic_phandle)
 {
     char *nodename;
     hwaddr base = VIRT_RTC_REG_BASE;
@@ -204,8 +205,13 @@ static void fdt_add_rtc_node(LoongArchMachineState *lams)
 
     nodename = g_strdup_printf("/rtc@%" PRIx64, base);
     qemu_fdt_add_subnode(ms->fdt, nodename);
-    qemu_fdt_setprop_string(ms->fdt, nodename, "compatible", "loongson,ls7a-rtc");
+    qemu_fdt_setprop_string(ms->fdt, nodename, "compatible",
+                            "loongson,ls7a-rtc");
     qemu_fdt_setprop_sized_cells(ms->fdt, nodename, "reg", 2, base, 2, size);
+    qemu_fdt_setprop_cells(ms->fdt, nodename, "interrupts",
+                           VIRT_RTC_IRQ - VIRT_GSI_BASE , 0x4);
+    qemu_fdt_setprop_cell(ms->fdt, nodename, "interrupt-parent",
+                          *pch_pic_phandle);
     g_free(nodename);
 }
 
@@ -611,7 +617,7 @@ static void loongarch_devices_init(DeviceState *pch_pic,
     sysbus_create_simple("ls7a_rtc", VIRT_RTC_REG_BASE,
                          qdev_get_gpio_in(pch_pic,
                          VIRT_RTC_IRQ - VIRT_GSI_BASE));
-    fdt_add_rtc_node(lams);
+    fdt_add_rtc_node(lams, pch_pic_phandle);
 
     /* acpi ged */
     lams->acpi_ged = create_acpi_ged(pch_pic, lams);
-- 
2.25.1



  parent reply	other threads:[~2024-03-01  9:41 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-01  9:38 [PATCH v5 00/17] Add boot LoongArch elf kernel with FDT Song Gao
2024-03-01  9:38 ` [PATCH v5 01/17] hw/loongarch: Move boot fucntions to boot.c Song Gao
2024-03-01  9:38 ` [PATCH v5 02/17] hw/loongarch: Add load initrd Song Gao
2024-03-01  9:38 ` [PATCH v5 03/17] hw/loongarch: Add slave cpu boot_code Song Gao
2024-03-01  9:38 ` [PATCH v5 04/17] hw/loongarch: Add init_cmdline Song Gao
2024-03-01  9:38 ` [PATCH v5 05/17] hw/loongarch: Init efi_system_table Song Gao
2024-03-01  9:38 ` [PATCH v5 06/17] hw/loongarch: Init efi_boot_memmap table Song Gao
2024-03-01  9:38 ` [PATCH v5 07/17] hw/loongarch: Init efi_initrd table Song Gao
2024-03-01  9:38 ` [PATCH v5 08/17] hw/loongarch: Init efi_fdt table Song Gao
2024-03-01  9:38 ` [PATCH v5 09/17] hw/loongarch: Fix fdt memory node wrong 'reg' Song Gao
2024-03-01  9:38 ` [PATCH v5 10/17] hw/loongarch: fdt adds cpu interrupt controller node Song Gao
2024-03-01  9:38 ` [PATCH v5 11/17] hw/loongarch: fdt adds Extend I/O Interrupt Controller Song Gao
2024-03-01  9:38 ` [PATCH v5 12/17] hw/loongarch: fdt adds pch_pic Controller Song Gao
2024-03-01  9:38 ` [PATCH v5 13/17] hw/loongarch: fdt adds pch_msi Controller Song Gao
2024-03-01  9:38 ` [PATCH v5 14/17] hw/loongarch: fdt adds pcie irq_map node Song Gao
2024-03-01  9:38 ` [PATCH v5 15/17] hw/loongarch: fdt remove unused irqchip node Song Gao
2024-03-01  9:38 ` [PATCH v5 16/17] hw/loongarch: Add cells missing from uart node Song Gao
2024-03-01  9:38 ` Song Gao [this message]
2024-03-01  9:44 ` [PATCH v5 00/17] Add boot LoongArch elf kernel with FDT gaosong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240301093839.663947-18-gaosong@loongson.cn \
    --to=gaosong@loongson.cn \
    --cc=anisinha@redhat.com \
    --cc=imammedo@redhat.com \
    --cc=lixianglai@loongson.cn \
    --cc=maobibo@loongson.cn \
    --cc=mst@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=philmd@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    --cc=zhaotianrui@loongson.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.