From: Anand Moon <linux.amoon@gmail.com> To: Alan Stern <stern@rowland.harvard.edu>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>, Alim Akhtar <alim.akhtar@samsung.com> Cc: Anand Moon <linux.amoon@gmail.com>, linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v1 2/4] usb: ehci-exynos: Switch from CONFIG_PM guards to pm_ptr() Date: Sat, 2 Mar 2024 01:08:09 +0530 [thread overview] Message-ID: <20240301193831.3346-3-linux.amoon@gmail.com> (raw) In-Reply-To: <20240301193831.3346-1-linux.amoon@gmail.com> Use the new PM macros for the suspend and resume functions to be automatically dropped by the compiler when CONFIG_PM are disabled, without having to use #ifdef guards. If CONFIG_PM unused, they will simply be discarded by the compiler. Use RUNTIME_PM_OPS runtime macro for suspend/resume function. Signed-off-by: Anand Moon <linux.amoon@gmail.com> --- drivers/usb/host/ehci-exynos.c | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/usb/host/ehci-exynos.c b/drivers/usb/host/ehci-exynos.c index 05aa3d9c2a3b..4676f45655cd 100644 --- a/drivers/usb/host/ehci-exynos.c +++ b/drivers/usb/host/ehci-exynos.c @@ -234,7 +234,6 @@ static void exynos_ehci_remove(struct platform_device *pdev) usb_put_hcd(hcd); } -#ifdef CONFIG_PM static int exynos_ehci_suspend(struct device *dev) { struct usb_hcd *hcd = dev_get_drvdata(dev); @@ -268,14 +267,9 @@ static int exynos_ehci_resume(struct device *dev) ehci_resume(hcd, false); return 0; } -#else -#define exynos_ehci_suspend NULL -#define exynos_ehci_resume NULL -#endif static const struct dev_pm_ops exynos_ehci_pm_ops = { - .suspend = exynos_ehci_suspend, - .resume = exynos_ehci_resume, + RUNTIME_PM_OPS(exynos_ehci_suspend, exynos_ehci_resume, NULL) }; #ifdef CONFIG_OF @@ -292,7 +286,7 @@ static struct platform_driver exynos_ehci_driver = { .shutdown = usb_hcd_platform_shutdown, .driver = { .name = "exynos-ehci", - .pm = &exynos_ehci_pm_ops, + .pm = pm_ptr(&exynos_ehci_pm_ops), .of_match_table = of_match_ptr(exynos_ehci_match), } }; -- 2.43.0
WARNING: multiple messages have this Message-ID (diff)
From: Anand Moon <linux.amoon@gmail.com> To: Alan Stern <stern@rowland.harvard.edu>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>, Alim Akhtar <alim.akhtar@samsung.com> Cc: Anand Moon <linux.amoon@gmail.com>, linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v1 2/4] usb: ehci-exynos: Switch from CONFIG_PM guards to pm_ptr() Date: Sat, 2 Mar 2024 01:08:09 +0530 [thread overview] Message-ID: <20240301193831.3346-3-linux.amoon@gmail.com> (raw) In-Reply-To: <20240301193831.3346-1-linux.amoon@gmail.com> Use the new PM macros for the suspend and resume functions to be automatically dropped by the compiler when CONFIG_PM are disabled, without having to use #ifdef guards. If CONFIG_PM unused, they will simply be discarded by the compiler. Use RUNTIME_PM_OPS runtime macro for suspend/resume function. Signed-off-by: Anand Moon <linux.amoon@gmail.com> --- drivers/usb/host/ehci-exynos.c | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/usb/host/ehci-exynos.c b/drivers/usb/host/ehci-exynos.c index 05aa3d9c2a3b..4676f45655cd 100644 --- a/drivers/usb/host/ehci-exynos.c +++ b/drivers/usb/host/ehci-exynos.c @@ -234,7 +234,6 @@ static void exynos_ehci_remove(struct platform_device *pdev) usb_put_hcd(hcd); } -#ifdef CONFIG_PM static int exynos_ehci_suspend(struct device *dev) { struct usb_hcd *hcd = dev_get_drvdata(dev); @@ -268,14 +267,9 @@ static int exynos_ehci_resume(struct device *dev) ehci_resume(hcd, false); return 0; } -#else -#define exynos_ehci_suspend NULL -#define exynos_ehci_resume NULL -#endif static const struct dev_pm_ops exynos_ehci_pm_ops = { - .suspend = exynos_ehci_suspend, - .resume = exynos_ehci_resume, + RUNTIME_PM_OPS(exynos_ehci_suspend, exynos_ehci_resume, NULL) }; #ifdef CONFIG_OF @@ -292,7 +286,7 @@ static struct platform_driver exynos_ehci_driver = { .shutdown = usb_hcd_platform_shutdown, .driver = { .name = "exynos-ehci", - .pm = &exynos_ehci_pm_ops, + .pm = pm_ptr(&exynos_ehci_pm_ops), .of_match_table = of_match_ptr(exynos_ehci_match), } }; -- 2.43.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-03-01 19:39 UTC|newest] Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <20240301193831.3346-1-linux.amoon@gmail.com> 2024-03-01 19:38 ` [PATCH v1 1/4] usb: ehci-exynos: Use devm_clk_get_enabled() helpers Anand Moon 2024-03-01 19:38 ` Anand Moon 2024-03-01 20:19 ` Alan Stern 2024-03-01 20:19 ` Alan Stern 2024-03-02 15:41 ` Anand Moon 2024-03-02 15:41 ` Anand Moon 2024-03-02 15:49 ` Christophe JAILLET 2024-03-02 15:49 ` Christophe JAILLET 2024-03-02 16:35 ` Anand Moon 2024-03-02 16:35 ` Anand Moon 2024-03-02 18:41 ` Christophe JAILLET 2024-03-02 18:41 ` Christophe JAILLET 2024-03-02 18:41 ` Christophe JAILLET 2024-03-04 9:18 ` Johan Hovold 2024-03-04 9:18 ` Johan Hovold 2024-03-04 10:05 ` Anand Moon 2024-03-04 10:05 ` Anand Moon 2024-03-01 19:38 ` Anand Moon [this message] 2024-03-01 19:38 ` [PATCH v1 2/4] usb: ehci-exynos: Switch from CONFIG_PM guards to pm_ptr() Anand Moon 2024-03-01 20:28 ` Alan Stern 2024-03-01 20:28 ` Alan Stern 2024-03-02 15:41 ` Anand Moon 2024-03-02 15:41 ` Anand Moon 2024-03-04 9:21 ` Johan Hovold 2024-03-04 9:21 ` Johan Hovold 2024-03-04 10:16 ` Anand Moon 2024-03-04 10:16 ` Anand Moon 2024-03-01 19:38 ` [PATCH v1 3/4] usb: dwc3: exynos: Use devm_regulator_bulk_get_enable() helper function Anand Moon 2024-03-01 19:38 ` Anand Moon 2024-03-02 15:50 ` Christophe JAILLET 2024-03-02 15:50 ` Christophe JAILLET 2024-03-02 16:48 ` Anand Moon 2024-03-02 16:48 ` Anand Moon 2024-03-02 18:37 ` Christophe JAILLET 2024-03-02 18:37 ` Christophe JAILLET 2024-03-04 11:46 ` Anand Moon 2024-03-04 11:46 ` Anand Moon 2024-04-05 6:10 ` Anand Moon 2024-04-05 6:10 ` Anand Moon 2024-04-05 16:12 ` Christophe JAILLET 2024-04-05 16:12 ` Christophe JAILLET 2024-04-06 3:40 ` Anand Moon 2024-04-06 3:40 ` Anand Moon 2024-04-08 10:02 ` Anand Moon 2024-04-08 10:02 ` Anand Moon 2024-04-08 20:26 ` Christophe JAILLET 2024-04-08 20:26 ` Christophe JAILLET 2024-03-01 19:38 ` [PATCH v1 4/4] usb: dwc3: exynos: Switch from CONFIG_PM_SLEEP guards to pm_sleep_ptr() Anand Moon 2024-03-01 19:38 ` Anand Moon
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20240301193831.3346-3-linux.amoon@gmail.com \ --to=linux.amoon@gmail.com \ --cc=alim.akhtar@samsung.com \ --cc=gregkh@linuxfoundation.org \ --cc=krzysztof.kozlowski@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-samsung-soc@vger.kernel.org \ --cc=linux-usb@vger.kernel.org \ --cc=stern@rowland.harvard.edu \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.