All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anand Moon <linux.amoon@gmail.com>
To: Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	Alim Akhtar <alim.akhtar@samsung.com>
Cc: Anand Moon <linux.amoon@gmail.com>,
	linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v1 4/4] usb: dwc3: exynos: Switch from CONFIG_PM_SLEEP guards to pm_sleep_ptr()
Date: Sat,  2 Mar 2024 01:08:11 +0530	[thread overview]
Message-ID: <20240301193831.3346-5-linux.amoon@gmail.com> (raw)
In-Reply-To: <20240301193831.3346-1-linux.amoon@gmail.com>

Use the new PM macros for the suspend and resume functions to be
automatically dropped by the compiler when CONFIG_PM_SLEEP are disabled,
without having to use #ifdef guards. If CONFIG_PM_SLEEP unused,
they will simply be discarded by the compiler.

Signed-off-by: Anand Moon <linux.amoon@gmail.com>
---
 drivers/usb/dwc3/dwc3-exynos.c | 8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)

diff --git a/drivers/usb/dwc3/dwc3-exynos.c b/drivers/usb/dwc3/dwc3-exynos.c
index 7c77f3c69825..645a4ec0cd92 100644
--- a/drivers/usb/dwc3/dwc3-exynos.c
+++ b/drivers/usb/dwc3/dwc3-exynos.c
@@ -160,7 +160,6 @@ static const struct of_device_id exynos_dwc3_match[] = {
 };
 MODULE_DEVICE_TABLE(of, exynos_dwc3_match);
 
-#ifdef CONFIG_PM_SLEEP
 static int dwc3_exynos_suspend(struct device *dev)
 {
 	struct dwc3_exynos *exynos = dev_get_drvdata(dev);
@@ -193,18 +192,13 @@ static const struct dev_pm_ops dwc3_exynos_dev_pm_ops = {
 	SET_SYSTEM_SLEEP_PM_OPS(dwc3_exynos_suspend, dwc3_exynos_resume)
 };
 
-#define DEV_PM_OPS	(&dwc3_exynos_dev_pm_ops)
-#else
-#define DEV_PM_OPS	NULL
-#endif /* CONFIG_PM_SLEEP */
-
 static struct platform_driver dwc3_exynos_driver = {
 	.probe		= dwc3_exynos_probe,
 	.remove_new	= dwc3_exynos_remove,
 	.driver		= {
 		.name	= "exynos-dwc3",
 		.of_match_table = exynos_dwc3_match,
-		.pm	= DEV_PM_OPS,
+		.pm	= pm_sleep_ptr(&dwc3_exynos_dev_pm_ops),
 	},
 };
 
-- 
2.43.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Anand Moon <linux.amoon@gmail.com>
To: Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	Alim Akhtar <alim.akhtar@samsung.com>
Cc: Anand Moon <linux.amoon@gmail.com>,
	linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v1 4/4] usb: dwc3: exynos: Switch from CONFIG_PM_SLEEP guards to pm_sleep_ptr()
Date: Sat,  2 Mar 2024 01:08:11 +0530	[thread overview]
Message-ID: <20240301193831.3346-5-linux.amoon@gmail.com> (raw)
In-Reply-To: <20240301193831.3346-1-linux.amoon@gmail.com>

Use the new PM macros for the suspend and resume functions to be
automatically dropped by the compiler when CONFIG_PM_SLEEP are disabled,
without having to use #ifdef guards. If CONFIG_PM_SLEEP unused,
they will simply be discarded by the compiler.

Signed-off-by: Anand Moon <linux.amoon@gmail.com>
---
 drivers/usb/dwc3/dwc3-exynos.c | 8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)

diff --git a/drivers/usb/dwc3/dwc3-exynos.c b/drivers/usb/dwc3/dwc3-exynos.c
index 7c77f3c69825..645a4ec0cd92 100644
--- a/drivers/usb/dwc3/dwc3-exynos.c
+++ b/drivers/usb/dwc3/dwc3-exynos.c
@@ -160,7 +160,6 @@ static const struct of_device_id exynos_dwc3_match[] = {
 };
 MODULE_DEVICE_TABLE(of, exynos_dwc3_match);
 
-#ifdef CONFIG_PM_SLEEP
 static int dwc3_exynos_suspend(struct device *dev)
 {
 	struct dwc3_exynos *exynos = dev_get_drvdata(dev);
@@ -193,18 +192,13 @@ static const struct dev_pm_ops dwc3_exynos_dev_pm_ops = {
 	SET_SYSTEM_SLEEP_PM_OPS(dwc3_exynos_suspend, dwc3_exynos_resume)
 };
 
-#define DEV_PM_OPS	(&dwc3_exynos_dev_pm_ops)
-#else
-#define DEV_PM_OPS	NULL
-#endif /* CONFIG_PM_SLEEP */
-
 static struct platform_driver dwc3_exynos_driver = {
 	.probe		= dwc3_exynos_probe,
 	.remove_new	= dwc3_exynos_remove,
 	.driver		= {
 		.name	= "exynos-dwc3",
 		.of_match_table = exynos_dwc3_match,
-		.pm	= DEV_PM_OPS,
+		.pm	= pm_sleep_ptr(&dwc3_exynos_dev_pm_ops),
 	},
 };
 
-- 
2.43.0


  parent reply	other threads:[~2024-03-01 19:39 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20240301193831.3346-1-linux.amoon@gmail.com>
2024-03-01 19:38 ` [PATCH v1 1/4] usb: ehci-exynos: Use devm_clk_get_enabled() helpers Anand Moon
2024-03-01 19:38   ` Anand Moon
2024-03-01 20:19   ` Alan Stern
2024-03-01 20:19     ` Alan Stern
2024-03-02 15:41     ` Anand Moon
2024-03-02 15:41       ` Anand Moon
2024-03-02 15:49   ` Christophe JAILLET
2024-03-02 15:49     ` Christophe JAILLET
2024-03-02 16:35     ` Anand Moon
2024-03-02 16:35       ` Anand Moon
2024-03-02 18:41       ` Christophe JAILLET
2024-03-02 18:41       ` Christophe JAILLET
2024-03-02 18:41         ` Christophe JAILLET
2024-03-04  9:18       ` Johan Hovold
2024-03-04  9:18         ` Johan Hovold
2024-03-04 10:05         ` Anand Moon
2024-03-04 10:05           ` Anand Moon
2024-03-01 19:38 ` [PATCH v1 2/4] usb: ehci-exynos: Switch from CONFIG_PM guards to pm_ptr() Anand Moon
2024-03-01 19:38   ` Anand Moon
2024-03-01 20:28   ` Alan Stern
2024-03-01 20:28     ` Alan Stern
2024-03-02 15:41     ` Anand Moon
2024-03-02 15:41       ` Anand Moon
2024-03-04  9:21   ` Johan Hovold
2024-03-04  9:21     ` Johan Hovold
2024-03-04 10:16     ` Anand Moon
2024-03-04 10:16       ` Anand Moon
2024-03-01 19:38 ` [PATCH v1 3/4] usb: dwc3: exynos: Use devm_regulator_bulk_get_enable() helper function Anand Moon
2024-03-01 19:38   ` Anand Moon
2024-03-02 15:50   ` Christophe JAILLET
2024-03-02 15:50     ` Christophe JAILLET
2024-03-02 16:48     ` Anand Moon
2024-03-02 16:48       ` Anand Moon
2024-03-02 18:37       ` Christophe JAILLET
2024-03-02 18:37         ` Christophe JAILLET
2024-03-04 11:46         ` Anand Moon
2024-03-04 11:46           ` Anand Moon
2024-04-05  6:10           ` Anand Moon
2024-04-05  6:10             ` Anand Moon
2024-04-05 16:12             ` Christophe JAILLET
2024-04-05 16:12               ` Christophe JAILLET
2024-04-06  3:40               ` Anand Moon
2024-04-06  3:40                 ` Anand Moon
2024-04-08 10:02               ` Anand Moon
2024-04-08 10:02                 ` Anand Moon
2024-04-08 20:26                 ` Christophe JAILLET
2024-04-08 20:26                   ` Christophe JAILLET
2024-03-01 19:38 ` Anand Moon [this message]
2024-03-01 19:38   ` [PATCH v1 4/4] usb: dwc3: exynos: Switch from CONFIG_PM_SLEEP guards to pm_sleep_ptr() Anand Moon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240301193831.3346-5-linux.amoon@gmail.com \
    --to=linux.amoon@gmail.com \
    --cc=Thinh.Nguyen@synopsys.com \
    --cc=alim.akhtar@samsung.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.