All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Uwe Kleine-König" <ukleinek@debian.org>
To: Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>, Andrew Lunn <andrew@lunn.ch>,
	Heiko Stuebner <heiko@sntech.de>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org
Subject: [PATCH] arm64: dts: rockchip: qnap-ts433: Simplify network PHY connection
Date: Mon,  4 Mar 2024 09:46:11 +0100	[thread overview]
Message-ID: <20240304084612.711678-2-ukleinek@debian.org> (raw)

While it requires to have the right phy driver loaded (i.e. motorcomm)
to make the phy asserting the right delays, this is generally the
preferred way to define the MAC <-> PHY connection.

Signed-off-by: Uwe Kleine-König <ukleinek@debian.org>
---
Hello,

Andrew already pointed out when I posted the patch introducing the gmac0 node
that rgmii-id would be the preferred way to setup things. Back then this didn't
happen because this change broke reception of network packets. However this
only happend because I didn't have the right phy driver loaded.

Best regards
Uwe

 arch/arm64/boot/dts/rockchip/rk3568-qnap-ts433.dts | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/arch/arm64/boot/dts/rockchip/rk3568-qnap-ts433.dts b/arch/arm64/boot/dts/rockchip/rk3568-qnap-ts433.dts
index 6a998166003c..36ad48d46bc1 100644
--- a/arch/arm64/boot/dts/rockchip/rk3568-qnap-ts433.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3568-qnap-ts433.dts
@@ -20,15 +20,13 @@ &gmac0 {
 	assigned-clock-rates = <0>, <125000000>;
 	clock_in_out = "output";
 	phy-handle = <&rgmii_phy0>;
-	phy-mode = "rgmii";
+	phy-mode = "rgmii-id";
 	pinctrl-names = "default";
 	pinctrl-0 = <&gmac0_miim
 		     &gmac0_tx_bus2
 		     &gmac0_rx_bus2
 		     &gmac0_rgmii_clk
 		     &gmac0_rgmii_bus>;
-	rx_delay = <0x2f>;
-	tx_delay = <0x3c>;
 	status = "okay";
 };
 

base-commit: 67908bf6954b7635d33760ff6dfc189fc26ccc89
-- 
2.43.0


WARNING: multiple messages have this Message-ID (diff)
From: "Uwe Kleine-König" <ukleinek@debian.org>
To: Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>, Andrew Lunn <andrew@lunn.ch>,
	Heiko Stuebner <heiko@sntech.de>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org
Subject: [PATCH] arm64: dts: rockchip: qnap-ts433: Simplify network PHY connection
Date: Mon,  4 Mar 2024 09:46:11 +0100	[thread overview]
Message-ID: <20240304084612.711678-2-ukleinek@debian.org> (raw)

While it requires to have the right phy driver loaded (i.e. motorcomm)
to make the phy asserting the right delays, this is generally the
preferred way to define the MAC <-> PHY connection.

Signed-off-by: Uwe Kleine-König <ukleinek@debian.org>
---
Hello,

Andrew already pointed out when I posted the patch introducing the gmac0 node
that rgmii-id would be the preferred way to setup things. Back then this didn't
happen because this change broke reception of network packets. However this
only happend because I didn't have the right phy driver loaded.

Best regards
Uwe

 arch/arm64/boot/dts/rockchip/rk3568-qnap-ts433.dts | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/arch/arm64/boot/dts/rockchip/rk3568-qnap-ts433.dts b/arch/arm64/boot/dts/rockchip/rk3568-qnap-ts433.dts
index 6a998166003c..36ad48d46bc1 100644
--- a/arch/arm64/boot/dts/rockchip/rk3568-qnap-ts433.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3568-qnap-ts433.dts
@@ -20,15 +20,13 @@ &gmac0 {
 	assigned-clock-rates = <0>, <125000000>;
 	clock_in_out = "output";
 	phy-handle = <&rgmii_phy0>;
-	phy-mode = "rgmii";
+	phy-mode = "rgmii-id";
 	pinctrl-names = "default";
 	pinctrl-0 = <&gmac0_miim
 		     &gmac0_tx_bus2
 		     &gmac0_rx_bus2
 		     &gmac0_rgmii_clk
 		     &gmac0_rgmii_bus>;
-	rx_delay = <0x2f>;
-	tx_delay = <0x3c>;
 	status = "okay";
 };
 

base-commit: 67908bf6954b7635d33760ff6dfc189fc26ccc89
-- 
2.43.0


_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

WARNING: multiple messages have this Message-ID (diff)
From: "Uwe Kleine-König" <ukleinek@debian.org>
To: Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>, Andrew Lunn <andrew@lunn.ch>,
	Heiko Stuebner <heiko@sntech.de>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org
Subject: [PATCH] arm64: dts: rockchip: qnap-ts433: Simplify network PHY connection
Date: Mon,  4 Mar 2024 09:46:11 +0100	[thread overview]
Message-ID: <20240304084612.711678-2-ukleinek@debian.org> (raw)

While it requires to have the right phy driver loaded (i.e. motorcomm)
to make the phy asserting the right delays, this is generally the
preferred way to define the MAC <-> PHY connection.

Signed-off-by: Uwe Kleine-König <ukleinek@debian.org>
---
Hello,

Andrew already pointed out when I posted the patch introducing the gmac0 node
that rgmii-id would be the preferred way to setup things. Back then this didn't
happen because this change broke reception of network packets. However this
only happend because I didn't have the right phy driver loaded.

Best regards
Uwe

 arch/arm64/boot/dts/rockchip/rk3568-qnap-ts433.dts | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/arch/arm64/boot/dts/rockchip/rk3568-qnap-ts433.dts b/arch/arm64/boot/dts/rockchip/rk3568-qnap-ts433.dts
index 6a998166003c..36ad48d46bc1 100644
--- a/arch/arm64/boot/dts/rockchip/rk3568-qnap-ts433.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3568-qnap-ts433.dts
@@ -20,15 +20,13 @@ &gmac0 {
 	assigned-clock-rates = <0>, <125000000>;
 	clock_in_out = "output";
 	phy-handle = <&rgmii_phy0>;
-	phy-mode = "rgmii";
+	phy-mode = "rgmii-id";
 	pinctrl-names = "default";
 	pinctrl-0 = <&gmac0_miim
 		     &gmac0_tx_bus2
 		     &gmac0_rx_bus2
 		     &gmac0_rgmii_clk
 		     &gmac0_rgmii_bus>;
-	rx_delay = <0x2f>;
-	tx_delay = <0x3c>;
 	status = "okay";
 };
 

base-commit: 67908bf6954b7635d33760ff6dfc189fc26ccc89
-- 
2.43.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

             reply	other threads:[~2024-03-04  8:46 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-04  8:46 Uwe Kleine-König [this message]
2024-03-04  8:46 ` [PATCH] arm64: dts: rockchip: qnap-ts433: Simplify network PHY connection Uwe Kleine-König
2024-03-04  8:46 ` Uwe Kleine-König
2024-03-04  9:07 ` Heiko Stübner
2024-03-04  9:07   ` Heiko Stübner
2024-03-04  9:07   ` Heiko Stübner
2024-03-04  9:15   ` Uwe Kleine-König
2024-03-04  9:15     ` Uwe Kleine-König
2024-03-04  9:15     ` Uwe Kleine-König
2024-03-04  9:24     ` Heiko Stübner
2024-03-04  9:24       ` Heiko Stübner
2024-03-04  9:24       ` Heiko Stübner
2024-03-04 21:03       ` Uwe Kleine-König
2024-03-04 21:03         ` Uwe Kleine-König
2024-03-04 21:03         ` Uwe Kleine-König
2024-03-04 10:07 ` Chen-Yu Tsai
2024-03-04 10:07   ` Chen-Yu Tsai
2024-03-04 10:07   ` Chen-Yu Tsai
2024-03-04 13:09   ` Andrew Lunn
2024-03-04 13:09     ` Andrew Lunn
2024-03-04 13:09     ` Andrew Lunn
2024-03-04 15:32     ` Diederik de Haas
2024-03-04 15:32       ` Diederik de Haas
2024-03-04 15:32       ` Diederik de Haas
2024-03-04 15:46       ` Jonas Karlman
2024-03-04 15:46         ` Jonas Karlman
2024-03-04 15:46         ` Jonas Karlman
2024-03-04 16:47         ` Diederik de Haas
2024-03-04 16:47           ` Diederik de Haas
2024-03-04 16:47           ` Diederik de Haas
2024-03-04 15:59       ` Andrew Lunn
2024-03-04 15:59         ` Andrew Lunn
2024-03-04 15:59         ` Andrew Lunn
2024-03-04 16:43         ` Diederik de Haas
2024-03-04 16:43           ` Diederik de Haas
2024-03-04 16:43           ` Diederik de Haas
2024-03-04 22:44           ` Uwe Kleine-König
2024-03-04 22:44             ` Uwe Kleine-König
2024-03-04 22:44             ` Uwe Kleine-König
2024-03-06  0:03             ` Diederik de Haas
2024-03-06  0:03               ` Diederik de Haas
2024-03-06  0:03               ` Diederik de Haas
2024-03-12 18:39               ` Dragan Simic
2024-03-12 18:39                 ` Dragan Simic
2024-03-12 18:39                 ` Dragan Simic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240304084612.711678-2-ukleinek@debian.org \
    --to=ukleinek@debian.org \
    --cc=andrew@lunn.ch \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=heiko@sntech.de \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.