From: Jani Nikula <jani.nikula@intel.com> To: Michael Ellerman <mpe@ellerman.id.au>, linuxppc-dev@lists.ozlabs.org Cc: jani.nikula@intel.com, dri-devel@lists.freedesktop.org, lkft-triage@lists.linaro.org, linux-kernel@vger.kernel.org, Naresh Kamboju <naresh.kamboju@linaro.org>, Thomas Zimmermann <tzimmermann@suse.de>, Helge Deller <deller@gmx.de>, linux-fbdev@vger.kernel.org Subject: [PATCH] powerpc: include linux/backlight.h from asm/backlight.h Date: Mon, 4 Mar 2024 11:55:12 +0200 [thread overview] Message-ID: <20240304095512.742348-1-jani.nikula@intel.com> (raw) In-Reply-To: <CA+G9fYsAk5TbqqxFC2W4oHLGA0CbTHMxbeq8QayFXTU75YiueA@mail.gmail.com> Removal of the backlight include from fb.h uncovered an implicit dependency in powerpc asm/backlight.h. Add the explicit include. Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org> Closes: https://lore.kernel.org/r/CA+G9fYsAk5TbqqxFC2W4oHLGA0CbTHMxbeq8QayFXTU75YiueA@mail.gmail.com Fixes: 11b4eedfc87d ("fbdev: Do not include <linux/backlight.h> in header") Cc: Thomas Zimmermann <tzimmermann@suse.de> Cc: Helge Deller <deller@gmx.de> Cc: linux-fbdev@vger.kernel.org Signed-off-by: Jani Nikula <jani.nikula@intel.com> --- Not even compile tested! --- arch/powerpc/include/asm/backlight.h | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/powerpc/include/asm/backlight.h b/arch/powerpc/include/asm/backlight.h index 1b5eab62ed04..275d5bb9aa04 100644 --- a/arch/powerpc/include/asm/backlight.h +++ b/arch/powerpc/include/asm/backlight.h @@ -10,6 +10,7 @@ #define __ASM_POWERPC_BACKLIGHT_H #ifdef __KERNEL__ +#include <linux/backlight.h> #include <linux/fb.h> #include <linux/mutex.h> -- 2.39.2
WARNING: multiple messages have this Message-ID (diff)
From: Jani Nikula <jani.nikula@intel.com> To: Michael Ellerman <mpe@ellerman.id.au>, linuxppc-dev@lists.ozlabs.org Cc: linux-fbdev@vger.kernel.org, jani.nikula@intel.com, Naresh Kamboju <naresh.kamboju@linaro.org>, linux-kernel@vger.kernel.org, lkft-triage@lists.linaro.org, dri-devel@lists.freedesktop.org, Thomas Zimmermann <tzimmermann@suse.de>, Helge Deller <deller@gmx.de> Subject: [PATCH] powerpc: include linux/backlight.h from asm/backlight.h Date: Mon, 4 Mar 2024 11:55:12 +0200 [thread overview] Message-ID: <20240304095512.742348-1-jani.nikula@intel.com> (raw) In-Reply-To: <CA+G9fYsAk5TbqqxFC2W4oHLGA0CbTHMxbeq8QayFXTU75YiueA@mail.gmail.com> Removal of the backlight include from fb.h uncovered an implicit dependency in powerpc asm/backlight.h. Add the explicit include. Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org> Closes: https://lore.kernel.org/r/CA+G9fYsAk5TbqqxFC2W4oHLGA0CbTHMxbeq8QayFXTU75YiueA@mail.gmail.com Fixes: 11b4eedfc87d ("fbdev: Do not include <linux/backlight.h> in header") Cc: Thomas Zimmermann <tzimmermann@suse.de> Cc: Helge Deller <deller@gmx.de> Cc: linux-fbdev@vger.kernel.org Signed-off-by: Jani Nikula <jani.nikula@intel.com> --- Not even compile tested! --- arch/powerpc/include/asm/backlight.h | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/powerpc/include/asm/backlight.h b/arch/powerpc/include/asm/backlight.h index 1b5eab62ed04..275d5bb9aa04 100644 --- a/arch/powerpc/include/asm/backlight.h +++ b/arch/powerpc/include/asm/backlight.h @@ -10,6 +10,7 @@ #define __ASM_POWERPC_BACKLIGHT_H #ifdef __KERNEL__ +#include <linux/backlight.h> #include <linux/fb.h> #include <linux/mutex.h> -- 2.39.2
next prev parent reply other threads:[~2024-03-04 9:55 UTC|newest] Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top 2024-03-04 8:20 fbdev/chipsfb.c:401:31: error: invalid use of undefined type 'struct backlight_device' Naresh Kamboju 2024-03-04 9:55 ` Jani Nikula [this message] 2024-03-04 9:55 ` [PATCH] powerpc: include linux/backlight.h from asm/backlight.h Jani Nikula 2024-03-04 10:01 ` Jani Nikula 2024-03-04 10:01 ` Jani Nikula 2024-03-04 14:55 ` Naresh Kamboju 2024-03-04 14:55 ` Naresh Kamboju 2024-03-05 0:39 ` Michael Ellerman 2024-03-05 0:39 ` Michael Ellerman 2024-03-05 8:19 ` Jani Nikula 2024-03-05 8:19 ` Jani Nikula 2024-03-04 10:32 ` Thomas Zimmermann 2024-03-04 10:32 ` Thomas Zimmermann 2024-03-04 10:40 ` Thomas Zimmermann 2024-03-04 10:40 ` Thomas Zimmermann 2024-03-04 18:13 ` Christophe Leroy 2024-03-04 18:13 ` Christophe Leroy 2024-03-05 0:36 ` Michael Ellerman 2024-03-05 0:36 ` Michael Ellerman 2024-03-05 8:09 ` Thomas Zimmermann 2024-03-05 8:09 ` Thomas Zimmermann
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20240304095512.742348-1-jani.nikula@intel.com \ --to=jani.nikula@intel.com \ --cc=deller@gmx.de \ --cc=dri-devel@lists.freedesktop.org \ --cc=linux-fbdev@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linuxppc-dev@lists.ozlabs.org \ --cc=lkft-triage@lists.linaro.org \ --cc=mpe@ellerman.id.au \ --cc=naresh.kamboju@linaro.org \ --cc=tzimmermann@suse.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.