From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Lee Jones <lee@kernel.org>,
Daniel Thompson <daniel.thompson@linaro.org>,
Jingoo Han <jingoohan1@gmail.com>, Helge Deller <deller@gmx.de>
Cc: dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Subject: [PATCH v2 5/7] backlight: lm3630a_bl: Handle deferred probe
Date: Tue, 05 Mar 2024 09:12:00 +0100 [thread overview]
Message-ID: <20240305-backlight-probe-v2-5-609b0cf24bde@linaro.org> (raw)
In-Reply-To: <20240305-backlight-probe-v2-0-609b0cf24bde@linaro.org>
Don't pollute dmesg on deferred probe and simplify the code with
dev_err_probe().
Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
drivers/video/backlight/lm3630a_bl.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/video/backlight/lm3630a_bl.c b/drivers/video/backlight/lm3630a_bl.c
index a3412c936ca2..93fd6dbccc28 100644
--- a/drivers/video/backlight/lm3630a_bl.c
+++ b/drivers/video/backlight/lm3630a_bl.c
@@ -563,10 +563,9 @@ static int lm3630a_probe(struct i2c_client *client)
/* pwm */
if (pdata->pwm_ctrl != LM3630A_PWM_DISABLE) {
pchip->pwmd = devm_pwm_get(pchip->dev, "lm3630a-pwm");
- if (IS_ERR(pchip->pwmd)) {
- dev_err(&client->dev, "fail : get pwm device\n");
- return PTR_ERR(pchip->pwmd);
- }
+ if (IS_ERR(pchip->pwmd))
+ return dev_err_probe(&client->dev, PTR_ERR(pchip->pwmd),
+ "fail : get pwm device\n");
pwm_init_state(pchip->pwmd, &pchip->pwmd_state);
}
--
2.34.1
next prev parent reply other threads:[~2024-03-05 8:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-05 8:11 [PATCH v2 0/7] backlight: Simplify probe in few drivers Krzysztof Kozlowski
2024-03-05 8:11 ` [PATCH v2 1/7] backlight: gpio: Simplify with dev_err_probe() Krzysztof Kozlowski
2024-03-05 9:05 ` Daniel Thompson
2024-03-05 8:11 ` [PATCH v2 2/7] backlight: l4f00242t03: " Krzysztof Kozlowski
2024-03-05 8:11 ` [PATCH v2 3/7] backlight: bd6107: Handle deferred probe Krzysztof Kozlowski
2024-03-05 8:11 ` [PATCH v2 4/7] backlight: as3711_bl: " Krzysztof Kozlowski
2024-03-05 8:12 ` Krzysztof Kozlowski [this message]
2024-03-05 8:12 ` [PATCH v2 6/7] backlight: lm3630a_bl: Simplify probe return on gpio request error Krzysztof Kozlowski
2024-03-05 8:12 ` [PATCH v2 7/7] backlight: pandora_bl: Drop unneeded ENOMEM error message Krzysztof Kozlowski
2024-03-05 10:04 ` [PATCH v2 0/7] backlight: Simplify probe in few drivers Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240305-backlight-probe-v2-5-609b0cf24bde@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=daniel.thompson@linaro.org \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=jingoohan1@gmail.com \
--cc=lee@kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.