All of lore.kernel.org
 help / color / mirror / Atom feed
From: Linus Walleij <linus.walleij@linaro.org>
To: AngeloGioacchino Del Regno
	<angelogioacchino.delregno@somainline.org>,
	 David Bauer <mail@david-bauer.net>,
	 Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	 Geert Uytterhoeven <geert@linux-m68k.org>
Cc: linux-gpio@vger.kernel.org, kernel test robot <lkp@intel.com>,
	 Linus Walleij <linus.walleij@linaro.org>
Subject: [PATCH v2] pinctrl: aw9523: Make the driver tristate
Date: Tue, 05 Mar 2024 12:00:03 +0100	[thread overview]
Message-ID: <20240305-fix-aw9523-v2-1-2dc50bab2b17@linaro.org> (raw)

The AW9523 driver fails to build in some allmod configs since the
I2C core can be a module, but AW9523 can not. Fix it up by allowing
AW9523 to be a module (tristate).

Fixes: a4f15a8d4c82 ("pinctrl: Add driver for Awinic AW9523/B I2C GPIO Expander")
Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202403050916.KBtE6eEj-lkp@intel.com/
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
Changes in v2:
- Instead of restricting to bool and I2C=y, just allow the
  driver to be tristate (which was probably the intention).
- Link to v1: https://lore.kernel.org/r/20240305-fix-aw9523-v1-1-97205563645b@linaro.org
---
 drivers/pinctrl/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
index 21d38bf2d1ca..d45657aa986a 100644
--- a/drivers/pinctrl/Kconfig
+++ b/drivers/pinctrl/Kconfig
@@ -128,7 +128,7 @@ config PINCTRL_AXP209
 	  Say Y to enable pinctrl and GPIO support for the AXP209 PMIC.
 
 config PINCTRL_AW9523
-	bool "Awinic AW9523/AW9523B I2C GPIO expander pinctrl driver"
+	tristate "Awinic AW9523/AW9523B I2C GPIO expander pinctrl driver"
 	depends on OF && I2C
 	select PINMUX
 	select PINCONF

---
base-commit: a4f15a8d4c8253d44830731d99be869d273c0c82
change-id: 20240305-fix-aw9523-4006b88f7b55

Best regards,
-- 
Linus Walleij <linus.walleij@linaro.org>


                 reply	other threads:[~2024-03-05 11:00 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240305-fix-aw9523-v2-1-2dc50bab2b17@linaro.org \
    --to=linus.walleij@linaro.org \
    --cc=angelogioacchino.delregno@somainline.org \
    --cc=geert@linux-m68k.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=mail@david-bauer.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.