From: Guenter Roeck <linux@roeck-us.net> To: linux-kselftest@vger.kernel.org Cc: "David Airlie" <airlied@gmail.com>, "Arnd Bergmann" <arnd@arndb.de>, "Maíra Canal" <mcanal@igalia.com>, "Dan Carpenter" <dan.carpenter@linaro.org>, "Kees Cook" <keescook@chromium.org>, "Daniel Diaz" <daniel.diaz@linaro.org>, "David Gow" <davidgow@google.com>, "Arthur Grillo" <arthurgrillo@riseup.net>, "Brendan Higgins" <brendan.higgins@linux.dev>, "Naresh Kamboju" <naresh.kamboju@linaro.org>, "Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>, "Andrew Morton" <akpm@linux-foundation.org>, "Maxime Ripard" <mripard@kernel.org>, "Ville Syrjälä" <ville.syrjala@linux.intel.com>, "Daniel Vetter" <daniel@ffwll.ch>, "Thomas Zimmermann" <tzimmermann@suse.de>, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, loongarch@lists.linux.dev, linux-arm-kernel@lists.infradead.org, kunit-dev@googlegroups.com, linux-arch@vger.kernel.org, "Guenter Roeck" <linux@roeck-us.net> Subject: [RFC PATCH 2/5] drm: Suppress intentional warning backtraces in scaling unit tests Date: Tue, 5 Mar 2024 10:40:30 -0800 [thread overview] Message-ID: <20240305184033.425294-3-linux@roeck-us.net> (raw) In-Reply-To: <20240305184033.425294-1-linux@roeck-us.net> The drm_test_rect_calc_hscale and drm_test_rect_calc_vscale unit tests intentionally trigger warning backtraces by providing bad parameters to the tested functions. What is tested is the return value, not the existence of a warning backtrace. Suppress the backtraces to avoid clogging the kernel log. Signed-off-by: Guenter Roeck <linux@roeck-us.net> --- drivers/gpu/drm/tests/drm_rect_test.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/tests/drm_rect_test.c b/drivers/gpu/drm/tests/drm_rect_test.c index 76332cd2ead8..75614cb4deb5 100644 --- a/drivers/gpu/drm/tests/drm_rect_test.c +++ b/drivers/gpu/drm/tests/drm_rect_test.c @@ -406,22 +406,28 @@ KUNIT_ARRAY_PARAM(drm_rect_scale, drm_rect_scale_cases, drm_rect_scale_case_desc static void drm_test_rect_calc_hscale(struct kunit *test) { + DEFINE_SUPPRESSED_WARNING(drm_calc_scale); const struct drm_rect_scale_case *params = test->param_value; int scaling_factor; + START_SUPPRESSED_WARNING(drm_calc_scale); scaling_factor = drm_rect_calc_hscale(¶ms->src, ¶ms->dst, params->min_range, params->max_range); + END_SUPPRESSED_WARNING(drm_calc_scale); KUNIT_EXPECT_EQ(test, scaling_factor, params->expected_scaling_factor); } static void drm_test_rect_calc_vscale(struct kunit *test) { + DEFINE_SUPPRESSED_WARNING(drm_calc_scale); const struct drm_rect_scale_case *params = test->param_value; int scaling_factor; + START_SUPPRESSED_WARNING(drm_calc_scale); scaling_factor = drm_rect_calc_vscale(¶ms->src, ¶ms->dst, params->min_range, params->max_range); + END_SUPPRESSED_WARNING(drm_calc_scale); KUNIT_EXPECT_EQ(test, scaling_factor, params->expected_scaling_factor); } -- 2.39.2
WARNING: multiple messages have this Message-ID (diff)
From: Guenter Roeck <linux@roeck-us.net> To: linux-kselftest@vger.kernel.org Cc: "David Airlie" <airlied@gmail.com>, "Arnd Bergmann" <arnd@arndb.de>, "Maíra Canal" <mcanal@igalia.com>, "Dan Carpenter" <dan.carpenter@linaro.org>, "Kees Cook" <keescook@chromium.org>, "Daniel Diaz" <daniel.diaz@linaro.org>, "David Gow" <davidgow@google.com>, "Arthur Grillo" <arthurgrillo@riseup.net>, "Brendan Higgins" <brendan.higgins@linux.dev>, "Naresh Kamboju" <naresh.kamboju@linaro.org>, "Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>, "Andrew Morton" <akpm@linux-foundation.org>, "Maxime Ripard" <mripard@kernel.org>, "Ville Syrjälä" <ville.syrjala@linux.intel.com>, "Daniel Vetter" <daniel@ffwll.ch>, "Thomas Zimmermann" <tzimmermann@suse.de>, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, loongarch@lists.linux.dev, linux-arm-kernel@lists.infradead.org, kunit-dev@googlegroups.com, linux-arch@vger.kernel.org, "Guenter Roeck" <linux@roeck-us.net> Subject: [RFC PATCH 2/5] drm: Suppress intentional warning backtraces in scaling unit tests Date: Tue, 5 Mar 2024 10:40:30 -0800 [thread overview] Message-ID: <20240305184033.425294-3-linux@roeck-us.net> (raw) In-Reply-To: <20240305184033.425294-1-linux@roeck-us.net> The drm_test_rect_calc_hscale and drm_test_rect_calc_vscale unit tests intentionally trigger warning backtraces by providing bad parameters to the tested functions. What is tested is the return value, not the existence of a warning backtrace. Suppress the backtraces to avoid clogging the kernel log. Signed-off-by: Guenter Roeck <linux@roeck-us.net> --- drivers/gpu/drm/tests/drm_rect_test.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/tests/drm_rect_test.c b/drivers/gpu/drm/tests/drm_rect_test.c index 76332cd2ead8..75614cb4deb5 100644 --- a/drivers/gpu/drm/tests/drm_rect_test.c +++ b/drivers/gpu/drm/tests/drm_rect_test.c @@ -406,22 +406,28 @@ KUNIT_ARRAY_PARAM(drm_rect_scale, drm_rect_scale_cases, drm_rect_scale_case_desc static void drm_test_rect_calc_hscale(struct kunit *test) { + DEFINE_SUPPRESSED_WARNING(drm_calc_scale); const struct drm_rect_scale_case *params = test->param_value; int scaling_factor; + START_SUPPRESSED_WARNING(drm_calc_scale); scaling_factor = drm_rect_calc_hscale(¶ms->src, ¶ms->dst, params->min_range, params->max_range); + END_SUPPRESSED_WARNING(drm_calc_scale); KUNIT_EXPECT_EQ(test, scaling_factor, params->expected_scaling_factor); } static void drm_test_rect_calc_vscale(struct kunit *test) { + DEFINE_SUPPRESSED_WARNING(drm_calc_scale); const struct drm_rect_scale_case *params = test->param_value; int scaling_factor; + START_SUPPRESSED_WARNING(drm_calc_scale); scaling_factor = drm_rect_calc_vscale(¶ms->src, ¶ms->dst, params->min_range, params->max_range); + END_SUPPRESSED_WARNING(drm_calc_scale); KUNIT_EXPECT_EQ(test, scaling_factor, params->expected_scaling_factor); } -- 2.39.2 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-03-05 18:40 UTC|newest] Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top 2024-03-05 18:40 [RFC PATCH 0/5] Add support for suppressing warning backtraces Guenter Roeck 2024-03-05 18:40 ` Guenter Roeck 2024-03-05 18:40 ` [RFC PATCH 1/5] bug: Core " Guenter Roeck 2024-03-05 18:40 ` Guenter Roeck 2024-03-05 19:54 ` Kees Cook 2024-03-05 19:54 ` Kees Cook 2024-03-05 20:17 ` Guenter Roeck 2024-03-05 20:17 ` Guenter Roeck 2024-03-05 18:40 ` Guenter Roeck [this message] 2024-03-05 18:40 ` [RFC PATCH 2/5] drm: Suppress intentional warning backtraces in scaling unit tests Guenter Roeck 2024-03-05 18:40 ` [RFC PATCH 3/5] x86: Add support for suppressing warning tracebacks Guenter Roeck 2024-03-05 18:40 ` Guenter Roeck 2024-03-05 18:40 ` [RFC PATCH 4/5] arm64: " Guenter Roeck 2024-03-05 18:40 ` Guenter Roeck 2024-03-05 18:40 ` [RFC PATCH 5/5] loongarch: " Guenter Roeck 2024-03-05 18:40 ` Guenter Roeck 2024-03-06 18:24 ` [RFC PATCH 0/5] Add support for suppressing warning backtraces Daniel Díaz 2024-03-06 18:24 ` Daniel Díaz 2024-03-06 18:57 ` Guenter Roeck 2024-03-06 18:57 ` Guenter Roeck 2024-03-11 4:36 ` Guenter Roeck 2024-03-11 4:36 ` Guenter Roeck
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20240305184033.425294-3-linux@roeck-us.net \ --to=linux@roeck-us.net \ --cc=airlied@gmail.com \ --cc=akpm@linux-foundation.org \ --cc=arnd@arndb.de \ --cc=arthurgrillo@riseup.net \ --cc=brendan.higgins@linux.dev \ --cc=dan.carpenter@linaro.org \ --cc=daniel.diaz@linaro.org \ --cc=daniel@ffwll.ch \ --cc=davidgow@google.com \ --cc=dri-devel@lists.freedesktop.org \ --cc=keescook@chromium.org \ --cc=kunit-dev@googlegroups.com \ --cc=linux-arch@vger.kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-kselftest@vger.kernel.org \ --cc=loongarch@lists.linux.dev \ --cc=maarten.lankhorst@linux.intel.com \ --cc=mcanal@igalia.com \ --cc=mripard@kernel.org \ --cc=naresh.kamboju@linaro.org \ --cc=tzimmermann@suse.de \ --cc=ville.syrjala@linux.intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.