All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Jouni Högander" <jouni.hogander@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: "Ville Syrjälä" <ville.syrjala@linux.intel.com>,
	"Jani Nikula" <jani.nikula@linux.intel.com>,
	"Jouni Högander" <jouni.hogander@intel.com>
Subject: [PATCH v4 4/5] drm/i915/psr: Add IO buffer wake times for LunarLake and beyond
Date: Wed,  6 Mar 2024 10:34:26 +0200	[thread overview]
Message-ID: <20240306083427.2040475-5-jouni.hogander@intel.com> (raw)
In-Reply-To: <20240306083427.2040475-1-jouni.hogander@intel.com>

IO buffer wake time used for IO wake calculation is dependent on port clock
on LunarLake and beyond. Take this into account in get_io_buffer_wake_time.

Bspec: 65450

Signed-off-by: Jouni Högander <jouni.hogander@intel.com>
---
 drivers/gpu/drm/i915/display/intel_psr.c | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/display/intel_psr.c b/drivers/gpu/drm/i915/display/intel_psr.c
index e1df0ece9fa3..e8410e770da8 100644
--- a/drivers/gpu/drm/i915/display/intel_psr.c
+++ b/drivers/gpu/drm/i915/display/intel_psr.c
@@ -1160,6 +1160,9 @@ static bool _lnl_compute_alpm_params(struct intel_dp *intel_dp,
  * This is not directly mentioned in Bspec. There are 50 us io wake time and 32
  * us fast wake time. Clearly preharge pulses are not (improperly) included in
  * 32 us fast wake time. 50 us - 32 us = 18 us.
+ *
+ * For DISPLAY_VER >= 20
+ * RBR 15us, HBR1 11us, higher rates 10us
  */
 static int get_io_buffer_wake_time(const struct intel_crtc_state *crtc_state)
 {
@@ -1167,8 +1170,12 @@ static int get_io_buffer_wake_time(const struct intel_crtc_state *crtc_state)
 
 	if (DISPLAY_VER(i915) < 12)
 		return 18;
-	else
+	else if (DISPLAY_VER(i915) < 20 || crtc_state->port_clock > 270000)
 		return 10;
+	else if (crtc_state->port_clock > 162000)
+		return 11;
+	else
+		return 15;
 }
 
 static bool _compute_alpm_params(struct intel_dp *intel_dp,
-- 
2.34.1


  parent reply	other threads:[~2024-03-06  8:35 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-06  8:34 [PATCH v4 0/5] IO and fast wake lines calculation and increase fw sync length Jouni Högander
2024-03-06  8:34 ` [PATCH v4 1/5] drm/i915/display: Make intel_dp_aux_fw_sync_len available for PSR code Jouni Högander
2024-03-06  8:34 ` [PATCH v4 2/5] drm/i915/psr: Improve fast and IO wake lines calculation Jouni Högander
2024-03-06  8:34 ` [PATCH v4 3/5] drm/i915/psr: Calculate IO wake and fast wake lines for DISPLAY_VER < 12 Jouni Högander
2024-03-07 17:16   ` Ville Syrjälä
2024-03-08  8:28     ` Hogander, Jouni
2024-03-06  8:34 ` Jouni Högander [this message]
2024-03-07 17:15   ` [PATCH v4 4/5] drm/i915/psr: Add IO buffer wake times for LunarLake and beyond Ville Syrjälä
2024-03-08  8:39     ` Hogander, Jouni
2024-03-08 10:11       ` Ville Syrjälä
2024-03-08 11:01         ` Hogander, Jouni
2024-03-06  8:34 ` [PATCH v4 5/5] drm/i915/display: Increase number of fast wake precharge pulses Jouni Högander
2024-03-06 18:18 ` ✗ Fi.CI.SPARSE: warning for IO and fast wake lines calculation and increase fw sync length (rev4) Patchwork
2024-03-06 18:32 ` ✓ Fi.CI.BAT: success " Patchwork
2024-03-07 14:47 ` ✗ Fi.CI.IGT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240306083427.2040475-5-jouni.hogander@intel.com \
    --to=jouni.hogander@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jani.nikula@linux.intel.com \
    --cc=ville.syrjala@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.