From: Stefan Berger <stefanb@linux.ibm.com> To: mpe@ellerman.id.au, linux-integrity@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Cc: linux-kernel@vger.kernel.org, jarkko@kernel.org, rnsastry@linux.ibm.com, peterhuewe@gmx.de, viparash@in.ibm.com, Stefan Berger <stefanb@linux.ibm.com> Subject: [PATCH 1/2] powerpc/prom_init: Replace linux,sml-base/sml-size with linux,sml-log Date: Wed, 6 Mar 2024 10:55:10 -0500 [thread overview] Message-ID: <20240306155511.974517-2-stefanb@linux.ibm.com> (raw) In-Reply-To: <20240306155511.974517-1-stefanb@linux.ibm.com> linux,sml-base holds the address of a buffer with the TPM log. This buffer may become invalid after a kexec and therefore embed the whole TPM log in linux,sml-log. This helps to protect the log since it is properly carried across a kexec with both of the kexec syscalls. Signed-off-by: Stefan Berger <stefanb@linux.ibm.com> --- arch/powerpc/kernel/prom_init.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/arch/powerpc/kernel/prom_init.c b/arch/powerpc/kernel/prom_init.c index e67effdba85c..41268c30de4c 100644 --- a/arch/powerpc/kernel/prom_init.c +++ b/arch/powerpc/kernel/prom_init.c @@ -1956,12 +1956,8 @@ static void __init prom_instantiate_sml(void) reserve_mem(base, size); - prom_setprop(ibmvtpm_node, "/vdevice/vtpm", "linux,sml-base", - &base, sizeof(base)); - prom_setprop(ibmvtpm_node, "/vdevice/vtpm", "linux,sml-size", - &size, sizeof(size)); - - prom_debug("sml base = 0x%llx\n", base); + prom_setprop(ibmvtpm_node, "/vdevice/vtpm", "linux,sml-log", + (void *)base, size); prom_debug("sml size = 0x%x\n", size); prom_debug("prom_instantiate_sml: end...\n"); -- 2.43.0
WARNING: multiple messages have this Message-ID (diff)
From: Stefan Berger <stefanb@linux.ibm.com> To: mpe@ellerman.id.au, linux-integrity@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Cc: rnsastry@linux.ibm.com, linux-kernel@vger.kernel.org, jarkko@kernel.org, peterhuewe@gmx.de, viparash@in.ibm.com, Stefan Berger <stefanb@linux.ibm.com> Subject: [PATCH 1/2] powerpc/prom_init: Replace linux,sml-base/sml-size with linux,sml-log Date: Wed, 6 Mar 2024 10:55:10 -0500 [thread overview] Message-ID: <20240306155511.974517-2-stefanb@linux.ibm.com> (raw) In-Reply-To: <20240306155511.974517-1-stefanb@linux.ibm.com> linux,sml-base holds the address of a buffer with the TPM log. This buffer may become invalid after a kexec and therefore embed the whole TPM log in linux,sml-log. This helps to protect the log since it is properly carried across a kexec with both of the kexec syscalls. Signed-off-by: Stefan Berger <stefanb@linux.ibm.com> --- arch/powerpc/kernel/prom_init.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/arch/powerpc/kernel/prom_init.c b/arch/powerpc/kernel/prom_init.c index e67effdba85c..41268c30de4c 100644 --- a/arch/powerpc/kernel/prom_init.c +++ b/arch/powerpc/kernel/prom_init.c @@ -1956,12 +1956,8 @@ static void __init prom_instantiate_sml(void) reserve_mem(base, size); - prom_setprop(ibmvtpm_node, "/vdevice/vtpm", "linux,sml-base", - &base, sizeof(base)); - prom_setprop(ibmvtpm_node, "/vdevice/vtpm", "linux,sml-size", - &size, sizeof(size)); - - prom_debug("sml base = 0x%llx\n", base); + prom_setprop(ibmvtpm_node, "/vdevice/vtpm", "linux,sml-log", + (void *)base, size); prom_debug("sml size = 0x%x\n", size); prom_debug("prom_instantiate_sml: end...\n"); -- 2.43.0
next prev parent reply other threads:[~2024-03-06 15:55 UTC|newest] Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top 2024-03-06 15:55 [PATCH 0/2] Preserve TPM log across kexec Stefan Berger 2024-03-06 15:55 ` Stefan Berger 2024-03-06 15:55 ` Stefan Berger [this message] 2024-03-06 15:55 ` [PATCH 1/2] powerpc/prom_init: Replace linux,sml-base/sml-size with linux,sml-log Stefan Berger 2024-03-07 10:41 ` Michael Ellerman 2024-03-07 10:41 ` Michael Ellerman 2024-03-07 15:11 ` Stefan Berger 2024-03-07 15:11 ` Stefan Berger 2024-03-07 20:39 ` Conor Dooley 2024-03-07 20:39 ` Conor Dooley 2024-03-07 21:15 ` Stefan Berger 2024-03-07 21:15 ` Stefan Berger 2024-03-07 21:29 ` Conor Dooley 2024-03-07 21:29 ` Conor Dooley 2024-03-07 21:52 ` Rob Herring 2024-03-07 21:52 ` Rob Herring 2024-03-08 12:23 ` Stefan Berger 2024-03-08 12:23 ` Stefan Berger 2024-03-08 20:57 ` Rob Herring 2024-03-08 20:57 ` Rob Herring 2024-03-08 21:26 ` Stefan Berger 2024-03-08 21:26 ` Stefan Berger 2024-03-12 10:32 ` Michael Ellerman 2024-03-12 10:32 ` Michael Ellerman 2024-03-12 16:22 ` Rob Herring 2024-03-12 16:22 ` Rob Herring 2024-03-12 19:15 ` Stefan Berger 2024-03-12 19:15 ` Stefan Berger 2024-03-07 20:11 ` Jarkko Sakkinen 2024-03-07 20:11 ` Jarkko Sakkinen 2024-03-06 15:55 ` [PATCH 2/2] tpm: of: If available Use linux,sml-log to get the log and its size Stefan Berger 2024-03-06 15:55 ` Stefan Berger 2024-03-07 10:42 ` Michael Ellerman 2024-03-07 10:42 ` Michael Ellerman 2024-03-07 15:00 ` Stefan Berger 2024-03-07 15:00 ` Stefan Berger 2024-03-07 11:35 ` Conor Dooley 2024-03-07 11:35 ` Conor Dooley 2024-03-07 19:57 ` Jarkko Sakkinen 2024-03-07 19:57 ` Jarkko Sakkinen 2024-03-07 20:00 ` Jarkko Sakkinen 2024-03-07 20:00 ` Jarkko Sakkinen 2024-03-08 12:17 ` Stefan Berger 2024-03-08 12:17 ` Stefan Berger 2024-03-11 20:09 ` Jarkko Sakkinen 2024-03-11 20:09 ` Jarkko Sakkinen 2024-03-12 10:35 ` Michael Ellerman 2024-03-12 10:35 ` Michael Ellerman 2024-03-12 15:50 ` Jarkko Sakkinen 2024-03-12 15:50 ` Jarkko Sakkinen 2024-03-12 19:08 ` Stefan Berger 2024-03-12 19:08 ` Stefan Berger 2024-03-06 16:08 ` [PATCH 0/2] Preserve TPM log across kexec Stefan Berger 2024-03-06 16:08 ` Stefan Berger 2024-03-07 21:42 ` Rob Herring 2024-03-07 21:42 ` Rob Herring 2024-03-07 22:32 ` Stefan Berger 2024-03-07 22:32 ` Stefan Berger
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20240306155511.974517-2-stefanb@linux.ibm.com \ --to=stefanb@linux.ibm.com \ --cc=jarkko@kernel.org \ --cc=linux-integrity@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linuxppc-dev@lists.ozlabs.org \ --cc=mpe@ellerman.id.au \ --cc=peterhuewe@gmx.de \ --cc=rnsastry@linux.ibm.com \ --cc=viparash@in.ibm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.