From: Fabrice Gasnier <fabrice.gasnier@foss.st.com> To: <william.gray@linaro.org> Cc: <lee@kernel.org>, <alexandre.torgue@foss.st.com>, <fabrice.gasnier@foss.st.com>, <linux-iio@vger.kernel.org>, <linux-stm32@st-md-mailman.stormreply.com>, <linux-arm-kernel@lists.infradead.org>, <linux-kernel@vger.kernel.org> Subject: [PATCH v5 01/10] counter: stm32-timer-cnt: rename quadrature signal Date: Thu, 7 Mar 2024 14:32:57 +0100 [thread overview] Message-ID: <20240307133306.383045-2-fabrice.gasnier@foss.st.com> (raw) In-Reply-To: <20240307133306.383045-1-fabrice.gasnier@foss.st.com> Drop the Quadrature convention in the signal name. On stm32-timer: - Quadrature A signal corresponds to timer input ch1, hence "Channel 1" - Quadrature B signal corresponds to timer input ch2, hence "Channel 2". So name these signals after their channel. I suspect it referred to the (unique) quadrature counter support earlier, but the physical input really is CH1/CH2. This will be easier to support other counter modes. Reviewed-by: William Breathitt Gray <william.gray@linaro.org> Signed-off-by: Fabrice Gasnier <fabrice.gasnier@foss.st.com> --- Changes in v4: - Add William's Reviewed-by tag Changes in v2: - Drop the "Quadrature" convention from the signal name, as suggested by William --- drivers/counter/stm32-timer-cnt.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/counter/stm32-timer-cnt.c b/drivers/counter/stm32-timer-cnt.c index 6206d2dc3d47..36d812ddf162 100644 --- a/drivers/counter/stm32-timer-cnt.c +++ b/drivers/counter/stm32-timer-cnt.c @@ -279,11 +279,11 @@ static const struct counter_ops stm32_timer_cnt_ops = { static struct counter_signal stm32_signals[] = { { .id = 0, - .name = "Channel 1 Quadrature A" + .name = "Channel 1" }, { .id = 1, - .name = "Channel 1 Quadrature B" + .name = "Channel 2" } }; -- 2.25.1
WARNING: multiple messages have this Message-ID (diff)
From: Fabrice Gasnier <fabrice.gasnier@foss.st.com> To: <william.gray@linaro.org> Cc: <lee@kernel.org>, <alexandre.torgue@foss.st.com>, <fabrice.gasnier@foss.st.com>, <linux-iio@vger.kernel.org>, <linux-stm32@st-md-mailman.stormreply.com>, <linux-arm-kernel@lists.infradead.org>, <linux-kernel@vger.kernel.org> Subject: [PATCH v5 01/10] counter: stm32-timer-cnt: rename quadrature signal Date: Thu, 7 Mar 2024 14:32:57 +0100 [thread overview] Message-ID: <20240307133306.383045-2-fabrice.gasnier@foss.st.com> (raw) In-Reply-To: <20240307133306.383045-1-fabrice.gasnier@foss.st.com> Drop the Quadrature convention in the signal name. On stm32-timer: - Quadrature A signal corresponds to timer input ch1, hence "Channel 1" - Quadrature B signal corresponds to timer input ch2, hence "Channel 2". So name these signals after their channel. I suspect it referred to the (unique) quadrature counter support earlier, but the physical input really is CH1/CH2. This will be easier to support other counter modes. Reviewed-by: William Breathitt Gray <william.gray@linaro.org> Signed-off-by: Fabrice Gasnier <fabrice.gasnier@foss.st.com> --- Changes in v4: - Add William's Reviewed-by tag Changes in v2: - Drop the "Quadrature" convention from the signal name, as suggested by William --- drivers/counter/stm32-timer-cnt.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/counter/stm32-timer-cnt.c b/drivers/counter/stm32-timer-cnt.c index 6206d2dc3d47..36d812ddf162 100644 --- a/drivers/counter/stm32-timer-cnt.c +++ b/drivers/counter/stm32-timer-cnt.c @@ -279,11 +279,11 @@ static const struct counter_ops stm32_timer_cnt_ops = { static struct counter_signal stm32_signals[] = { { .id = 0, - .name = "Channel 1 Quadrature A" + .name = "Channel 1" }, { .id = 1, - .name = "Channel 1 Quadrature B" + .name = "Channel 2" } }; -- 2.25.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-03-07 13:34 UTC|newest] Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top 2024-03-07 13:32 [PATCH v5 00/10] counter: Add stm32 timer events support Fabrice Gasnier 2024-03-07 13:32 ` Fabrice Gasnier 2024-03-07 13:32 ` Fabrice Gasnier [this message] 2024-03-07 13:32 ` [PATCH v5 01/10] counter: stm32-timer-cnt: rename quadrature signal Fabrice Gasnier 2024-03-07 13:32 ` [PATCH v5 02/10] counter: stm32-timer-cnt: rename counter Fabrice Gasnier 2024-03-07 13:32 ` Fabrice Gasnier 2024-03-07 13:32 ` [PATCH v5 03/10] counter: stm32-timer-cnt: adopt signal definitions Fabrice Gasnier 2024-03-07 13:32 ` Fabrice Gasnier 2024-03-07 13:33 ` [PATCH v5 04/10] counter: stm32-timer-cnt: introduce clock signal Fabrice Gasnier 2024-03-07 13:33 ` Fabrice Gasnier 2024-03-07 13:33 ` [PATCH v5 05/10] counter: stm32-timer-cnt: add counter prescaler extension Fabrice Gasnier 2024-03-07 13:33 ` Fabrice Gasnier 2024-03-07 13:33 ` [PATCH v5 06/10] counter: stm32-timer-cnt: add checks on quadrature encoder capability Fabrice Gasnier 2024-03-07 13:33 ` Fabrice Gasnier 2024-03-07 13:33 ` [PATCH v5 07/10] counter: stm32-timer-cnt: introduce channels Fabrice Gasnier 2024-03-07 13:33 ` Fabrice Gasnier 2024-03-07 13:33 ` [PATCH v5 08/10] counter: stm32-timer-cnt: probe number of channels from registers Fabrice Gasnier 2024-03-07 13:33 ` Fabrice Gasnier 2024-03-07 13:33 ` [PATCH v5 09/10] counter: stm32-timer-cnt: add support for overflow events Fabrice Gasnier 2024-03-07 13:33 ` Fabrice Gasnier 2024-03-07 13:33 ` [PATCH v5 10/10] counter: stm32-timer-cnt: add support for capture events Fabrice Gasnier 2024-03-07 13:33 ` Fabrice Gasnier 2024-03-07 16:09 ` [PATCH v5 00/10] counter: Add stm32 timer events support William Breathitt Gray 2024-03-07 16:09 ` William Breathitt Gray
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20240307133306.383045-2-fabrice.gasnier@foss.st.com \ --to=fabrice.gasnier@foss.st.com \ --cc=alexandre.torgue@foss.st.com \ --cc=lee@kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-iio@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-stm32@st-md-mailman.stormreply.com \ --cc=william.gray@linaro.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.