All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: Mark Kanda <mark.kanda@oracle.com>
Subject: [PULL 6/9] oslib-posix: fix memory leak in touch_all_pages
Date: Fri,  8 Mar 2024 19:11:58 +0100	[thread overview]
Message-ID: <20240308181202.617329-7-pbonzini@redhat.com> (raw)
In-Reply-To: <20240308181202.617329-1-pbonzini@redhat.com>

touch_all_pages() can return early, before creating threads.  In this case,
however, it leaks the MemsetContext that it has allocated at the
beginning of the function.

Reported by Coverity as CID 1534922.

Fixes: 04accf43df8 ("oslib-posix: initialize backend memory objects in parallel", 2024-02-06)
Reviewed-by: Mark Kanda <mark.kanda@oracle.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 util/oslib-posix.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/util/oslib-posix.c b/util/oslib-posix.c
index 3c379f96c26..e76441695bd 100644
--- a/util/oslib-posix.c
+++ b/util/oslib-posix.c
@@ -467,11 +467,13 @@ static int touch_all_pages(char *area, size_t hpagesize, size_t numpages,
          * preallocating synchronously.
          */
         if (context->num_threads == 1 && !async) {
+            ret = 0;
             if (qemu_madvise(area, hpagesize * numpages,
                              QEMU_MADV_POPULATE_WRITE)) {
-                return -errno;
+                ret = -errno;
             }
-            return 0;
+            g_free(context);
+            return ret;
         }
         touch_fn = do_madv_populate_write_pages;
     } else {
-- 
2.43.2



  parent reply	other threads:[~2024-03-08 18:17 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-08 18:11 [PULL v2 0/9] Misc fixes and coverity CI for 2024-03-08 Paolo Bonzini
2024-03-08 18:11 ` [PULL 1/9] hw/scsi/lsi53c895a: add timer to scripts processing Paolo Bonzini
2024-03-08 18:11 ` [PULL 2/9] system/qdev-monitor: move drain_call_rcu call under if (!dev) in qmp_device_add() Paolo Bonzini
2024-03-08 18:11 ` [PULL 3/9] meson: Remove --warn-common ldflag Paolo Bonzini
2024-03-08 18:11 ` [PULL 4/9] hw/scsi/lsi53c895a: stop script on phase mismatch Paolo Bonzini
2024-03-08 18:11 ` [PULL 5/9] hw/intc/apic: fix memory leak Paolo Bonzini
2024-03-08 18:11 ` Paolo Bonzini [this message]
2024-03-08 18:11 ` [PULL 7/9] mips: do not list individual devices from configs/ Paolo Bonzini
2024-03-08 18:12 ` [PULL 8/9] run-coverity-scan: add --check-upload-only option Paolo Bonzini
2024-03-08 18:12 ` [PULL 9/9] gitlab-ci: add manual job to run Coverity Paolo Bonzini
2024-03-09 20:11 ` [PULL v2 0/9] Misc fixes and coverity CI for 2024-03-08 Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240308181202.617329-7-pbonzini@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=mark.kanda@oracle.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.