All of lore.kernel.org
 help / color / mirror / Atom feed
From: Het Gala <het.gala@nutanix.com>
To: qemu-devel@nongnu.org
Cc: marcandre.lureau@redhat.com, thuth@redhat.com,
	lvivier@redhat.com, pbonzini@redhat.com, peterx@redhat.com,
	farosas@suse.de, Het Gala <het.gala@nutanix.com>
Subject: [PATCH v6 7/8] Add multifd_tcp_plain test using list of channels instead of uri
Date: Tue, 12 Mar 2024 16:20:24 +0000	[thread overview]
Message-ID: <20240312162025.44212-8-het.gala@nutanix.com> (raw)
In-Reply-To: <20240312162025.44212-1-het.gala@nutanix.com>

Add a positive test to check multifd live migration but this time
using list of channels (restricted to 1) as the starting point
instead of simple uri string.

Signed-off-by: Het Gala <het.gala@nutanix.com>
Suggested-by: Fabiano Rosas <farosas@suse.de>
---
 tests/qtest/migration-test.c | 30 +++++++++++++++++++++++++++---
 1 file changed, 27 insertions(+), 3 deletions(-)

diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c
index bf27766eb0..392d5d0b62 100644
--- a/tests/qtest/migration-test.c
+++ b/tests/qtest/migration-test.c
@@ -655,6 +655,13 @@ typedef struct {
      */
     const char *connect_uri;
 
+    /*
+     * Optional: JSON-formatted list of src QEMU URIs. If a port is
+     * defined as '0' in any QDict key a value of '0' will be
+     * automatically converted to the correct destination port.
+     */
+    const char *connect_channels;
+
     /* Optional: callback to run at start to set migration parameters */
     TestMigrateStartHook start_hook;
     /* Optional: callback to run at finish to cleanup */
@@ -2740,7 +2747,7 @@ test_migrate_precopy_tcp_multifd_zstd_start(QTestState *from,
 }
 #endif /* CONFIG_ZSTD */
 
-static void test_multifd_tcp_none(void)
+static void test_multifd_tcp_uri_none(void)
 {
     MigrateCommon args = {
         .listen_uri = "defer",
@@ -2755,6 +2762,21 @@ static void test_multifd_tcp_none(void)
     test_precopy_common(&args);
 }
 
+static void test_multifd_tcp_channels_none(void)
+{
+    MigrateCommon args = {
+        .listen_uri = "defer",
+        .start_hook = test_migrate_precopy_tcp_multifd_start,
+        .live = true,
+        .connect_channels = "[ { 'channel-type': 'main',"
+                            "    'addr': { 'transport': 'socket',"
+                            "              'type': 'inet',"
+                            "              'host': '127.0.0.1',"
+                            "              'port': '0' } } ]",
+    };
+    test_precopy_common(&args);
+}
+
 static void test_multifd_tcp_zlib(void)
 {
     MigrateCommon args = {
@@ -3664,8 +3686,10 @@ int main(int argc, char **argv)
                                test_migrate_dirty_limit);
         }
     }
-    migration_test_add("/migration/multifd/tcp/plain/none",
-                       test_multifd_tcp_none);
+    migration_test_add("/migration/multifd/tcp/uri/plain/none",
+                       test_multifd_tcp_uri_none);
+    migration_test_add("/migration/multifd/tcp/channels/plain/none",
+                       test_multifd_tcp_channels_none);
     migration_test_add("/migration/multifd/tcp/plain/cancel",
                        test_multifd_tcp_cancel);
     migration_test_add("/migration/multifd/tcp/plain/zlib",
-- 
2.22.3



  parent reply	other threads:[~2024-03-12 16:22 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-12 16:20 [PATCH v6 0/8] qtest: migration: Add tests for introducing 'channels' argument in migrate QAPIs Het Gala
2024-03-12 16:20 ` [PATCH v6 1/8] Add 'to' object into migrate_qmp() Het Gala
2024-03-12 16:20 ` [PATCH v6 2/8] Replace connect_uri and move migrate_get_socket_address inside migrate_qmp Het Gala
2024-03-12 18:11   ` Fabiano Rosas
2024-03-12 16:20 ` [PATCH v6 3/8] Replace migrate_get_connect_uri inplace of migrate_get_socket_address Het Gala
2024-03-12 18:47   ` Fabiano Rosas
2024-03-12 16:20 ` [PATCH v6 4/8] Add channels parameter in migrate_qmp_fail Het Gala
2024-03-12 18:45   ` Fabiano Rosas
2024-03-12 16:20 ` [PATCH v6 5/8] Add migrate_set_ports into migrate_qmp to update migration port value Het Gala
2024-03-12 18:47   ` Fabiano Rosas
2024-03-12 16:20 ` [PATCH v6 6/8] Add channels parameter in migrate_qmp Het Gala
2024-03-12 18:48   ` Fabiano Rosas
2024-03-12 16:20 ` Het Gala [this message]
2024-03-12 18:50   ` [PATCH v6 7/8] Add multifd_tcp_plain test using list of channels instead of uri Fabiano Rosas
2024-03-12 16:20 ` [PATCH v6 8/8] Add negative tests to validate migration QAPIs Het Gala
2024-03-12 18:50   ` Fabiano Rosas
2024-03-12 19:14 ` [PATCH v6 0/8] qtest: migration: Add tests for introducing 'channels' argument in migrate QAPIs Peter Xu
2024-03-12 19:45   ` Het Gala

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240312162025.44212-8-het.gala@nutanix.com \
    --to=het.gala@nutanix.com \
    --cc=farosas@suse.de \
    --cc=lvivier@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peterx@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.