All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lucas De Marchi <lucas.demarchi@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>,
	Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
	Matt Roper <matthew.d.roper@intel.com>,
	Lucas De Marchi <lucas.demarchi@intel.com>
Subject: [PATCH v2 3/6] drm/i915: Stop inheriting IP_VER(12, 50)
Date: Tue, 12 Mar 2024 16:51:42 -0700	[thread overview]
Message-ID: <20240312235145.2443975-4-lucas.demarchi@intel.com> (raw)
In-Reply-To: <20240312235145.2443975-1-lucas.demarchi@intel.com>

All the platforms that inherit the media/graphics version
from XE_HPM_FEATURES / XE_HP_FEATURES just override it to another
version. Just set the version directly in the respective struct
and remove the versions from the _FEATURES macros. Since that was the
only use for XE_HPM_FEATURES, remove it completely.

Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
---
 drivers/gpu/drm/i915/i915_pci.c | 12 ++++--------
 1 file changed, 4 insertions(+), 8 deletions(-)

diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i915_pci.c
index b318b7c6bf73..8b673fdcf178 100644
--- a/drivers/gpu/drm/i915/i915_pci.c
+++ b/drivers/gpu/drm/i915/i915_pci.c
@@ -705,8 +705,6 @@ static const struct intel_device_info adl_p_info = {
 		I915_GTT_PAGE_SIZE_2M
 
 #define XE_HP_FEATURES \
-	.__runtime.graphics.ip.ver = 12, \
-	.__runtime.graphics.ip.rel = 50, \
 	XE_HP_PAGE_SIZES, \
 	TGL_CACHELEVEL, \
 	.dma_mask_size = 46, \
@@ -730,15 +728,12 @@ static const struct intel_device_info adl_p_info = {
 	.__runtime.ppgtt_size = 48, \
 	.__runtime.ppgtt_type = INTEL_PPGTT_FULL
 
-#define XE_HPM_FEATURES \
-	.__runtime.media.ip.ver = 12, \
-	.__runtime.media.ip.rel = 50
-
 #define DG2_FEATURES \
 	XE_HP_FEATURES, \
-	XE_HPM_FEATURES, \
 	DGFX_FEATURES, \
+	.__runtime.graphics.ip.ver = 12, \
 	.__runtime.graphics.ip.rel = 55, \
+	.__runtime.media.ip.ver = 12, \
 	.__runtime.media.ip.rel = 55, \
 	PLATFORM(INTEL_DG2), \
 	.has_64k_pages = 1, \
@@ -773,9 +768,10 @@ static const struct intel_device_info ats_m_info = {
 __maybe_unused
 static const struct intel_device_info pvc_info = {
 	XE_HPC_FEATURES,
-	XE_HPM_FEATURES,
 	DGFX_FEATURES,
+	.__runtime.graphics.ip.ver = 12,
 	.__runtime.graphics.ip.rel = 60,
+	.__runtime.media.ip.ver = 12,
 	.__runtime.media.ip.rel = 60,
 	PLATFORM(INTEL_PONTEVECCHIO),
 	.has_flat_ccs = 0,
-- 
2.43.0


  parent reply	other threads:[~2024-03-12 23:51 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-12 23:51 [PATCH v2 0/6] drm/i915: cleanup dead code Lucas De Marchi
2024-03-12 23:51 ` [PATCH v2 1/6] drm/i915: Drop dead code for xehpsdv Lucas De Marchi
2024-03-12 23:51 ` [PATCH v2 2/6] drm/i915: Remove XEHP_FWRANGES() Lucas De Marchi
2024-03-14 20:49   ` Matt Roper
2024-03-12 23:51 ` Lucas De Marchi [this message]
2024-03-13  2:08   ` [PATCH v2 3/6] drm/i915: Stop inheriting IP_VER(12, 50) Gustavo Sousa
2024-03-14 20:51   ` Matt Roper
2024-03-12 23:51 ` [PATCH v2 4/6] drm/i915: Update " Lucas De Marchi
2024-03-12 23:51 ` [PATCH v2 5/6] drm/i915: Drop dead code for pvc Lucas De Marchi
2024-03-12 23:51 ` [PATCH v2 6/6] drm/i915: Remove special handling for !RCS_MASK() Lucas De Marchi
2024-03-14 20:57   ` Matt Roper
2024-03-20  5:30     ` Lucas De Marchi
2024-03-13  0:32 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915: cleanup dead code Patchwork
2024-03-13  0:32 ` ✗ Fi.CI.SPARSE: " Patchwork
2024-03-13  0:50 ` ✗ Fi.CI.BAT: failure " Patchwork
2024-03-14 19:37 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915: cleanup dead code (rev2) Patchwork
2024-03-14 19:37 ` ✗ Fi.CI.SPARSE: " Patchwork
2024-03-14 19:57 ` ✗ Fi.CI.BAT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240312235145.2443975-4-lucas.demarchi@intel.com \
    --to=lucas.demarchi@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=matthew.d.roper@intel.com \
    --cc=rodrigo.vivi@intel.com \
    --cc=tvrtko.ursulin@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.