From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
To: cip-dev@lists.cip-project.org,
Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>,
Pavel Machek <pavel@denx.de>
Cc: Biju Das <biju.das.jz@bp.renesas.com>
Subject: [PATCH 4.19.y-cip 4/9] memory: renesas-rpc-if: Return error in case devm_ioremap_resource() fails
Date: Thu, 14 Mar 2024 19:29:45 +0000 [thread overview]
Message-ID: <20240314192950.27343-5-prabhakar.mahadev-lad.rj@bp.renesas.com> (raw)
In-Reply-To: <20240314192950.27343-1-prabhakar.mahadev-lad.rj@bp.renesas.com>
commit 818fdfa89baac77a8df5a2c30f4fb798cc937aa0 upstream.
Make sure we return error in case devm_ioremap_resource() fails for dirmap
resource.
Fixes: ca7d8b980b67 ("memory: add Renesas RPC-IF driver")
Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Reviewed-by: Biju Das <biju.das.jz@bp.renesas.com>
Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Link: https://lore.kernel.org/r/20211025205631.21151-6-prabhakar.mahadev-lad.rj@bp.renesas.com
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
---
drivers/memory/renesas-rpc-if.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/memory/renesas-rpc-if.c b/drivers/memory/renesas-rpc-if.c
index 24eb3a5799c6..68b6efc0c428 100644
--- a/drivers/memory/renesas-rpc-if.c
+++ b/drivers/memory/renesas-rpc-if.c
@@ -274,7 +274,7 @@ int rpcif_sw_init(struct rpcif *rpc, struct device *dev)
res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "dirmap");
rpc->dirmap = devm_ioremap_resource(&pdev->dev, res);
if (IS_ERR(rpc->dirmap))
- rpc->dirmap = NULL;
+ return PTR_ERR(rpc->dirmap);
rpc->size = resource_size(res);
rpc->rstc = devm_reset_control_get_exclusive(&pdev->dev, NULL);
--
2.34.1
next prev parent reply other threads:[~2024-03-14 19:30 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-14 19:29 [PATCH 4.19.y-cip 0/9] Add RPC-IF support for RZ/G2{EHMN} Lad Prabhakar
2024-03-14 19:29 ` [PATCH 4.19.y-cip 1/9] memory: renesas-rpc-if: fix possible NULL pointer dereference of resource Lad Prabhakar
2024-03-14 21:09 ` Pavel Machek
2024-03-14 19:29 ` [PATCH 4.19.y-cip 2/9] memory: renesas-rpc-if: Correct QSPI data transfer in Manual mode Lad Prabhakar
2024-03-14 19:29 ` [PATCH 4.19.y-cip 3/9] memory: renesas-rpc-if: Fix HF/OSPI data transfer in Manual Mode Lad Prabhakar
2024-03-14 19:29 ` Lad Prabhakar [this message]
2024-03-14 19:29 ` [PATCH 4.19.y-cip 5/9] memory: renesas-rpc-if: Drop usage of RPCIF_DIRMAP_SIZE macro Lad Prabhakar
2024-03-14 19:29 ` [PATCH 4.19.y-cip 6/9] memory: renesas-rpc-if: Simplify single/double data register access Lad Prabhakar
2024-03-14 19:29 ` [PATCH 4.19.y-cip 7/9] memory: renesas-rpc-if: Remove redundant division of dummy Lad Prabhakar
2024-03-14 19:29 ` [PATCH 4.19.y-cip 8/9] spi: spi-rpc-if: Check return value of rpcif_sw_init() Lad Prabhakar
2024-03-14 19:29 ` [PATCH 4.19.y-cip 9/9] arm64: dts: renesas: rzg2: Add RPC-IF Support Lad Prabhakar
2024-03-14 19:48 ` [cip-dev] [PATCH 4.19.y-cip 0/9] Add RPC-IF support for RZ/G2{EHMN} Chris Paterson
2024-03-14 20:00 ` Pavel Machek
2024-03-14 21:10 ` Pavel Machek
2024-03-18 11:32 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240314192950.27343-5-prabhakar.mahadev-lad.rj@bp.renesas.com \
--to=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=cip-dev@lists.cip-project.org \
--cc=nobuhiro1.iwamatsu@toshiba.co.jp \
--cc=pavel@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.