All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
To: cip-dev@lists.cip-project.org,
	Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>,
	Pavel Machek <pavel@denx.de>
Cc: Biju Das <biju.das.jz@bp.renesas.com>
Subject: [PATCH 4.19.y-cip 8/9] spi: spi-rpc-if: Check return value of rpcif_sw_init()
Date: Thu, 14 Mar 2024 19:29:49 +0000	[thread overview]
Message-ID: <20240314192950.27343-9-prabhakar.mahadev-lad.rj@bp.renesas.com> (raw)
In-Reply-To: <20240314192950.27343-1-prabhakar.mahadev-lad.rj@bp.renesas.com>

commit 0b0a281ed7001d4c4f4c47bdc84680c4997761ca upstream.

rpcif_sw_init() can fail so make sure we check the return value
of it and on error exit rpcif_spi_probe() callback with error code.

Fixes: eb8d6d464a27 ("spi: add Renesas RPC-IF driver")
Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Reviewed-by: Biju Das <biju.das.jz@bp.renesas.com>
Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Link: https://lore.kernel.org/r/20211025205631.21151-4-prabhakar.mahadev-lad.rj@bp.renesas.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
---
 drivers/spi/spi-rpc-if.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/spi/spi-rpc-if.c b/drivers/spi/spi-rpc-if.c
index 3579675485a5..727d7cf0a6ad 100644
--- a/drivers/spi/spi-rpc-if.c
+++ b/drivers/spi/spi-rpc-if.c
@@ -139,7 +139,9 @@ static int rpcif_spi_probe(struct platform_device *pdev)
 		return -ENOMEM;
 
 	rpc = spi_controller_get_devdata(ctlr);
-	rpcif_sw_init(rpc, parent);
+	error = rpcif_sw_init(rpc, parent);
+	if (error)
+		return error;
 
 	platform_set_drvdata(pdev, ctlr);
 
-- 
2.34.1



  parent reply	other threads:[~2024-03-14 19:30 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-14 19:29 [PATCH 4.19.y-cip 0/9] Add RPC-IF support for RZ/G2{EHMN} Lad Prabhakar
2024-03-14 19:29 ` [PATCH 4.19.y-cip 1/9] memory: renesas-rpc-if: fix possible NULL pointer dereference of resource Lad Prabhakar
2024-03-14 21:09   ` Pavel Machek
2024-03-14 19:29 ` [PATCH 4.19.y-cip 2/9] memory: renesas-rpc-if: Correct QSPI data transfer in Manual mode Lad Prabhakar
2024-03-14 19:29 ` [PATCH 4.19.y-cip 3/9] memory: renesas-rpc-if: Fix HF/OSPI data transfer in Manual Mode Lad Prabhakar
2024-03-14 19:29 ` [PATCH 4.19.y-cip 4/9] memory: renesas-rpc-if: Return error in case devm_ioremap_resource() fails Lad Prabhakar
2024-03-14 19:29 ` [PATCH 4.19.y-cip 5/9] memory: renesas-rpc-if: Drop usage of RPCIF_DIRMAP_SIZE macro Lad Prabhakar
2024-03-14 19:29 ` [PATCH 4.19.y-cip 6/9] memory: renesas-rpc-if: Simplify single/double data register access Lad Prabhakar
2024-03-14 19:29 ` [PATCH 4.19.y-cip 7/9] memory: renesas-rpc-if: Remove redundant division of dummy Lad Prabhakar
2024-03-14 19:29 ` Lad Prabhakar [this message]
2024-03-14 19:29 ` [PATCH 4.19.y-cip 9/9] arm64: dts: renesas: rzg2: Add RPC-IF Support Lad Prabhakar
2024-03-14 19:48 ` [cip-dev] [PATCH 4.19.y-cip 0/9] Add RPC-IF support for RZ/G2{EHMN} Chris Paterson
2024-03-14 20:00   ` Pavel Machek
2024-03-14 21:10 ` Pavel Machek
2024-03-18 11:32   ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240314192950.27343-9-prabhakar.mahadev-lad.rj@bp.renesas.com \
    --to=prabhakar.mahadev-lad.rj@bp.renesas.com \
    --cc=biju.das.jz@bp.renesas.com \
    --cc=cip-dev@lists.cip-project.org \
    --cc=nobuhiro1.iwamatsu@toshiba.co.jp \
    --cc=pavel@denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.