All of lore.kernel.org
 help / color / mirror / Atom feed
From: alexs@kernel.org
To: kasong@tencent.com, Andrew Morton <akpm@linux-foundation.org>,
	linux-mm@kvack.org (open list:MEMORY MANAGEMENT),
	linux-kernel@vger.kernel.org (open list)
Subject: [PATCH 01/12] mm/ksm: catch tail page abnormal in page_stable_node
Date: Mon, 18 Mar 2024 20:14:30 +0800	[thread overview]
Message-ID: <20240318121443.3991104-1-alexs@kernel.org> (raw)

From: Alex Shi <alexs@kernel.org>

commit 19138349ed59 ("mm/migrate: Add folio_migrate_flags()") change the
meaning of func page_stable_node() to check the compound head for tail
'page' instead of tail page self.
But seems both semantics are same at results, the func always return NULL
 for tail page. So adding a bug monitor here in case of abnormal.

Signed-off-by: Alex Shi <alexs@kernel.org>
Cc: Izik Eidus <izik.eidus@ravellosystems.com>
Cc: Matthew Wilcox <willy@infradead.org>
Cc: Andrea Arcangeli <aarcange@redhat.com>
Cc: Hugh Dickins <hughd@google.com>
Cc: Chris Wright <chrisw@sous-sol.org>
To: linux-kernel@vger.kernel.org
To: linux-mm@kvack.org
To: Andrew Morton <akpm@linux-foundation.org>
---
 mm/ksm.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/mm/ksm.c b/mm/ksm.c
index 8c001819cf10..3ff469961927 100644
--- a/mm/ksm.c
+++ b/mm/ksm.c
@@ -1091,7 +1091,12 @@ static inline struct ksm_stable_node *folio_stable_node(struct folio *folio)
 
 static inline struct ksm_stable_node *page_stable_node(struct page *page)
 {
-	return folio_stable_node(page_folio(page));
+	struct ksm_stable_node *node;
+
+	node = folio_stable_node(page_folio(page));
+	VM_BUG_ON_PAGE(PageTail(page) && node, page);
+
+	return node;
 }
 
 static inline void set_page_stable_node(struct page *page,
-- 
2.43.0


             reply	other threads:[~2024-03-18 12:11 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-18 12:14 alexs [this message]
2024-03-18 12:25 ` [PATCH 01/12] mm/ksm: catch tail page abnormal in page_stable_node David Hildenbrand
2024-03-20  9:05   ` Alex Shi
2024-03-20  9:29     ` David Hildenbrand
2024-03-20 12:03       ` Alex Shi
2024-03-18 13:14 ` Matthew Wilcox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240318121443.3991104-1-alexs@kernel.org \
    --to=alexs@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=kasong@tencent.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.