All of lore.kernel.org
 help / color / mirror / Atom feed
From: Maksim Davydov <davydov-max@yandex-team.ru>
To: qemu-devel@nongnu.org
Cc: davydov-max@yandex-team.ru, vsementsov@yandex-team.ru,
	peter.maydell@linaro.org, jsnow@redhat.com, philmd@linaro.org,
	armbru@redhat.com, peterx@redhat.com, farosas@suse.de,
	pbonzini@redhat.com, berrange@redhat.com, eduardo@habkost.net
Subject: [PULL v2 1/4] qom: add default value
Date: Tue, 19 Mar 2024 00:35:47 +0300	[thread overview]
Message-ID: <20240318213550.155573-2-davydov-max@yandex-team.ru> (raw)
In-Reply-To: <20240318213550.155573-1-davydov-max@yandex-team.ru>

qmp_qom_list_properties can print default values if they are available
as qmp_device_list_properties does, because both of them use the
ObjectPropertyInfo structure with default_value field. This can be useful
when working with "not device" types (e.g. memory-backend).

Signed-off-by: Maksim Davydov <davydov-max@yandex-team.ru>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
---
 qom/qom-qmp-cmds.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/qom/qom-qmp-cmds.c b/qom/qom-qmp-cmds.c
index 7c087299de..e91a235347 100644
--- a/qom/qom-qmp-cmds.c
+++ b/qom/qom-qmp-cmds.c
@@ -212,6 +212,7 @@ ObjectPropertyInfoList *qmp_qom_list_properties(const char *typename,
         info->name = g_strdup(prop->name);
         info->type = g_strdup(prop->type);
         info->description = g_strdup(prop->description);
+        info->default_value = qobject_ref(prop->defval);
 
         QAPI_LIST_PREPEND(prop_list, info);
     }
-- 
2.34.1



  reply	other threads:[~2024-03-18 21:36 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-18 21:35 [PULL v2 0/4] machine development tool Maksim Davydov
2024-03-18 21:35 ` Maksim Davydov [this message]
2024-03-18 21:35 ` [PULL v2 2/4] qmp: add dump machine type compatibility properties Maksim Davydov
2024-03-18 21:35 ` [PULL v2 3/4] python/qemu/machine: add method to retrieve QEMUMachine::binary field Maksim Davydov
2024-03-18 21:35 ` [PULL v2 4/4] scripts: add script to compare compatibility properties Maksim Davydov
2024-03-19 10:24 ` [PULL v2 0/4] machine development tool Peter Maydell
2024-03-19 14:36   ` Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240318213550.155573-2-davydov-max@yandex-team.ru \
    --to=davydov-max@yandex-team.ru \
    --cc=armbru@redhat.com \
    --cc=berrange@redhat.com \
    --cc=eduardo@habkost.net \
    --cc=farosas@suse.de \
    --cc=jsnow@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=peterx@redhat.com \
    --cc=philmd@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=vsementsov@yandex-team.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.