All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shiyang Ruan via <qemu-devel@nongnu.org>
To: dave@treblig.org
Cc: qemu-devel@nongnu.org, jonathan.cameron@huawei.com,
	Yao Xingtao <yaoxt.fnst@fujitsu.com>
Subject: [PATCH] monitor/hmp-cmds-target.c: append a space in error message in gpa2hva()
Date: Tue, 19 Mar 2024 10:16:10 +0800	[thread overview]
Message-ID: <20240319021610.2423844-1-ruansy.fnst@fujitsu.com> (raw)

From: Yao Xingtao <yaoxt.fnst@fujitsu.com>

In qemu monitor mode, when we use gpa2hva command to print the host
virtual address corresponding to a guest physical address, if the gpa is
not in RAM, the error message is below:

(qemu) gpa2hva 0x750000000
Memory at address 0x750000000is not RAM

a space is missed between '0x750000000' and 'is'.

Signed-off-by: Yao Xingtao <yaoxt.fnst@fujitsu.com>
---
 monitor/hmp-cmds-target.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/monitor/hmp-cmds-target.c b/monitor/hmp-cmds-target.c
index 9338ae8440..ff01cf9d8d 100644
--- a/monitor/hmp-cmds-target.c
+++ b/monitor/hmp-cmds-target.c
@@ -261,7 +261,7 @@ void *gpa2hva(MemoryRegion **p_mr, hwaddr addr, uint64_t size, Error **errp)
     }
 
     if (!memory_region_is_ram(mrs.mr) && !memory_region_is_romd(mrs.mr)) {
-        error_setg(errp, "Memory at address 0x%" HWADDR_PRIx "is not RAM", addr);
+        error_setg(errp, "Memory at address 0x%" HWADDR_PRIx " is not RAM", addr);
         memory_region_unref(mrs.mr);
         return NULL;
     }
-- 
2.27.0



             reply	other threads:[~2024-03-19  2:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-19  2:16 Shiyang Ruan via [this message]
2024-03-19 12:54 ` [PATCH-for-9.0] monitor/hmp-cmds-target.c: append a space in error message in gpa2hva() Philippe Mathieu-Daudé
2024-03-20 22:42   ` Dr. David Alan Gilbert
2024-03-26  9:58 ` [PATCH] " Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240319021610.2423844-1-ruansy.fnst@fujitsu.com \
    --to=qemu-devel@nongnu.org \
    --cc=dave@treblig.org \
    --cc=jonathan.cameron@huawei.com \
    --cc=ruansy.fnst@fujitsu.com \
    --cc=yaoxt.fnst@fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.