From: Sunil Khatri <sunil.khatri@amd.com>
To: "Alex Deucher" <alexander.deucher@amd.com>,
"Christian König" <christian.koenig@amd.com>,
"Shashank Sharma" <shashank.sharma@amd.com>
Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org,
Hawking Zhang <Hawking.Zhang@amd.com>,
Felix Kuehling <Felix.Kuehling@amd.com>,
Lijo Lazar <lijo.lazar@amd.com>,
Sunil Khatri <sunil.khatri@amd.com>
Subject: [PATCH] drm/amdgpu: fix function implicit declaration error
Date: Thu, 21 Mar 2024 23:44:03 +0530 [thread overview]
Message-ID: <20240321181403.1365947-1-sunil.khatri@amd.com> (raw)
when CONFIG_DEV_COREDUMP is not defined in that case
when amdgpu_coredump() is called it does not find it's
definition and the build fails.
This happens as the header is defined without the
CONFIG_DEV_COREDUMP ifdef and due to which header isn't
enabled.
Pulling the header out of such ifdef so in both the
cases the build does not fail.
Signed-off-by: Sunil Khatri <sunil.khatri@amd.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
index 95028f57cb56..f771b2042a43 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
@@ -74,10 +74,7 @@
#include "amdgpu_fru_eeprom.h"
#include "amdgpu_reset.h"
#include "amdgpu_virt.h"
-
-#ifdef CONFIG_DEV_COREDUMP
#include "amdgpu_dev_coredump.h"
-#endif
#include <linux/suspend.h>
#include <drm/task_barrier.h>
--
2.34.1
next reply other threads:[~2024-03-21 18:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-21 18:14 Sunil Khatri [this message]
2024-03-21 19:45 ` [PATCH] drm/amdgpu: fix function implicit declaration error Alex Deucher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240321181403.1365947-1-sunil.khatri@amd.com \
--to=sunil.khatri@amd.com \
--cc=Felix.Kuehling@amd.com \
--cc=Hawking.Zhang@amd.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=lijo.lazar@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=shashank.sharma@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.