From: "Rafał Miłecki" <zajec5@gmail.com> To: Felix Fietkau <nbd@nbd.name>, Lorenzo Bianconi <lorenzo@kernel.org>, Ryder Lee <ryder.lee@mediatek.com>, Shayne Chen <shayne.chen@mediatek.com>, Sean Wang <sean.wang@mediatek.com> Cc: "Kalle Valo" <kvalo@kernel.org>, "Matthias Brugger" <matthias.bgg@gmail.com>, "AngeloGioacchino Del Regno" <angelogioacchino.delregno@collabora.com>, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, openwrt-devel@lists.openwrt.org, "Rafał Miłecki" <rafal@milecki.pl> Subject: [PATCH] wifi: mt76: mt7603: add debugfs attr for disabling frames buffering Date: Mon, 25 Mar 2024 23:33:19 +0100 [thread overview] Message-ID: <20240325223319.30125-1-zajec5@gmail.com> (raw) From: Rafał Miłecki <rafal@milecki.pl> MT7603EN and MT7628AN were reported by multiple users to be unstable under high traffic. Transmission of packets could stop for seconds often leading to disconnections. Long research & debugging revelaed a close relation between MCU interrupts of type PKT_TYPE_TXS and slowdowns / stalls. That led to questioning frames buffering feature. It turns out that disabling SKBs loopback code makes mt7603 devices much more stable under load. There are still some traffic hiccups but those happen like once every an hour and end up in recovery in most cases. Add a debugfs option for disabling frames buffering so users can give it a try. If this solution yields a success we can make this feature disabled by default. This change was successfully tested using 2 GHz AP interface on: 1. Netgear R6220 - MT7621ST (SoC) + MT7603EN (WiFi) + MT7612EN (WiFi) 2. Xiaomi Mi Router 4C - MT7628AN (Wi-Fi SoC) Link: https://lore.kernel.org/linux-wireless/7c96d5ee-86c1-8068-1b58-40db6087a24f@gmail.com/ Closes: https://github.com/openwrt/mt76/issues/865 Fixes: c8846e101502 ("mt76: add driver for MT7603E and MT7628/7688") Signed-off-by: Rafał Miłecki <rafal@milecki.pl> --- drivers/net/wireless/mediatek/mt76/mt7603/debugfs.c | 2 ++ drivers/net/wireless/mediatek/mt76/mt7603/dma.c | 3 +++ drivers/net/wireless/mediatek/mt76/mt7603/init.c | 1 + drivers/net/wireless/mediatek/mt76/mt7603/mt7603.h | 2 ++ 4 files changed, 8 insertions(+) diff --git a/drivers/net/wireless/mediatek/mt76/mt7603/debugfs.c b/drivers/net/wireless/mediatek/mt76/mt7603/debugfs.c index 3967f2f05774..c80baba7a402 100644 --- a/drivers/net/wireless/mediatek/mt76/mt7603/debugfs.c +++ b/drivers/net/wireless/mediatek/mt76/mt7603/debugfs.c @@ -115,4 +115,6 @@ void mt7603_init_debugfs(struct mt7603_dev *dev) &dev->sensitivity_limit); debugfs_create_bool("dynamic_sensitivity", 0600, dir, &dev->dynamic_sensitivity); + debugfs_create_bool("frames_buffering", 0600, dir, + &dev->frames_buffering); } diff --git a/drivers/net/wireless/mediatek/mt76/mt7603/dma.c b/drivers/net/wireless/mediatek/mt76/mt7603/dma.c index 7a2f5d38562b..f5ab729dec31 100644 --- a/drivers/net/wireless/mediatek/mt76/mt7603/dma.c +++ b/drivers/net/wireless/mediatek/mt76/mt7603/dma.c @@ -27,6 +27,9 @@ mt7603_rx_loopback_skb(struct mt7603_dev *dev, struct sk_buff *skb) u32 val; u8 tid = 0; + if (!dev->frames_buffering) + goto free; + if (skb->len < MT_TXD_SIZE + sizeof(struct ieee80211_hdr)) goto free; diff --git a/drivers/net/wireless/mediatek/mt76/mt7603/init.c b/drivers/net/wireless/mediatek/mt76/mt7603/init.c index 6c55c72f28a2..5abc2618ec8b 100644 --- a/drivers/net/wireless/mediatek/mt76/mt7603/init.c +++ b/drivers/net/wireless/mediatek/mt76/mt7603/init.c @@ -515,6 +515,7 @@ int mt7603_register_device(struct mt7603_dev *dev) dev->slottime = 9; dev->sensitivity_limit = 28; dev->dynamic_sensitivity = true; + dev->frames_buffering = true; ret = mt7603_init_hardware(dev); if (ret) diff --git a/drivers/net/wireless/mediatek/mt76/mt7603/mt7603.h b/drivers/net/wireless/mediatek/mt76/mt7603/mt7603.h index 9e58df7042ad..02c88334cdc0 100644 --- a/drivers/net/wireless/mediatek/mt76/mt7603/mt7603.h +++ b/drivers/net/wireless/mediatek/mt76/mt7603/mt7603.h @@ -155,6 +155,8 @@ struct mt7603_dev { u32 reset_test; unsigned int reset_cause[__RESET_CAUSE_MAX]; + + bool frames_buffering; }; extern const struct mt76_driver_ops mt7603_drv_ops; -- 2.35.3
WARNING: multiple messages have this Message-ID (diff)
From: "Rafał Miłecki" <zajec5@gmail.com> To: Felix Fietkau <nbd@nbd.name>, Lorenzo Bianconi <lorenzo@kernel.org>, Ryder Lee <ryder.lee@mediatek.com>, Shayne Chen <shayne.chen@mediatek.com>, Sean Wang <sean.wang@mediatek.com> Cc: "Kalle Valo" <kvalo@kernel.org>, "Matthias Brugger" <matthias.bgg@gmail.com>, "AngeloGioacchino Del Regno" <angelogioacchino.delregno@collabora.com>, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, openwrt-devel@lists.openwrt.org, "Rafał Miłecki" <rafal@milecki.pl> Subject: [PATCH] wifi: mt76: mt7603: add debugfs attr for disabling frames buffering Date: Mon, 25 Mar 2024 23:33:19 +0100 [thread overview] Message-ID: <20240325223319.30125-1-zajec5@gmail.com> (raw) From: Rafał Miłecki <rafal@milecki.pl> MT7603EN and MT7628AN were reported by multiple users to be unstable under high traffic. Transmission of packets could stop for seconds often leading to disconnections. Long research & debugging revelaed a close relation between MCU interrupts of type PKT_TYPE_TXS and slowdowns / stalls. That led to questioning frames buffering feature. It turns out that disabling SKBs loopback code makes mt7603 devices much more stable under load. There are still some traffic hiccups but those happen like once every an hour and end up in recovery in most cases. Add a debugfs option for disabling frames buffering so users can give it a try. If this solution yields a success we can make this feature disabled by default. This change was successfully tested using 2 GHz AP interface on: 1. Netgear R6220 - MT7621ST (SoC) + MT7603EN (WiFi) + MT7612EN (WiFi) 2. Xiaomi Mi Router 4C - MT7628AN (Wi-Fi SoC) Link: https://lore.kernel.org/linux-wireless/7c96d5ee-86c1-8068-1b58-40db6087a24f@gmail.com/ Closes: https://github.com/openwrt/mt76/issues/865 Fixes: c8846e101502 ("mt76: add driver for MT7603E and MT7628/7688") Signed-off-by: Rafał Miłecki <rafal@milecki.pl> --- drivers/net/wireless/mediatek/mt76/mt7603/debugfs.c | 2 ++ drivers/net/wireless/mediatek/mt76/mt7603/dma.c | 3 +++ drivers/net/wireless/mediatek/mt76/mt7603/init.c | 1 + drivers/net/wireless/mediatek/mt76/mt7603/mt7603.h | 2 ++ 4 files changed, 8 insertions(+) diff --git a/drivers/net/wireless/mediatek/mt76/mt7603/debugfs.c b/drivers/net/wireless/mediatek/mt76/mt7603/debugfs.c index 3967f2f05774..c80baba7a402 100644 --- a/drivers/net/wireless/mediatek/mt76/mt7603/debugfs.c +++ b/drivers/net/wireless/mediatek/mt76/mt7603/debugfs.c @@ -115,4 +115,6 @@ void mt7603_init_debugfs(struct mt7603_dev *dev) &dev->sensitivity_limit); debugfs_create_bool("dynamic_sensitivity", 0600, dir, &dev->dynamic_sensitivity); + debugfs_create_bool("frames_buffering", 0600, dir, + &dev->frames_buffering); } diff --git a/drivers/net/wireless/mediatek/mt76/mt7603/dma.c b/drivers/net/wireless/mediatek/mt76/mt7603/dma.c index 7a2f5d38562b..f5ab729dec31 100644 --- a/drivers/net/wireless/mediatek/mt76/mt7603/dma.c +++ b/drivers/net/wireless/mediatek/mt76/mt7603/dma.c @@ -27,6 +27,9 @@ mt7603_rx_loopback_skb(struct mt7603_dev *dev, struct sk_buff *skb) u32 val; u8 tid = 0; + if (!dev->frames_buffering) + goto free; + if (skb->len < MT_TXD_SIZE + sizeof(struct ieee80211_hdr)) goto free; diff --git a/drivers/net/wireless/mediatek/mt76/mt7603/init.c b/drivers/net/wireless/mediatek/mt76/mt7603/init.c index 6c55c72f28a2..5abc2618ec8b 100644 --- a/drivers/net/wireless/mediatek/mt76/mt7603/init.c +++ b/drivers/net/wireless/mediatek/mt76/mt7603/init.c @@ -515,6 +515,7 @@ int mt7603_register_device(struct mt7603_dev *dev) dev->slottime = 9; dev->sensitivity_limit = 28; dev->dynamic_sensitivity = true; + dev->frames_buffering = true; ret = mt7603_init_hardware(dev); if (ret) diff --git a/drivers/net/wireless/mediatek/mt76/mt7603/mt7603.h b/drivers/net/wireless/mediatek/mt76/mt7603/mt7603.h index 9e58df7042ad..02c88334cdc0 100644 --- a/drivers/net/wireless/mediatek/mt76/mt7603/mt7603.h +++ b/drivers/net/wireless/mediatek/mt76/mt7603/mt7603.h @@ -155,6 +155,8 @@ struct mt7603_dev { u32 reset_test; unsigned int reset_cause[__RESET_CAUSE_MAX]; + + bool frames_buffering; }; extern const struct mt76_driver_ops mt7603_drv_ops; -- 2.35.3 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next reply other threads:[~2024-03-25 22:33 UTC|newest] Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top 2024-03-25 22:33 Rafał Miłecki [this message] 2024-03-25 22:33 ` [PATCH] wifi: mt76: mt7603: add debugfs attr for disabling frames buffering Rafał Miłecki 2024-03-25 23:11 ` Rafał Miłecki 2024-03-26 7:01 ` Rafał Miłecki 2024-03-26 7:01 ` Rafał Miłecki 2024-04-02 16:54 ` Shengyu Qu 2024-04-02 16:54 ` Shengyu Qu 2024-04-03 4:40 ` Rafał Miłecki 2024-04-03 4:40 ` Rafał Miłecki
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20240325223319.30125-1-zajec5@gmail.com \ --to=zajec5@gmail.com \ --cc=angelogioacchino.delregno@collabora.com \ --cc=kvalo@kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mediatek@lists.infradead.org \ --cc=linux-wireless@vger.kernel.org \ --cc=lorenzo@kernel.org \ --cc=matthias.bgg@gmail.com \ --cc=nbd@nbd.name \ --cc=openwrt-devel@lists.openwrt.org \ --cc=rafal@milecki.pl \ --cc=ryder.lee@mediatek.com \ --cc=sean.wang@mediatek.com \ --cc=shayne.chen@mediatek.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.