All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: qemu-devel@nongnu.org
Cc: qemu-arm@nongnu.org, qemu-ppc@nongnu.org,
	"Yao Xingtao" <yaoxt.fnst@fujitsu.com>,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>,
	"Dr . David Alan Gilbert" <dave@treblig.org>
Subject: [PULL 03/13] monitor/hmp-cmds-target: Append a space in error message in gpa2hva()
Date: Tue, 26 Mar 2024 16:44:54 +0100	[thread overview]
Message-ID: <20240326154505.8300-4-philmd@linaro.org> (raw)
In-Reply-To: <20240326154505.8300-1-philmd@linaro.org>

From: Yao Xingtao <yaoxt.fnst@fujitsu.com>

In qemu monitor mode, when we use gpa2hva command to print the host
virtual address corresponding to a guest physical address, if the gpa is
not in RAM, the error message is below:

  (qemu) gpa2hva 0x750000000
  Memory at address 0x750000000is not RAM

A space is missed between '0x750000000' and 'is'.

Signed-off-by: Yao Xingtao <yaoxt.fnst@fujitsu.com>
Fixes: e9628441df ("hmp: gpa2hva and gpa2hpa hostaddr command")
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Dr. David Alan Gilbert <dave@treblig.org>
Message-ID: <20240319021610.2423844-1-ruansy.fnst@fujitsu.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
 monitor/hmp-cmds-target.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/monitor/hmp-cmds-target.c b/monitor/hmp-cmds-target.c
index 9338ae8440..ff01cf9d8d 100644
--- a/monitor/hmp-cmds-target.c
+++ b/monitor/hmp-cmds-target.c
@@ -261,7 +261,7 @@ void *gpa2hva(MemoryRegion **p_mr, hwaddr addr, uint64_t size, Error **errp)
     }
 
     if (!memory_region_is_ram(mrs.mr) && !memory_region_is_romd(mrs.mr)) {
-        error_setg(errp, "Memory at address 0x%" HWADDR_PRIx "is not RAM", addr);
+        error_setg(errp, "Memory at address 0x%" HWADDR_PRIx " is not RAM", addr);
         memory_region_unref(mrs.mr);
         return NULL;
     }
-- 
2.41.0



  parent reply	other threads:[~2024-03-26 15:46 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-26 15:44 [PULL 00/13] Misc HW patches for 2024-03-26 Philippe Mathieu-Daudé
2024-03-26 15:44 ` [PULL 01/13] target/i386/tcg: Enable page walking from MMIO memory Philippe Mathieu-Daudé
2024-03-26 15:44 ` [PULL 02/13] hw/scsi/scsi-generic: Fix io_timeout property not applying Philippe Mathieu-Daudé
2024-03-26 15:44 ` Philippe Mathieu-Daudé [this message]
2024-03-26 15:44 ` [PULL 04/13] target/tricore/helper: Use correct string format in cpu_tlb_fill() Philippe Mathieu-Daudé
2024-03-26 15:44 ` [PULL 05/13] hw/clock: Let clock_set_mul_div() return a boolean value Philippe Mathieu-Daudé
2024-03-26 15:44 ` [PULL 06/13] hw/misc/stm32l4x5_rcc: Inline clock_update() in clock_mux_update() Philippe Mathieu-Daudé
2024-03-26 15:44 ` [PULL 07/13] hw/misc/stm32l4x5_rcc: Propagate period when enabling a clock Philippe Mathieu-Daudé
2024-03-26 15:44 ` [PULL 08/13] docs/system/ppc/amigang.rst: Fix formatting Philippe Mathieu-Daudé
2024-03-26 15:45 ` [PULL 09/13] contrib/plugins/execlog: Fix compiler warning Philippe Mathieu-Daudé
2024-03-26 15:45 ` [PULL 10/13] hw/smbios: add stub for smbios_get_table_legacy() Philippe Mathieu-Daudé
2024-03-26 15:45 ` [PULL 11/13] ui/cocoa: Fix aspect ratio Philippe Mathieu-Daudé
2024-03-26 15:45 ` [PULL 12/13] ui/cocoa: Resize window after toggling zoom-to-fit Philippe Mathieu-Daudé
2024-03-26 15:45 ` [PULL 13/13] ui/cocoa: Use NSTrackingInVisibleRect Philippe Mathieu-Daudé
2024-03-26 19:46 ` [PULL 00/13] Misc HW patches for 2024-03-26 Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240326154505.8300-4-philmd@linaro.org \
    --to=philmd@linaro.org \
    --cc=dave@treblig.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=yaoxt.fnst@fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.