All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: linux-sound@vger.kernel.org
Cc: alsa-devel@alsa-project.org, tiwai@suse.de, broonie@kernel.org,
	Charles Keepax <ckeepax@opensource.cirrus.com>,
	Richard Fitzgerald <rf@opensource.cirrus.com>,
	Shuming Fan <shumingf@realtek.com>, Jack Yu <jack.yu@realtek.com>,
	Oder Chiou <oder_chiou@realtek.com>,
	Bard liao <yung-chuan.liao@linux.intel.com>,
	Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Subject: [PATCH 11/34] ASoC: Intel: sof_sdw: Factor out DMIC DAI creation.
Date: Tue, 26 Mar 2024 11:04:06 -0500	[thread overview]
Message-ID: <20240326160429.13560-12-pierre-louis.bossart@linux.intel.com> (raw)
In-Reply-To: <20240326160429.13560-1-pierre-louis.bossart@linux.intel.com>

From: Charles Keepax <ckeepax@opensource.cirrus.com>

Factor out the creation of the DMIC DAI links into a helper function.
No functional change.

Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
---
 sound/soc/intel/boards/sof_sdw.c | 53 +++++++++++++++++++-------------
 1 file changed, 32 insertions(+), 21 deletions(-)

diff --git a/sound/soc/intel/boards/sof_sdw.c b/sound/soc/intel/boards/sof_sdw.c
index 9980652c901b..5571c9e85dd7 100644
--- a/sound/soc/intel/boards/sof_sdw.c
+++ b/sound/soc/intel/boards/sof_sdw.c
@@ -1659,6 +1659,34 @@ static int create_ssp_dailinks(struct snd_soc_card *card,
 	return 0;
 }
 
+static int create_dmic_dailinks(struct snd_soc_card *card,
+				struct snd_soc_dai_link **dai_links, int *be_id)
+{
+	struct device *dev = card->dev;
+	int ret;
+
+	ret = init_simple_dai_link(dev, *dai_links, be_id, "dmic01",
+				   0, 1, // DMIC only supports capture
+				   "DMIC01 Pin", "dmic-codec", "dmic-hifi",
+				   sof_sdw_dmic_init, NULL);
+	if (ret)
+		return ret;
+
+	(*dai_links)++;
+
+	ret = init_simple_dai_link(dev, *dai_links, be_id, "dmic16k",
+				   0, 1, // DMIC only supports capture
+				   "DMIC16k Pin", "dmic-codec", "dmic-hifi",
+				   /* don't call sof_sdw_dmic_init() twice */
+				   NULL, NULL);
+	if (ret)
+		return ret;
+
+	(*dai_links)++;
+
+	return 0;
+}
+
 static int sof_card_dai_links_create(struct snd_soc_card *card)
 {
 	struct device *dev = card->dev;
@@ -1825,30 +1853,13 @@ static int sof_card_dai_links_create(struct snd_soc_card *card)
 	if (dmic_num > 0) {
 		if (ctx->ignore_pch_dmic) {
 			dev_warn(dev, "Ignoring PCH DMIC\n");
-			goto HDMI;
+		} else {
+			ret = create_dmic_dailinks(card, &dai_links, &be_id);
+			if (ret)
+				return ret;
 		}
-
-		ret = init_simple_dai_link(dev, dai_links, &be_id, "dmic01",
-					   0, 1, // DMIC only supports capture
-					   "DMIC01 Pin", "dmic-codec", "dmic-hifi",
-					   sof_sdw_dmic_init, NULL);
-		if (ret)
-			return ret;
-
-		dai_links++;
-
-		ret = init_simple_dai_link(dev, dai_links, &be_id, "dmic16k",
-					   0, 1, // DMIC only supports capture
-					   "DMIC16k Pin", "dmic-codec", "dmic-hifi",
-					   /* don't call sof_sdw_dmic_init() twice */
-					   NULL, NULL);
-		if (ret)
-			return ret;
-
-		dai_links++;
 	}
 
-HDMI:
 	/* HDMI */
 	for (i = 0; i < hdmi_num; i++) {
 		name = devm_kasprintf(dev, GFP_KERNEL, "iDisp%d", i + 1);
-- 
2.40.1


  parent reply	other threads:[~2024-03-26 16:05 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-26 16:03 [PATCH 00/34] ASoC: Intel: boards: updates for 6.10 - part2 Pierre-Louis Bossart
2024-03-26 16:03 ` [PATCH 01/34] ASoC: intel: sof_sdw: Make find_codec_info_part() return a pointer Pierre-Louis Bossart
2024-03-26 16:03 ` [PATCH 02/34] ASoC: intel: sof_sdw: Make find_codec_info_acpi() " Pierre-Louis Bossart
2024-03-26 16:03 ` [PATCH 03/34] ASoC: intel: sof_sdw: Make find_codec_info_dai() " Pierre-Louis Bossart
2024-03-26 16:03 ` [PATCH 04/34] ASoC: intel: sof_sdw: Only pass codec_conf pointer around Pierre-Louis Bossart
2024-03-26 16:04 ` [PATCH 05/34] ASoC: intel: sof_sdw: Set channel map directly from endpoints Pierre-Louis Bossart
2024-03-26 16:04 ` [PATCH 06/34] ASoC: Intel: sof_sdw: Move get_codec_dai_by_name() into sof_sdw itself Pierre-Louis Bossart
2024-03-26 16:04 ` [PATCH 07/34] ASoC: Intel: sof_sdw: Move flags to private struct Pierre-Louis Bossart
2024-03-26 16:04 ` [PATCH 08/34] ASoC: Intel: sof_sdw: Only pass dai_link pointer around Pierre-Louis Bossart
2024-03-26 16:04 ` [PATCH 09/34] ASoC: Intel: sof_sdw: Use for_each_set_bit Pierre-Louis Bossart
2024-03-26 16:04 ` [PATCH 10/34] ASoC: Intel: sof_sdw: Factor out SSP DAI creation Pierre-Louis Bossart
2024-03-26 16:04 ` Pierre-Louis Bossart [this message]
2024-03-26 16:04 ` [PATCH 12/34] ASoC: Intel: sof_sdw: Factor out HDMI " Pierre-Louis Bossart
2024-03-26 16:04 ` [PATCH 13/34] ASoC: Intel: sof_sdw: Factor out BlueTooth " Pierre-Louis Bossart
2024-03-26 16:04 ` [PATCH 14/34] ASoC: Intel: sof_sdw: Factor out codec name generation Pierre-Louis Bossart
2024-03-26 16:04 ` [PATCH 15/34] ASoC: Intel: soc-acpi-intel-arl-match: Add rt711 sdca codec support Pierre-Louis Bossart
2024-03-26 16:04 ` [PATCH 16/34] ASoC: Intel: sof_sdw: Remove no longer supported quirk Pierre-Louis Bossart
2024-03-26 16:04 ` [PATCH 17/34] ASoC: intel: soc-acpi: Add missing cs42l43 endpoints Pierre-Louis Bossart
2024-03-26 16:04 ` [PATCH 18/34] ASoC: Intel: sof-sdw: Add new code for parsing the snd_soc_acpi structs Pierre-Louis Bossart
2024-03-26 16:04 ` [PATCH 19/34] ASoC: Intel: sof_sdw: Move counting and codec_conf to new parsing Pierre-Louis Bossart
2024-03-26 16:04 ` [PATCH 20/34] ASoC: Intel: sof_sdw: Move ignore_pch_dmic " Pierre-Louis Bossart
2024-03-26 16:04 ` [PATCH 21/34] ASoC: Intel: sof_sdw: Move append_dai_type " Pierre-Louis Bossart
2024-03-26 16:04 ` [PATCH 22/34] ASoC: Intel: sof_sdw: Move generation of DAI links " Pierre-Louis Bossart
2024-03-26 16:04 ` [PATCH 23/34] ASoC: intel: sof_sdw: Factor out SoundWire DAI creation Pierre-Louis Bossart
2024-03-26 16:04 ` [PATCH 24/34] ASoC: Intel: sof_sdw: use generic rtd_init function for Realtek SDW DMICs Pierre-Louis Bossart
2024-03-26 16:04 ` [PATCH 25/34] ASoC: Intel: sof_sdw: remove unused rt dmic rtd_init Pierre-Louis Bossart
2024-03-26 16:04 ` [PATCH 26/34] ASoC: Intel: sof_sdw_rt722_sdca: set rtd_init in codec_info_list[] Pierre-Louis Bossart
2024-03-26 16:04 ` [PATCH 27/34] ASoC: Intel: sof_sdw_rt722_sdca: use rt_dmic_rtd_init Pierre-Louis Bossart
2024-03-26 16:04 ` [PATCH 28/34] ASoC: rt715-sdca: rename dai name with rt715-sdca prefix Pierre-Louis Bossart
2024-03-26 16:04 ` [PATCH 29/34] ASoC: Intel: sof_sdw: change rt715-sdca dai name Pierre-Louis Bossart
2024-03-26 16:04 ` [PATCH 30/34] ASoC: Intel: change cs35l56 name_prefix Pierre-Louis Bossart
2024-03-26 16:04 ` [PATCH 31/34] ASoC: Intel: sof_sdw: Don't pass acpi_link_adr to init functions Pierre-Louis Bossart
2024-03-26 16:04 ` [PATCH 32/34] ASoC: Intel: sof_sdw: Remove redundant initialisations Pierre-Louis Bossart
2024-03-26 16:04 ` [PATCH 33/34] ASoC: Intel: sof_sdw: Add quirk for optional codec speakers Pierre-Louis Bossart
2024-03-26 16:04 ` [PATCH 34/34] ASoC: Intel: sof_sdw: Add support for cs42l43 optional speaker output Pierre-Louis Bossart
2024-03-27 15:10 ` [PATCH 00/34] ASoC: Intel: boards: updates for 6.10 - part2 Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240326160429.13560-12-pierre-louis.bossart@linux.intel.com \
    --to=pierre-louis.bossart@linux.intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=ckeepax@opensource.cirrus.com \
    --cc=jack.yu@realtek.com \
    --cc=linux-sound@vger.kernel.org \
    --cc=oder_chiou@realtek.com \
    --cc=rf@opensource.cirrus.com \
    --cc=shumingf@realtek.com \
    --cc=tiwai@suse.de \
    --cc=yung-chuan.liao@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.