All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vinod Govindapillai <vinod.govindapillai@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: vinod.govindapillai@intel.com, stanislav.lisovskiy@intel.com,
	ville.syrjala@intel.com, jani.saarinen@intel.com
Subject: [PATCH v9 6/6] drm/i915/display: force qgv check after the hw state readout
Date: Wed, 27 Mar 2024 01:10:21 +0200	[thread overview]
Message-ID: <20240326231021.281780-7-vinod.govindapillai@intel.com> (raw)
In-Reply-To: <20240326231021.281780-1-vinod.govindapillai@intel.com>

The current intel_bw_atomic_check do not check the possbility
of a sagv configuration change after the hw state readout.
Hence cannot update the sagv configuration until some other
relevant changes like data rates, number of planes etc. happen.
Introduce a flag to force qgv check in such cases.

Signed-off-by: Vinod Govindapillai <vinod.govindapillai@intel.com>
---
 drivers/gpu/drm/i915/display/intel_bw.c | 8 ++++++--
 drivers/gpu/drm/i915/display/intel_bw.h | 6 ++++++
 2 files changed, 12 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_bw.c b/drivers/gpu/drm/i915/display/intel_bw.c
index f6690d545d95..ecb9600cb69a 100644
--- a/drivers/gpu/drm/i915/display/intel_bw.c
+++ b/drivers/gpu/drm/i915/display/intel_bw.c
@@ -755,6 +755,7 @@ void intel_bw_crtc_update(struct intel_bw_state *bw_state,
 		intel_bw_crtc_data_rate(crtc_state);
 	bw_state->num_active_planes[crtc->pipe] =
 		intel_bw_crtc_num_active_planes(crtc_state);
+	bw_state->force_check_qgv = true;
 
 	drm_dbg_kms(&i915->drm, "pipe %c data rate %u num active planes %u\n",
 		    pipe_name(crtc->pipe),
@@ -1341,8 +1342,9 @@ int intel_bw_atomic_check(struct intel_atomic_state *state)
 	new_bw_state = intel_atomic_get_new_bw_state(state);
 
 	if (new_bw_state &&
-	    intel_can_enable_sagv(i915, old_bw_state) !=
-	    intel_can_enable_sagv(i915, new_bw_state))
+	    (intel_can_enable_sagv(i915, old_bw_state) !=
+	     intel_can_enable_sagv(i915, new_bw_state) ||
+	     new_bw_state->force_check_qgv))
 		changed = true;
 
 	/*
@@ -1356,6 +1358,8 @@ int intel_bw_atomic_check(struct intel_atomic_state *state)
 	if (ret)
 		return ret;
 
+	new_bw_state->force_check_qgv = false;
+
 	return 0;
 }
 
diff --git a/drivers/gpu/drm/i915/display/intel_bw.h b/drivers/gpu/drm/i915/display/intel_bw.h
index fa1e924ec961..161813cca473 100644
--- a/drivers/gpu/drm/i915/display/intel_bw.h
+++ b/drivers/gpu/drm/i915/display/intel_bw.h
@@ -47,6 +47,12 @@ struct intel_bw_state {
 	 */
 	u16 qgv_points_mask;
 
+	/*
+	 * Flag to force the QGV comparison in atomic check right after the
+	 * hw state readout
+	 */
+	bool force_check_qgv;
+
 	int min_cdclk[I915_MAX_PIPES];
 	unsigned int data_rate[I915_MAX_PIPES];
 	u8 num_active_planes[I915_MAX_PIPES];
-- 
2.34.1


  parent reply	other threads:[~2024-03-26 23:11 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-26 23:10 [PATCH v9 0/6] QGV/SAGV related fixes Vinod Govindapillai
2024-03-26 23:10 ` [PATCH v9 1/6] drm/i915/display: Add meaningful traces for QGV point info error handling Vinod Govindapillai
2024-03-26 23:10 ` [PATCH v9 2/6] drm/i915/display: Extract code required to calculate max qgv/psf gv point Vinod Govindapillai
2024-03-26 23:10 ` [PATCH v9 3/6] drm/i915/display: extract code to prepare qgv points mask Vinod Govindapillai
2024-03-26 23:10 ` [PATCH v9 4/6] drm/i915/display: Disable SAGV on bw init, to force QGV point recalculation Vinod Govindapillai
2024-03-26 23:10 ` [PATCH v9 5/6] drm/i915/display: handle systems with duplicate qgv/psf gv points Vinod Govindapillai
2024-03-26 23:10 ` Vinod Govindapillai [this message]
2024-03-26 23:20 ` [PATCH v9 0/6] QGV/SAGV related fixes Govindapillai, Vinod
2024-03-27  2:25 ` ✗ Fi.CI.SPARSE: warning for QGV/SAGV related fixes (rev9) Patchwork
2024-03-27  2:39 ` ✗ Fi.CI.BAT: failure " Patchwork
2024-03-27 12:08 ` Patchwork
2024-03-27 16:03 ` ✓ Fi.CI.BAT: success " Patchwork
2024-03-28  2:51 ` ✗ Fi.CI.IGT: failure " Patchwork
2024-04-01 17:00 ` ✓ Fi.CI.IGT: success " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240326231021.281780-7-vinod.govindapillai@intel.com \
    --to=vinod.govindapillai@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jani.saarinen@intel.com \
    --cc=stanislav.lisovskiy@intel.com \
    --cc=ville.syrjala@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.