From: Louis Chauvet <louis.chauvet@bootlin.com>
To: Mark Brown <broonie@kernel.org>
Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org,
thomas.petazzoni@bootlin.com,
Miquel Raynal <miquel.raynal@bootlin.com>,
yen-mei.goh@keysight.com, koon-kee.lie@keysight.com,
jeremie.dautheribes@bootlin.com,
Louis Chauvet <louis.chauvet@bootlin.com>
Subject: [PATCH v3 0/3] Add multi mode support for omap-mcspi
Date: Wed, 27 Mar 2024 09:43:35 +0100 [thread overview]
Message-ID: <20240327-spi-omap2-mcspi-multi-mode-v3-0-c4ac329dd5a2@bootlin.com> (raw)
This series adds the support for the omap-mcspi multi mode which allows
sending SPI messages with a shorter delay between CS and the message.
One drawback of the multi-mode is that the CS is raised between each word,
so it can only be used with messages containing 1 word transfers and
asking for cs_change. Few devices, like FPGAs, may easily workaround this
limitation.
The first patch removes the current implementation, which is working, but
don't comply with what is asked in the spi transfer (The CS is raised by
the hardware regardless of cs_change state). No drivers or board file use this
implementation upstream.
The second patch adds the implementation of the multi-mode, which complies
with what is asked in the SPI message.
The third patch is the suggested optimization for using MULTI mode in more
situations.
Signed-off-by: Louis Chauvet <louis.chauvet@bootlin.com>
---
Changes in v3:
- Fix compilation warnings found with allmodconfig
- Link to v2: https://lore.kernel.org/r/20240223-spi-omap2-mcspi-multi-mode-v2-0-afe94476b9c3@bootlin.com
Changes in v2:
- Updated the commit line for the first patch to use the correct format;
- Updated the commit message for the second patch, adding precision on how
the controler works;
- Added the suggestion from Mark Brown to merge multiple transfers word
into one when applicable;
- Link to v1: https://lore.kernel.org/r/20240126-spi-omap2-mcspi-multi-mode-v1-0-d143d33f0fe0@bootlin.com
---
Louis Chauvet (3):
spi: spi-omap2-mcspi.c: revert "Toggle CS after each word"
spi: omap2-mcspi: Add support for MULTI-mode
spi: omap2-mcpsi: Enable MULTI-mode in more situations
drivers/spi/spi-omap2-mcspi.c | 95 +++++++++++++++++++++------
include/linux/platform_data/spi-omap2-mcspi.h | 3 -
2 files changed, 74 insertions(+), 24 deletions(-)
---
base-commit: 4cece764965020c22cff7665b18a012006359095
change-id: 20240126-spi-omap2-mcspi-multi-mode-e62f68b78ad3
Best regards,
--
Louis Chauvet <louis.chauvet@bootlin.com>
next reply other threads:[~2024-03-27 8:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-27 8:43 Louis Chauvet [this message]
2024-03-27 8:43 ` [PATCH v3 1/3] spi: spi-omap2-mcspi.c: revert "Toggle CS after each word" Louis Chauvet
2024-03-27 8:43 ` [PATCH v3 2/3] spi: omap2-mcspi: Add support for MULTI-mode Louis Chauvet
2024-03-27 8:43 ` [PATCH v3 3/3] spi: omap2-mcpsi: Enable MULTI-mode in more situations Louis Chauvet
2024-03-29 12:34 ` [PATCH v3 0/3] Add multi mode support for omap-mcspi Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240327-spi-omap2-mcspi-multi-mode-v3-0-c4ac329dd5a2@bootlin.com \
--to=louis.chauvet@bootlin.com \
--cc=broonie@kernel.org \
--cc=jeremie.dautheribes@bootlin.com \
--cc=koon-kee.lie@keysight.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=miquel.raynal@bootlin.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=yen-mei.goh@keysight.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.